Skip to content

Commit fb114da

Browse files
cortinicofacebook-github-bot
authored andcommitted
Remove unused internal UIManagerModuleListener (#53404)
Summary: Pull Request resolved: #53404 This interface is part of Legacy Architecture. No one is using it either internally or externally, so it's safe to remove now. Interface was also `internal` so this is not a breaking change. Changelog: [Internal] [Changed] - Reviewed By: mdvacca Differential Revision: D80714721 fbshipit-source-id: 82cc6152af7d7980119d2eda704ae50d8e81fd2b
1 parent 191ddc1 commit fb114da

File tree

3 files changed

+0
-41
lines changed

3 files changed

+0
-41
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4362,7 +4362,6 @@ public class com/facebook/react/uimanager/UIManagerModule : com/facebook/react/b
43624362
public fun addRootView (Landroid/view/View;Lcom/facebook/react/bridge/WritableMap;)I
43634363
public fun addUIBlock (Lcom/facebook/react/uimanager/UIBlock;)V
43644364
public fun addUIManagerEventListener (Lcom/facebook/react/bridge/UIManagerListener;)V
4365-
public fun addUIManagerListener (Lcom/facebook/react/uimanager/UIManagerModuleListener;)V
43664365
public fun clearJSResponder ()V
43674366
public fun configureNextLayoutAnimation (Lcom/facebook/react/bridge/ReadableMap;Lcom/facebook/react/bridge/Callback;Lcom/facebook/react/bridge/Callback;)V
43684367
public static fun createConstants (Ljava/util/List;Ljava/util/Map;Ljava/util/Map;)Ljava/util/Map;
@@ -4399,7 +4398,6 @@ public class com/facebook/react/uimanager/UIManagerModule : com/facebook/react/b
43994398
public fun receiveEvent (ILjava/lang/String;Lcom/facebook/react/bridge/WritableMap;)V
44004399
public fun removeRootView (I)V
44014400
public fun removeUIManagerEventListener (Lcom/facebook/react/bridge/UIManagerListener;)V
4402-
public fun removeUIManagerListener (Lcom/facebook/react/uimanager/UIManagerModuleListener;)V
44034401
public fun resolveCustomDirectEventName (Ljava/lang/String;)Ljava/lang/String;
44044402
public fun resolveRootTagFromReactTag (I)I
44054403
public fun resolveView (I)Landroid/view/View;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
import com.facebook.react.uimanager.internal.LegacyArchitectureShadowNodeLogger;
5353
import com.facebook.systrace.Systrace;
5454
import com.facebook.systrace.SystraceMessage;
55-
import java.util.ArrayList;
5655
import java.util.List;
5756
import java.util.Map;
5857
import java.util.concurrent.CopyOnWriteArrayList;
@@ -117,7 +116,6 @@ public interface CustomEventNamesResolver {
117116
private final ViewManagerRegistry mViewManagerRegistry;
118117
private final UIImplementation mUIImplementation;
119118
private final MemoryTrimCallback mMemoryTrimCallback = new MemoryTrimCallback();
120-
private final List<UIManagerModuleListener> mListeners = new ArrayList<>();
121119
private final CopyOnWriteArrayList<UIManagerListener> mUIManagerListeners =
122120
new CopyOnWriteArrayList<>();
123121

@@ -687,9 +685,6 @@ public void onBatchComplete() {
687685
SystraceMessage.beginSection(Systrace.TRACE_TAG_REACT, "onBatchCompleteUI")
688686
.arg("BatchId", batchId)
689687
.flush();
690-
for (UIManagerModuleListener listener : mListeners) {
691-
listener.willDispatchViewUpdates(this);
692-
}
693688
for (UIManagerListener listener : mUIManagerListeners) {
694689
listener.willDispatchViewUpdates(this);
695690
}
@@ -757,16 +752,6 @@ public void prependUIBlock(UIBlock block) {
757752
mUIImplementation.prependUIBlock(block);
758753
}
759754

760-
@Deprecated
761-
public void addUIManagerListener(UIManagerModuleListener listener) {
762-
mListeners.add(listener);
763-
}
764-
765-
@Deprecated
766-
public void removeUIManagerListener(UIManagerModuleListener listener) {
767-
mListeners.remove(listener);
768-
}
769-
770755
public void addUIManagerEventListener(UIManagerListener listener) {
771756
mUIManagerListeners.add(listener);
772757
}

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModuleListener.kt

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)