Fix CQS signal modernize-use-designated-initializers in xplat/js/react-native-github/packages [A] (#53971)

Summary: Pull Request resolved: #53971

Reviewed By: rshest

Differential Revision: D83395511

fbshipit-source-id: 832901c112d6ebf0b58280bf12a50f7845251c5c

Author: generatedunixname89002005287564

packages/react-native/ReactCommon/react/renderer/css/CSSRatio.h

@@ -55,10 +55,12 @@ struct CSSDataTypeParser<CSSRatio> {
       if (std::holds_alternative<CSSNumber>(denominator) &&
           std::get<CSSNumber>(denominator).value >= 0) {
         parseNextCSSValue<CSSNumber>(parser, CSSDelimiter::Solidus);
-        return CSSRatio{numeratorValue, std::get<CSSNumber>(denominator).value};
+        return CSSRatio{
+            .numerator = numeratorValue,
+            .denominator = std::get<CSSNumber>(denominator).value};
       }
 
-      return CSSRatio{numeratorValue, 1.0f};
+      return CSSRatio{.numerator = numeratorValue, .denominator = 1.0f};
     }
 
     return {};

packages/react-native/ReactCommon/react/renderer/css/CSSTransform.h

@@ -310,7 +310,7 @@ struct CSSDataTypeParser<CSSScale> {
         ? std::get<CSSNumber>(y).value
         : std::get<CSSPercentage>(y).value / 100.0f;
 
-    return CSSScale{normX, normY};
+    return CSSScale{.x = normX, .y = normY};
   }
 };
 

packages/react-native/ReactCommon/react/renderer/css/tests/CSSFilterTest.cpp

@@ -177,7 +177,7 @@ TEST(CSSFilter, drop_shadow_no_blur_pre_color) {
       std::get<CSSDropShadowFilter>(value).standardDeviation.unit,
       CSSLengthUnit::Px);
 
-  CSSColor red{255, 0, 0, 255};
+  CSSColor red{.r = 255, .g = 0, .b = 0, .a = 255};
   EXPECT_EQ(std::get<CSSDropShadowFilter>(value).color, red);
 }
 
@@ -195,7 +195,7 @@ TEST(CSSFilter, drop_shadow_no_blur_post_color) {
   EXPECT_EQ(
       std::get<CSSDropShadowFilter>(value).standardDeviation.unit,
       CSSLengthUnit::Px);
-  CSSColor red{255, 0, 0, 255};
+  CSSColor red{.r = 255, .g = 0, .b = 0, .a = 255};
 
   EXPECT_EQ(std::get<CSSDropShadowFilter>(value).color, red);
 }
@@ -231,7 +231,7 @@ TEST(CSSFilter, drop_shadow_with_blur_pre_color) {
       std::get<CSSDropShadowFilter>(value).standardDeviation.unit,
       CSSLengthUnit::Px);
 
-  CSSColor red{255, 0, 0, 255};
+  CSSColor red{.r = 255, .g = 0, .b = 0, .a = 255};
   EXPECT_EQ(std::get<CSSDropShadowFilter>(value).color, red);
 }
 
@@ -250,7 +250,7 @@ TEST(CSSFilter, drop_shadow_with_blur_post_color) {
       std::get<CSSDropShadowFilter>(value).standardDeviation.unit,
       CSSLengthUnit::Px);
 
-  CSSColor red{255, 0, 0, 255};
+  CSSColor red{.r = 255, .g = 0, .b = 0, .a = 255};
   EXPECT_EQ(std::get<CSSDropShadowFilter>(value).color, red);
 }
 
@@ -550,7 +550,7 @@ TEST(CSSFilter, filter_list) {
   EXPECT_EQ(
       std::get<CSSDropShadowFilter>(list[2]).standardDeviation.unit,
       CSSLengthUnit::Px);
-  CSSColor red{255, 0, 0, 255};
+  CSSColor red{.r = 255, .g = 0, .b = 0, .a = 255};
   EXPECT_EQ(std::get<CSSDropShadowFilter>(list[2]).color, red);
 
   EXPECT_TRUE(std::holds_alternative<CSSDropShadowFilter>(list[3]));

packages/react-native/ReactCommon/react/renderer/css/tests/CSSShadowTest.cpp

@@ -94,7 +94,7 @@ TEST(CSSShadow, trailing_color) {
   EXPECT_EQ(shadow.spreadDistance.value, 0.0f);
   EXPECT_EQ(shadow.spreadDistance.unit, CSSLengthUnit::Px);
 
-  CSSColor red{255u, 0u, 0u, 255u};
+  CSSColor red{.r = 255u, .g = 0u, .b = 0u, .a = 255u};
   EXPECT_EQ(shadow.color, red);
   EXPECT_FALSE(shadow.inset);
 }
@@ -113,7 +113,7 @@ TEST(CSSShadow, leading_color) {
   EXPECT_EQ(shadow.spreadDistance.value, 0.0f);
   EXPECT_EQ(shadow.spreadDistance.unit, CSSLengthUnit::Px);
 
-  CSSColor red{255u, 0u, 0u, 255u};
+  CSSColor red{.r = 255u, .g = 0u, .b = 0u, .a = 255u};
   EXPECT_EQ(shadow.color, red);
   EXPECT_FALSE(shadow.inset);
 }
@@ -132,7 +132,7 @@ TEST(CSSShadow, color_function) {
   EXPECT_EQ(shadow.spreadDistance.value, 0.0f);
   EXPECT_EQ(shadow.spreadDistance.unit, CSSLengthUnit::Px);
 
-  CSSColor red{255u, 0u, 0u, 128u};
+  CSSColor red{.r = 255u, .g = 0u, .b = 0u, .a = 128u};
   EXPECT_EQ(shadow.color, red);
   EXPECT_FALSE(shadow.inset);
 }
@@ -202,7 +202,7 @@ TEST(CSShadow, color_length_inset) {
   EXPECT_EQ(shadow.spreadDistance.value, 0.0f);
   EXPECT_EQ(shadow.spreadDistance.unit, CSSLengthUnit::Px);
 
-  CSSColor red{255u, 0u, 0u, 255u};
+  CSSColor red{.r = 255u, .g = 0u, .b = 0u, .a = 255u};
   EXPECT_EQ(shadow.color, red);
   EXPECT_TRUE(shadow.inset);
 }
@@ -224,7 +224,7 @@ TEST(CSSShadow, multiple_shadows) {
   EXPECT_EQ(shadows[0].spreadDistance.value, 0.0f);
   EXPECT_EQ(shadows[0].spreadDistance.unit, CSSLengthUnit::Px);
 
-  CSSColor red{255u, 0u, 0u, 255u};
+  CSSColor red{.r = 255u, .g = 0u, .b = 0u, .a = 255u};
   EXPECT_EQ(shadows[0].color, red);
   EXPECT_FALSE(shadows[0].inset);
 
@@ -268,7 +268,7 @@ TEST(CSSShadow, multiple_shadows_with_new_line) {
   EXPECT_EQ(shadows[0].spreadDistance.value, 0.0f);
   EXPECT_EQ(shadows[0].spreadDistance.unit, CSSLengthUnit::Px);
 
-  CSSColor red{255u, 0u, 0u, 255u};
+  CSSColor red{.r = 255u, .g = 0u, .b = 0u, .a = 255u};
   EXPECT_EQ(shadows[0].color, red);
   EXPECT_FALSE(shadows[0].inset);
 

packages/react-native/ReactCommon/react/renderer/dom/DOM.cpp

@@ -151,7 +151,9 @@ Rect getScrollableContentBounds(
       : std::max(
             paddingFrame.getMaxX(), contentBounds.getMaxX() + paddingRight);
 
-  return Rect{Point{minX, minY}, Size{maxX - minX, maxY - minY}};
+  return Rect{
+      .origin = Point{.x = minX, .y = minY},
+      .size = Size{.width = maxX - minX, .height = maxY - minY}};
 }
 
 } // namespace

packages/react-native/ReactCommon/react/renderer/element/ComponentBuilder.cpp

@@ -27,17 +27,19 @@ std::shared_ptr<ShadowNode> ComponentBuilder::build(
   }
 
   auto family = componentDescriptor.createFamily(ShadowNodeFamilyFragment{
-      elementFragment.tag, elementFragment.surfaceId, nullptr});
+      .tag = elementFragment.tag,
+      .surfaceId = elementFragment.surfaceId,
+      .instanceHandle = nullptr});
 
   auto initialState =
       componentDescriptor.createInitialState(elementFragment.props, family);
 
   auto constShadowNode = componentDescriptor.createShadowNode(
       ShadowNodeFragment{
-          elementFragment.props,
-          std::make_shared<
+          .props = elementFragment.props,
+          .children = std::make_shared<
               const std::vector<std::shared_ptr<const ShadowNode>>>(children),
-          initialState},
+          .state = initialState},
       family);
 
   if (elementFragment.stateCallback) {
@@ -46,9 +48,9 @@ std::shared_ptr<ShadowNode> ComponentBuilder::build(
     constShadowNode = componentDescriptor.cloneShadowNode(
         *constShadowNode,
         ShadowNodeFragment{
-            ShadowNodeFragment::propsPlaceholder(),
-            ShadowNodeFragment::childrenPlaceholder(),
-            newState});
+            .props = ShadowNodeFragment::propsPlaceholder(),
+            .children = ShadowNodeFragment::childrenPlaceholder(),
+            .state = newState});
   }
 
   auto shadowNode = std::const_pointer_cast<ShadowNode>(constShadowNode);

packages/react-native/ReactCommon/react/renderer/element/testUtils.h

@@ -26,7 +26,9 @@ inline ComponentBuilder simpleComponentBuilder(
   auto componentDescriptorRegistry =
       componentDescriptorProviderRegistry.createComponentDescriptorRegistry(
           ComponentDescriptorParameters{
-              eventDispatcher, std::move(contextContainer), nullptr});
+              .eventDispatcher = eventDispatcher,
+              .contextContainer = std::move(contextContainer),
+              .flavor = nullptr});
 
   componentDescriptorProviderRegistry.add(
       concreteComponentDescriptorProvider<RootComponentDescriptor>());

packages/react-native/ReactCommon/react/renderer/graphics/Color.cpp

@@ -53,17 +53,20 @@ SharedColor colorFromRGBA(uint8_t r, uint8_t g, uint8_t b, uint8_t a) {
 }
 
 SharedColor clearColor() {
-  static SharedColor color = colorFromComponents(ColorComponents{0, 0, 0, 0});
+  static SharedColor color = colorFromComponents(
+      ColorComponents{.red = 0, .green = 0, .blue = 0, .alpha = 0});
   return color;
 }
 
 SharedColor blackColor() {
-  static SharedColor color = colorFromComponents(ColorComponents{0, 0, 0, 1});
+  static SharedColor color = colorFromComponents(
+      ColorComponents{.red = 0, .green = 0, .blue = 0, .alpha = 1});
   return color;
 }
 
 SharedColor whiteColor() {
-  static SharedColor color = colorFromComponents(ColorComponents{1, 1, 1, 1});
+  static SharedColor color = colorFromComponents(
+      ColorComponents{.red = 1, .green = 1, .blue = 1, .alpha = 1});
   return color;
 }
 

packages/react-native/ReactCommon/react/renderer/graphics/Rect.h

@@ -21,8 +21,8 @@ namespace facebook::react {
  * Contains the location and dimensions of a rectangle.
  */
 struct Rect {
-  Point origin{0, 0};
-  Size size{0, 0};
+  Point origin{.x = 0, .y = 0};
+  Size size{.width = 0, .height = 0};
 
   bool operator==(const Rect& rhs) const noexcept {
     return std::tie(this->origin, this->size) == std::tie(rhs.origin, rhs.size);
@@ -51,16 +51,16 @@ struct Rect {
     return origin.y + size.height / 2;
   }
   Point getCenter() const noexcept {
-    return {getMidX(), getMidY()};
+    return {.x = getMidX(), .y = getMidY()};
   }
 
   void unionInPlace(const Rect& rect) noexcept {
     auto x1 = std::min(getMinX(), rect.getMinX());
     auto y1 = std::min(getMinY(), rect.getMinY());
     auto x2 = std::max(getMaxX(), rect.getMaxX());
     auto y2 = std::max(getMaxY(), rect.getMaxY());
-    origin = {x1, y1};
-    size = {x2 - x1, y2 - y1};
+    origin = {.x = x1, .y = y1};
+    size = {.width = x2 - x1, .height = y2 - y1};
   }
 
   bool containsPoint(Point point) noexcept {
@@ -84,7 +84,9 @@ struct Rect {
       return {};
     }
 
-    return {{x1, y1}, {intersectionWidth, intersectionHeight}};
+    return {
+        .origin = {.x = x1, .y = y1},
+        .size = {.width = intersectionWidth, .height = intersectionHeight}};
   }
 
   static Rect boundingRect(
@@ -112,9 +114,10 @@ struct Rect {
     rightBottomPoint.y = std::max(rightBottomPoint.y, d.y);
 
     return {
-        leftTopPoint,
-        {rightBottomPoint.x - leftTopPoint.x,
-         rightBottomPoint.y - leftTopPoint.y}};
+        .origin = leftTopPoint,
+        .size = {
+            .width = rightBottomPoint.x - leftTopPoint.x,
+            .height = rightBottomPoint.y - leftTopPoint.y}};
   }
 };
 

packages/react-native/ReactCommon/react/renderer/graphics/RectangleEdges.h

@@ -77,19 +77,23 @@ using EdgeInsets = RectangleEdges<Float>;
  */
 inline Rect insetBy(const Rect& rect, const EdgeInsets& insets) noexcept {
   return Rect{
-      {rect.origin.x + insets.left, rect.origin.y + insets.top},
-      {rect.size.width - insets.left - insets.right,
-       rect.size.height - insets.top - insets.bottom}};
+      .origin =
+          {.x = rect.origin.x + insets.left, .y = rect.origin.y + insets.top},
+      .size = {
+          .width = rect.size.width - insets.left - insets.right,
+          .height = rect.size.height - insets.top - insets.bottom}};
 }
 
 /*
  * Adjusts a rectangle by the given edge outsets.
  */
 inline Rect outsetBy(const Rect& rect, const EdgeInsets& outsets) noexcept {
   return Rect{
-      {rect.origin.x - outsets.left, rect.origin.y - outsets.top},
-      {rect.size.width + outsets.left + outsets.right,
-       rect.size.height + outsets.top + outsets.bottom}};
+      .origin =
+          {.x = rect.origin.x - outsets.left, .y = rect.origin.y - outsets.top},
+      .size = {
+          .width = rect.size.width + outsets.left + outsets.right,
+          .height = rect.size.height + outsets.top + outsets.bottom}};
 }
 
 } // namespace facebook::react