Transform $ReadOnlyArray to ReadonlyArray 17/n (#55109)

Summary:
Pull Request resolved: #55109

We are transforming the following utility types to be more consistent with typescript and better AI integration:

* `$NonMaybeType` -> `NonNullable`
* `$ReadOnly` -> `Readonly`
* `$ReadOnlyArray` -> `ReadonlyArray`
* `$ReadOnlyMap` -> `ReadonlyMap`
* `$ReadOnlySet` -> `ReadonlySet`
* `$Keys` -> `keyof`
* `$Values` -> `Values`
* `mixed` -> `unknown`

See details in https://fb.workplace.com/groups/flowlang/permalink/1837907750148213/.

drop-conflicts

Command:

`js1 flow-runner codemod flow/transformUtilityType --legacy-type='$ReadOnlyArray'`

Reviewed By: SamChou19815

Differential Revision: D90402950

Author: marcoww6

flow-typed/environment/node.js

@@ -1887,7 +1887,7 @@ declare module 'fs' {
      */
     exclude?:
       | ((fileName: Node$Conditional<WithFileTypes, Dirent, string>) => boolean)
-      | $ReadOnlyArray<string>,
+      | ReadonlyArray<string>,
     ...
   }>;
 
@@ -1905,12 +1905,12 @@ declare module 'fs' {
    * @since v22.0.0
    */
   declare function glob(
-    pattern: string | $ReadOnlyArray<string>,
+    pattern: string | ReadonlyArray<string>,
     callback: (err: ?ErrnoError, matches: Array<string>) => void,
   ): void;
 
   declare function glob<WithFileTypes: boolean = false>(
-    pattern: string | $ReadOnlyArray<string>,
+    pattern: string | ReadonlyArray<string>,
     options: GlobOptions<WithFileTypes>,
     callback: (
       err: ?ErrnoError,
@@ -1928,7 +1928,7 @@ declare module 'fs' {
    * @returns paths of files that match the pattern.
    */
   declare function globSync<WithFileTypes: boolean = false>(
-    pattern: string | $ReadOnlyArray<string>,
+    pattern: string | ReadonlyArray<string>,
     options?: GlobOptions<WithFileTypes>,
   ): Node$Conditional<WithFileTypes, Array<Dirent>, Array<string>>;
 
@@ -2142,7 +2142,7 @@ declare module 'fs' {
       mtime: number | string | Date,
     ): Promise<void>,
     glob<WithFileTypes: boolean = false>(
-      pattern: string | $ReadOnlyArray<string>,
+      pattern: string | ReadonlyArray<string>,
       options?: GlobOptions<WithFileTypes>,
     ): Node$Conditional<
       WithFileTypes,
@@ -2292,7 +2292,7 @@ declare class http$Agent<+SocketT = net$Socket> {
   constructor(options: http$agentOptions): void;
   destroy(): void;
   // $FlowFixMe[incompatible-variance]
-  freeSockets: {[name: string]: $ReadOnlyArray<SocketT>, ...};
+  freeSockets: {[name: string]: ReadonlyArray<SocketT>, ...};
   getName(options: {
     host: string,
     port: number,
@@ -2302,9 +2302,9 @@ declare class http$Agent<+SocketT = net$Socket> {
   maxFreeSockets: number;
   maxSockets: number;
   // $FlowFixMe[incompatible-variance]
-  requests: {[name: string]: $ReadOnlyArray<http$ClientRequest<SocketT>>, ...};
+  requests: {[name: string]: ReadonlyArray<http$ClientRequest<SocketT>>, ...};
   // $FlowFixMe[incompatible-variance]
-  sockets: {[name: string]: $ReadOnlyArray<SocketT>, ...};
+  sockets: {[name: string]: ReadonlyArray<SocketT>, ...};
 }
 
 declare class http$IncomingMessage<SocketT = net$Socket>
@@ -2968,11 +2968,11 @@ declare module 'perf_hooks' {
   ) => void;
 
   declare export class PerformanceObserver {
-    static supportedEntryTypes: $ReadOnlyArray<EntryType>;
+    static supportedEntryTypes: ReadonlyArray<EntryType>;
     constructor(callback: PerformanceObserverCallback): this;
     observe(
       options: Readonly<{
-        entryTypes?: $ReadOnlyArray<EntryType>,
+        entryTypes?: ReadonlyArray<EntryType>,
         type?: EntryType,
         buffered?: boolean,
       }>,
@@ -3461,7 +3461,7 @@ declare module 'stream' {
       options?: StreamPipelineOptions,
     ): Promise<void>,
     pipeline(
-      streams: $ReadOnlyArray<stream$Stream>,
+      streams: ReadonlyArray<stream$Stream>,
       options?: StreamPipelineOptions,
     ): Promise<void>,
     ...
@@ -3900,7 +3900,7 @@ declare module 'url' {
   };
 
   declare type url$URLPatternResult = {
-    inputs: $ReadOnlyArray<string | url$URLPatternInit>,
+    inputs: ReadonlyArray<string | url$URLPatternInit>,
     protocol: url$URLPatternComponentResult,
     username: url$URLPatternComponentResult,
     password: url$URLPatternComponentResult,
@@ -4104,8 +4104,8 @@ declare module 'util' {
 
   declare type util$DiffEntry = [operation: -1 | 0 | 1, value: string];
   declare function diff(
-    actual: string | $ReadOnlyArray<string>,
-    expected: string | $ReadOnlyArray<string>,
+    actual: string | ReadonlyArray<string>,
+    expected: string | ReadonlyArray<string>,
   ): Array<util$DiffEntry>;
 
   declare function getSystemErrorMessage(err: number): string;
@@ -4224,7 +4224,7 @@ declare module 'util' {
       | ForegroundColors
       | BackgroundColors
       | Modifiers
-      | $ReadOnlyArray<ForegroundColors | BackgroundColors | Modifiers>,
+      | ReadonlyArray<ForegroundColors | BackgroundColors | Modifiers>,
     text: string,
     options?: Readonly<{
       stream?: ?stream$Stream,

flow-typed/npm/@expo/spawn-async_v1.x.x.js

@@ -38,7 +38,7 @@ declare module '@expo/spawn-async' {
 
   declare function spawnAsync(
     command: string,
-    args?: $ReadOnlyArray<string>,
+    args?: ReadonlyArray<string>,
     options?: SpawnOptions,
   ): SpawnPromise<SpawnResult>;
 

flow-typed/npm/@react-native-community/cli-server-api_v19.x.x.js

@@ -13,7 +13,7 @@ declare module '@react-native-community/cli-server-api' {
 
   declare type MiddlewareOptions = {
     host?: string,
-    watchFolders: $ReadOnlyArray<string>,
+    watchFolders: ReadonlyArray<string>,
     port: number,
   };
 

flow-typed/npm/babel-traverse_v7.x.x.js

@@ -390,17 +390,15 @@ declare module '@babel/traverse' {
      * Earliest is defined as being "before" all the other nodes in terms of list container
      * position and visiting key.
      */
-    getEarliestCommonAncestorFrom(
-      paths: $ReadOnlyArray<NodePath<>>,
-    ): NodePath<>;
+    getEarliestCommonAncestorFrom(paths: ReadonlyArray<NodePath<>>): NodePath<>;
 
     /**
      * Get the earliest path in the tree where the provided `paths` intersect.
      *
      * TODO: Possible optimisation target.
      */
     getDeepestCommonAncestorFrom(
-      paths: $ReadOnlyArray<NodePath<>>,
+      paths: ReadonlyArray<NodePath<>>,
       filter?: (
         lastCommon: BabelNode,
         lastCommonIndex: number,

flow-typed/npm/babel_v7.x.x.js

@@ -1027,7 +1027,7 @@ declare module '@babel/core' {
   declare export var template: Template;
   declare export var traverse: Traverse;
   declare export var types: Types;
-  declare export var DEFAULT_EXTENSIONS: $ReadOnlyArray<string>;
+  declare export var DEFAULT_EXTENSIONS: ReadonlyArray<string>;
 
   declare export function buildExternalHelpers(
     whitelist?: Array<string>,

flow-typed/npm/execa_v5.x.x.js

@@ -37,7 +37,7 @@ declare module 'execa' {
     shell?: boolean | string,
     stderr?: ?StdIoOption,
     stdin?: ?StdIoOption,
-    stdio?: 'pipe' | 'ignore' | 'inherit' | $ReadOnlyArray<?StdIoOption>,
+    stdio?: 'pipe' | 'ignore' | 'inherit' | ReadonlyArray<?StdIoOption>,
     stdout?: ?StdIoOption,
     stripEof?: boolean,
     timeout?: number,
@@ -90,7 +90,7 @@ declare module 'execa' {
   declare interface Execa {
     (
       file: string,
-      args?: $ReadOnlyArray<string>,
+      args?: ReadonlyArray<string>,
       options?: Readonly<Options>,
     ): ExecaPromise;
     (file: string, options?: Readonly<Options>): ExecaPromise;
@@ -100,13 +100,13 @@ declare module 'execa' {
 
     node(
       path: string,
-      args?: $ReadOnlyArray<string>,
+      args?: ReadonlyArray<string>,
       options?: Readonly<Options>,
     ): void;
 
     sync(
       file: string,
-      args?: $ReadOnlyArray<string>,
+      args?: ReadonlyArray<string>,
       options?: Readonly<SyncOptions>,
     ): SyncResult;
     sync(file: string, options?: Readonly<SyncOptions>): SyncResult;

flow-typed/npm/jest.js

@@ -13,7 +13,7 @@
 
 // MODIFIED: Added ESLint suppression comment - no-unused-vars doesn't understand declaration files
 
-type JestMockFn<TArguments: $ReadOnlyArray<unknown>, TReturn> = {
+type JestMockFn<TArguments: ReadonlyArray<unknown>, TReturn> = {
   (...args: TArguments): TReturn,
   /**
    * An object for introspecting mock calls
@@ -768,7 +768,7 @@ interface JestExpectType {
   /**
    *
    */
-  toHaveProperty(propPath: string | $ReadOnlyArray<string>, value?: any): void;
+  toHaveProperty(propPath: string | ReadonlyArray<string>, value?: any): void;
   /**
    * Use .toMatch to check that a string matches a regular expression or string.
    */
@@ -881,7 +881,7 @@ type JestObjectType = {
    * implementation.
    */
   // MODIFIED: Added defaults to type arguments.
-  fn<TArguments: $ReadOnlyArray<unknown> = $ReadOnlyArray<any>, TReturn = any>(
+  fn<TArguments: ReadonlyArray<unknown> = ReadonlyArray<any>, TReturn = any>(
     implementation?: (...args: TArguments) => TReturn,
   ): JestMockFn<TArguments, TReturn>,
   /**
@@ -1045,11 +1045,11 @@ declare var describe: {
    */
   each(
     ...table:
-      | $ReadOnlyArray<$ReadOnlyArray<unknown> | unknown>
-      | [$ReadOnlyArray<string>, string]
+      | ReadonlyArray<ReadonlyArray<unknown> | unknown>
+      | [ReadonlyArray<string>, string]
   ): (
     name: JestTestName,
-    fn?: (...args: $ReadOnlyArray<any>) => ?Promise<unknown>,
+    fn?: (...args: ReadonlyArray<any>) => ?Promise<unknown>,
     timeout?: number,
   ) => void,
   ...
@@ -1136,8 +1136,8 @@ declare var it: {
    */
   each(
     ...table:
-      | $ReadOnlyArray<$ReadOnlyArray<unknown> | unknown>
-      | [$ReadOnlyArray<string>, string]
+      | ReadonlyArray<ReadonlyArray<unknown> | unknown>
+      | [ReadonlyArray<string>, string]
   ): (
     name: JestTestName,
     fn?: (...args: Array<any>) => ?Promise<unknown>,
@@ -1252,13 +1252,13 @@ declare var expect: {
   any(value: unknown): JestAsymmetricEqualityType,
   anything(): any,
   // MODIFIED: Array -> $ReadOnlyArray
-  arrayContaining(value: $ReadOnlyArray<unknown>): Array<unknown>,
+  arrayContaining(value: ReadonlyArray<unknown>): Array<unknown>,
   objectContaining(value: Object): Object,
   /** Matches any received string that contains the exact expected string. */
   stringContaining(value: string): string,
   stringMatching(value: string | RegExp): string,
   not: {
-    arrayContaining: (value: $ReadOnlyArray<unknown>) => Array<unknown>,
+    arrayContaining: (value: ReadonlyArray<unknown>) => Array<unknown>,
     objectContaining: (value: {...}) => Object,
     stringContaining: (value: string) => string,
     stringMatching: (value: string | RegExp) => string,

flow-typed/npm/listr2_v8.x.x.js

@@ -55,7 +55,7 @@ declare module 'listr2' {
       options?: Options,
     ): void;
     add<ReturnT>(task: TaskSpec<ContextT, ReturnT>): this;
-    add<ReturnT>(tasks: $ReadOnlyArray<TaskSpec<ContextT, ReturnT>>): this;
+    add<ReturnT>(tasks: ReadonlyArray<TaskSpec<ContextT, ReturnT>>): this;
     run(ctx?: ContextT): Promise<ContextT>;
   }
 }

flow-typed/npm/listr_v14.x.x.js

@@ -55,7 +55,7 @@ declare module 'listr' {
       options?: Options,
     ): void;
     add<ReturnT>(task: TaskSpec<ContextT, ReturnT>): this;
-    add<ReturnT>(tasks: $ReadOnlyArray<TaskSpec<ContextT, ReturnT>>): this;
+    add<ReturnT>(tasks: ReadonlyArray<TaskSpec<ContextT, ReturnT>>): this;
     run(ctx?: ContextT): Promise<ContextT>;
   }
 }

packages/community-cli-plugin/src/commands/bundle/assetCatalogIOS.js

@@ -31,7 +31,7 @@ type ImageSet = {
 export function getImageSet(
   catalogDir: string,
   asset: AssetData,
-  scales: $ReadOnlyArray<number>,
+  scales: ReadonlyArray<number>,
 ): ImageSet {
   const fileName = assetPathUtils.getResourceIdentifier(asset);
   return {