Remove legacy integration of createPerformanceLogger with Systrace #46236
+0
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [internal] Differential Revision: D61885705
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61885705 |
Contributor
|
This pull request has been merged in cf356bd. |
Collaborator
|
This pull request was successfully merged by @rubennorte in cf356bd When will my fix make it into a release? | How to file a pick request? |
|
hi @rubennorte what was the rationale for this change? thanks! |
Contributor
Author
This is an internal API in React Native and it was logging too much data to Systrace in the current use cases that we had. We'll probably remove this API altogether as it's not used within React Native itself and it's not public. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [internal]
Differential Revision: D61885705