Implemented a gradientMode text attribute.
#55088
Closed
+7,612
−1,717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#publish-packages-to-npm&next
This reverts commit 9879028.
#publish-packages-to-npm&next
This reverts commit b52ecff.
This reverts commit 1a6887b.
#publish-packages-to-npm&next
Summary: Pull Request resolved: facebook#52399 I'm raising the deprecation warnings for those methods that are using legacy arch. Previously the `DeprecatedInNewArchitecture` was not generating warnings for user in their builds, while now the Kotlin's/Java's `DeprecatedInNewArchitecture` it will. Changelog: [Android] [Changed] - Introduce more deprecation warnings for Legacy Arch classes Reviewed By: mdvacca Differential Revision: D77736713 fbshipit-source-id: bc21729ed8253d3ec6b6a40577bcd76622c3f8a6
… from their personal maven mirror (facebook#52514) Summary: Pull Request resolved: facebook#52514 As per title, this change add the `ENTERPRISE_REPOSITORY` env variable so that users can use their owm maven mirror to consume artifacts rather than the official url. This is helpful as: - we can reduce the traffic toward maven central - companies can speed up their builds by relying on local/closer replicas ## Changelog: [iOS][Added] - Add the `ENTERPRISE_REPOSITORY` env variable to cocopaods infra Reviewed By: cortinico Differential Revision: D78011424 fbshipit-source-id: 24b83b4866095d7fe3318362afc5075b99b146e7
Summary: Pull Request resolved: facebook#52553 This change fixes the usage of `ENTERPRISE_REPOSITORY` in Ruby ## Changelog [Internal] - Reviewed By: cortinico Differential Revision: D78152641 fbshipit-source-id: e4ace014f1b7cbeb1ec5a0dea955d1fc2bae5b67
Summary: Pull Request resolved: facebook#52512 The way Maven works is that the artifacts are uploaded and available way before the browsing UI will allow us to browse them. By trying to download the `.pom` file instead of checking for the browsing website to be visible, we can shave some minutes during the release ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D78008635 fbshipit-source-id: 96516163628d6d25db385d996a11b4af78db764a
Summary: Pull Request resolved: facebook#52513 We bumped the requirement for cocoapods to use Xcode 16.1 or greater. This job was not update and therefore it failed when releasing 0.81.0-rc.0. This change should fix it and it should be cherry picked in the release branch too. By default, the macos executor in github actions are using Xcode 15.2 ## Changelog [Internal] - Reviewed By: cortinico, fabriziocucci Differential Revision: D78008316 fbshipit-source-id: 4d05233ca3b936cf128400030328124c453963ea
…acebook#52489) Summary: When using prebuilts the USE_FRAMEWORKS setting is not really relevant for the React Native code, since there will not be any source code to build frameworks for - and because we already have a framework for the code in React.XCFramework. This commit adds a new command to the React Native podspecs like we did with the ReactNativeDependencies framework. The method is called `add_rncore_dependency` and it does nothing when building from source - but when linking with the React.XCFramework it explicitly adds linking with the framework. In addition there are a few places in the ruby code where we check for the USE_FRAMEWORK value and changes some settings - where needed this commit will add a separate check to ensure we're building from source when making these changes. bypass-github-export-checks ## Changelog: [IOS] [ADDED] - Added support for using USE_FRAMEWORKS with prebuilt React Native Core Pull Request resolved: facebook#52489 Test Plan: RNTester: - Builds without USE_FRAMEWORKS as before with/without prebuilt - Builds with USE_FRAMEWORKS=dynamic as before with source - and now also with prebuilt code. - Same goes for the static variant. Reviewed By: mdvacca Differential Revision: D78012332 Pulled By: cipolleschi fbshipit-source-id: ea942738ae52b9dceae48fb78a5026f04b7545b8
Summary: Fixes #T228219721 This commit adds the debug/release switch script like we have for rn deps and hermes for react-core prebuilt: - Added script: replace-rncore-version-js - Inserted script into React-Core-prebuilt podspec - Updated rncore.rb with correct filenames bypass-github-export-checks ## Changelog: [IOS] [ADDED] - add release/debug switch script for React-Core-prebuilt Pull Request resolved: facebook#52498 Test Plan: Run in RNTester and switch between release/debug Reviewed By: rshest Differential Revision: D78012917 Pulled By: cipolleschi fbshipit-source-id: 71cad23cd41484a8253fc89d5dce8653649657a0
) Summary: Pull Request resolved: facebook#52528 This was a breaking change that is currently breaking `react-native-safe-area-context` so we can't ship it as it is, especially because all the apps in OSS will be affected by this. Changelog: [General] [Changed] - Revert breaking change due to the removal of `ShadowNodeTraits::Trait::DirtyYogaNode` Original commit changeset: 869e81f0ae00 Original Phabricator Diff: D75324251 Reviewed By: huntie Differential Revision: D78085848 fbshipit-source-id: f7fcc5e33d59cc966a4ee88dfdbedca4f4c580e0
Summary: This PR fixes the following build error while trying to build `[email protected]` app with `[email protected]` installed using react-native prebuilds (AAR) due to a missing `react/renderer/bridging/bridging.h` file in `prefab/modules/` inside `react-android-0.81.0-rc.0-debug.aar`. ``` In file included from /Users/tomekzaw/RNOS/react-native-reanimated/node_modules/react-native-screens/android/src/main/cpp/NativeProxy.cpp:2: In file included from /Users/tomekzaw/.gradle/caches/8.14.1/transforms/75e7f8f7b5ef763e687a16737daf01b6/transformed/react-android-0.81.0-rc.0-debug/prefab/modules/reactnative/include/react/fabric/Binding.h:12: In file included from /Users/tomekzaw/.gradle/caches/8.14.1/transforms/75e7f8f7b5ef763e687a16737daf01b6/transformed/react-android-0.81.0-rc.0-debug/prefab/modules/reactnative/include/react/fabric/FabricUIManagerBinding.h:22: /Users/tomekzaw/.gradle/caches/8.14.1/transforms/75e7f8f7b5ef763e687a16737daf01b6/transformed/react-android-0.81.0-rc.0-debug/prefab/modules/reactnative/include/react/renderer/uimanager/primitives.h:14:10: fatal error: 'react/renderer/bridging/bridging.h' file not found 14 | #include <react/renderer/bridging/bridging.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ninja: build stopped: subcommand failed. ``` ## Changelog: [ANDROID] [CHANGED] - Expose `react_renderer_bridging` headers via prefab Pull Request resolved: facebook#52529 Reviewed By: cipolleschi Differential Revision: D78092428 Pulled By: cortinico fbshipit-source-id: de8208ae7545201f600c277a0c8907575c310c58
Summary: This change tries to use the prebuilds we build in CI i other iOS jobs to speed-up the iOS CI bypass-github-export-checks ## Changelog: [Internal] - Pull Request resolved: facebook#52531 Test Plan: Build rntester using prebuilds: ``` # after downloading the prebuilds from CI and unzipping them export HERMES_ENGINE_TARBALL_PATH=~/Downloads/hermes-ios-Debug.tar.gz export RCT_USE_LOCAL_RN_DEP=~/Downloads/reactnative-dependencies-debug.tar.gz export RCT_TESTONLY_RNCORE_TARBALL_PATH=~/Downloads/React.xcframework.tar.gz USE_FRAMEWORKS=dynamic bundle exec pod install open RNTesterPods.xcworkspace ``` And then build from Xcode. Reviewed By: rshest Differential Revision: D78158734 Pulled By: cipolleschi fbshipit-source-id: 43cbb66bd44fa621292b69de0dadde5ed20c4574
Summary: This PR (initially created for edge-to-edge opt-in support, rebased multiple times) fixes the `Dimensions` API `window` values on Android < 15, when edge-to-edge is enabled. Currently the window height doesn't include the status and navigation bar heights (but it does on Android >= 15): <img width="300" alt="Screenshot 2025-06-27 at 16 23 02" src="https://github.com/user-attachments/assets/c7d11334-9298-4f7f-a75c-590df8cc2d8a" /> Using `WindowMetricsCalculator` from AndroidX: <img width="300" alt="Screenshot 2025-06-27 at 16 34 01" src="https://github.com/user-attachments/assets/7a4e3dc7-a83b-421b-8f6d-fd1344f5fe81" /> Fixes facebook#47080 ## Changelog: [Android] [Fixed] Fix `Dimensions` `window` values on Android < 15 when edge-to-edge is enabled Pull Request resolved: facebook#47554 Test Plan: Run the example app on an Android < 15 device. Rollback Plan: Reviewed By: cortinico Differential Revision: D77547628 Pulled By: alanleedev fbshipit-source-id: 9d841f642d5b7ef3294dfbf3868137087a672ad6
Summary: Instead of returning when creating the list of header files from our podspecs, we now call `continue`. This is a bug that causes all subsequent globs in the header file list to be omitted after the first omitted glob. bypass-github-export-checks ## Changelog: [IOS] [FIXED] - Fixed premature return in header file generation from podspec globs Pull Request resolved: facebook#52490 Test Plan: Run prebuild scripts and verify that React-Fabric podspec headers are included in the resulting xcframework. Reviewed By: mdvacca Differential Revision: D78012399 Pulled By: cipolleschi fbshipit-source-id: 2d334f4f7ff966ea4c778786a7056e13a255a708
Summary: Pull Request resolved: facebook#52466 Just another patch bump of Gradle 8.14 Changelog: [Android] [Changed] - Gradle to 8.14.3 Reviewed By: NickGerleman Differential Revision: D77865220 fbshipit-source-id: 450d175242f046909ab1984654d24e92a2536d5d
…acebook#52530) Summary: Pull Request resolved: facebook#52530 This PR fixes two issues with `display: contents` implementation: 1. When a node with `display: contents` set is a leaf, it won't be cloned after the initial tree is built. The added test case covers this scenario. 2. It was possible for the subtree of `display: contents` nodes not to be cloned during layout. I don't have a minimal reproduction for this one, unfortunately. It was discovered in the Expensify app: Expensify/App#65268, along with a consistent reproduction. In that specific case, it seems to be heavily tied to `react-native-onyx`, which is a state management library. Changelog: [GENERAL][FIXED] - Fixed nodes with `display: contents` set being cloned with the wrong owner X-link: facebook/yoga#1826 Reviewed By: adityasharat, NickGerleman Differential Revision: D78084270 Pulled By: j-piasecki fbshipit-source-id: eb81f6d7dcd1665974d07261ba693e2abea239bb
This reverts commit 9c4da7b.
#publish-packages-to-npm&next
…iew) (facebook#52507) Summary: Pull Request resolved: facebook#52507 Resolves reactwg/react-native-releases#1011. Changelog: [General][Changed] - `NewAppScreen` no longer internally handles device safe area, use optional `safeAreaInsets` prop (aligned in 0.81 template) Reviewed By: cortinico Differential Revision: D78006238 fbshipit-source-id: 01fb16d6754b69a722ea11838d558bebd4748026
Summary: Pull Request resolved: facebook#52625 Changes `react-native/babel-preset` so that by default, `hermes-parser` is configured with `reactRuntimeTarget: "19"`. This changes the compiled output of Component Syntax to not use `forwardRef` when a `ref` prop is present. Additionally, this adds a new preset option property, `hermesParserOptions`. This object allows users of `react-native/babel-preset` to supply overrides for any `hermes-parser` options. Changelog: [General][Changed] - Configures `react-native/babel-preset` to target React 19 by default, meaning Component Syntax will not compile to `forwardRef` calls when a `ref` prop is present. [General][Added] - Added support to `react-native/babel-preset` for a `hermesParserOptions` option, that expects an object that enables overriding `hermes-parser` options. Reviewed By: SamChou19815 Differential Revision: D78383269 fbshipit-source-id: 1e6b66b9bfbeaf8a06fdc39031cb6de7e921765f
Summary: When switching between release/debug we're running a script to copy the correct xcframework. This script for the React-Core prebuilts was not part of the package.json file. This caused the build to fail after trying to switch from debug -> release. ## Changelog: [IOS] [FIXED] - Fixed missing script for resolving prebuilt xcframework when switching between release/debug Pull Request resolved: facebook#52663 Test Plan: - Create new RN App - Install pod with prebuilt deps and core - Build (success) - Switch to release - Build (success) Reviewed By: cortinico Differential Revision: D78481302 Pulled By: cipolleschi fbshipit-source-id: 1c7181e63219098ae140d77ff1cb2c0c9b9642e5
* first impl * add UIManager methods * add custom view manager to test code * paper implement method * refactor code: make ViewTransitioNCoordinator handle the main stuff * fix tests with discord changes * test for viewtransitioncoordinator * add test to verify ViewTransitionCoordinator * fix various edge cases * test case * remove debug logs * wip: add deleteView to queue as well * refactor: make childTag first arg * removed checked todo item * fix queue getting stuck * fix correctness of queues clearing up properly * avoid confusing double loop * cleanup previous mechanisms * refactor: exec. first removes immediately There were two mistake in the previous implementation. Let's say we have: - markTransition A - remove A - delete A then we need to execute the remove A immediately, instead of queuing it. A will be removed from its parent, but as its in transition, will keep its pointer to the parent. This will cause the onDetach listener to fire naturally. The second mistake was to drain the queue when markViewInTransition=false was being called. This will be called e.g. during drawing passes (ie. on animation end), and we don't want to change the view hierarchy during draw passes! With the previous fix the onDetach should always be called, so running it in markViewInTransition is not necessary any longer * add explicit handling for when view has parent but markViewInTransition was not called
* first impl * add UIManager methods * add custom view manager to test code * paper implement method * refactor code: make ViewTransitioNCoordinator handle the main stuff * fix tests with discord changes * test for viewtransitioncoordinator * add test to verify ViewTransitionCoordinator * fix various edge cases * test case * remove debug logs * wip: add deleteView to queue as well * refactor: make childTag first arg * removed checked todo item * fix queue getting stuck * fix correctness of queues clearing up properly * avoid confusing double loop * cleanup previous mechanisms * refactor: exec. first removes immediately There were two mistake in the previous implementation. Let's say we have: - markTransition A - remove A - delete A then we need to execute the remove A immediately, instead of queuing it. A will be removed from its parent, but as its in transition, will keep its pointer to the parent. This will cause the onDetach listener to fire naturally. The second mistake was to drain the queue when markViewInTransition=false was being called. This will be called e.g. during drawing passes (ie. on animation end), and we don't want to change the view hierarchy during draw passes! With the previous fix the onDetach should always be called, so running it in markViewInTransition is not necessary any longer * add explicit handling for when view has parent but markViewInTransition was not called * remove logs * remove logs
Add logs fix build Add more logs Add more logs Setup the stroke view on the text view Add some more logs Disable foreground color span when stroke is present Add more logs Update the stroke implementation Reset color filter for the fill pass Reeanable the foreground color span Improve the stroke style implementation Fix the text shadow style span Update the stroke style implementation Add leading margin for stroke/shadow that extends beyond text bounds Fix the build issue Fix the build
…pecific ones (#138) * fix(android): fix all delete operations were queued instead of only specific ones * fix(android): fix queued delete operations while transition
Fixing a bug with ellipsis truncation of display names with styles. - This changes the way we handle the stroke effects on a text view because using a ReplacementSpan for stroke effects breaks the truncation logic otherwise. This implementation turns the StrokeStyleSpan into a CharacterStyle to hold the data about the strokeWidth and strokeColor and let the ReactTextView handle drawing the stroke which matches the implementation on ios as well and fixes the truncation issue - Removes the DiscordShadowStyle we created as that was using a replacementSpan and was having the same truncation issue. Instead to solve the clipping at the left end of the text we're adding a LeadingMarginSpan to account for shadows as well as stroke effects Tried to keep most of the changes contained in the style span classes we have to make it easier for future use. (merging on behalf of @insacc)
…` (current behavior) or `clamp` (matches 100% width behavior on web).
|
Hi @andrewkunkel! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
Test Plan: