-
Notifications
You must be signed in to change notification settings - Fork 25k
Implementing url Methods #49955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing url Methods #49955
Conversation
|
@cipolleschi @cortinico Apologies for tagging . Can you check this Please. I know there are open PRs regarding this like #48333 . But all of them are waiting on feedbacks since months and are not in mergeable state as of now. |
Can you rebase so that the CI can run on your PR? |
a46070e to
97791ca
Compare
|
Done @cortinico . CIs are finally green |
|
@cortinico can you review this please |
cortinico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test case inside RNTester?
|
@cortinico I have added a new URL example in rn tester. Can you check? |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Oops lint failure :( . Are the lint rules different in meta tests? @cortinico can you pls help |
Yeah don't worry too much about the internal failures. Those are up to us to solve. On the other hand: @rshest asked why is this change needed now. Like what's the use case? |
|
Alright @cortinico . This also helps toward react native's goal of moving towards more web standards If the same code is used on latest RN(0.78.0) it will throw an error saying that this method was never implemented It should also discourage React Native developers from using external libraries like urijs (which is deprecated in favor of the built-in URL API). cc:- @rshest |
|
@cortinico merged this pull request in 3dac900. |
|
This pull request was successfully merged by @riteshshukla04 in 3dac900 When will my fix make it into a release? | How to file a pick request? |


Summary:
Implemented Methods in URL which were not implemented yet
The methods output are identical to outputs of window.url .
Changelog:
[General][Added] URL accessors for unimplemented Methods
Test Plan:
Code:-

Tested with Hermes

Tested with JSC
