Skip to content

Conversation

@SimpleCreations
Copy link
Contributor

@SimpleCreations SimpleCreations commented Aug 24, 2025

Summary:

#49955 and #50043 added implementations for some URL and URLSearchParams methods, but didn't update TypeScript type definitions for React Native globals. This PR adds the missing property and method type declarations.

Changelog:

[General][Fixed] Missing URL and URLSearchParams methods in TypeScript types

Test Plan:

N/A

@meta-cla
Copy link

meta-cla bot commented Aug 24, 2025

Hi @SimpleCreations!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla
Copy link

meta-cla bot commented Aug 24, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 24, 2025
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 24, 2025
@SimpleCreations SimpleCreations force-pushed the update-typescript-types-for-url-properties branch from c29995e to b6da550 Compare August 25, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants