diff --git a/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp b/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp index a98b9e85b1d047..8922b5a18fed52 100644 --- a/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp +++ b/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp @@ -45,7 +45,10 @@ class JSIExecutor::NativeModuleProxy : public jsi::HostObject { return nativeModules->getModule(rt, name); } - void set(Runtime&, const PropNameID&, const Value&) override { + void set( + Runtime& /*unused*/, + const PropNameID& /*name*/, + const Value& /*value*/) override { throw std::runtime_error( "Unable to put on NativeModules: Operation unsupported"); } diff --git a/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h b/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h index 0cc640f09451bb..84b236be215464 100644 --- a/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h +++ b/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h @@ -83,7 +83,7 @@ class [[deprecated( std::unique_ptr script, std::string sourceURL) override; #ifndef RCT_REMOVE_LEGACY_ARCH - void setBundleRegistry(std::unique_ptr) override; + void setBundleRegistry(std::unique_ptr r) override; #endif // RCT_REMOVE_LEGACY_ARCH void registerBundle(uint32_t bundleId, const std::string& bundlePath) override; diff --git a/packages/react-native/ReactCommon/jsinspector-modern/UniqueMonostate.h b/packages/react-native/ReactCommon/jsinspector-modern/UniqueMonostate.h index 6c13e17dd03203..7766e94399c9a6 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/UniqueMonostate.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/UniqueMonostate.h @@ -18,22 +18,28 @@ namespace facebook::react::jsinspector_modern { */ template struct UniqueMonostate { - constexpr bool operator==(const UniqueMonostate&) const noexcept { + constexpr bool operator==( + const UniqueMonostate& /*unused*/) const noexcept { return true; } - constexpr bool operator!=(const UniqueMonostate&) const noexcept { + constexpr bool operator!=( + const UniqueMonostate& /*unused*/) const noexcept { return false; } - constexpr bool operator<(const UniqueMonostate&) const noexcept { + constexpr bool operator<( + const UniqueMonostate& /*unused*/) const noexcept { return false; } - constexpr bool operator>(const UniqueMonostate&) const noexcept { + constexpr bool operator>( + const UniqueMonostate& /*unused*/) const noexcept { return false; } - constexpr bool operator<=(const UniqueMonostate&) const noexcept { + constexpr bool operator<=( + const UniqueMonostate& /*unused*/) const noexcept { return true; } - constexpr bool operator>=(const UniqueMonostate&) const noexcept { + constexpr bool operator>=( + const UniqueMonostate& /*unused*/) const noexcept { return true; } }; @@ -45,8 +51,8 @@ namespace std { template struct hash<::facebook::react::jsinspector_modern::UniqueMonostate> { size_t operator()( - const ::facebook::react::jsinspector_modern::UniqueMonostate&) - const noexcept { + const ::facebook::react::jsinspector_modern::UniqueMonostate< + key>& /*unused*/) const noexcept { return key; } }; diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorMocks.h b/packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorMocks.h index 4e16fc1e96b4ce..8a7bd893fcf39c 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorMocks.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorMocks.h @@ -175,7 +175,7 @@ class MockRuntimeAgentDelegate : public RuntimeAgentDelegate { inline MockRuntimeAgentDelegate( FrontendChannel frontendChannel, SessionState& sessionState, - std::unique_ptr, + std::unique_ptr /*unused*/, ExecutionContextDescription executionContextDescription, const RuntimeExecutor& /*runtimeExecutor*/) : frontendChannel(std::move(frontendChannel)), diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tests/JsiIntegrationTest.h b/packages/react-native/ReactCommon/jsinspector-modern/tests/JsiIntegrationTest.h index 9c53181f50eaa8..2a3db0b78b3934 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tests/JsiIntegrationTest.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/tests/JsiIntegrationTest.h @@ -186,7 +186,7 @@ class JsiIntegrationPortableTestBase : public ::testing::Test, } void onSetPausedInDebuggerMessage( - const OverlaySetPausedInDebuggerMessageRequest&) override {} + const OverlaySetPausedInDebuggerMessageRequest& /*request*/) override {} }; } // namespace facebook::react::jsinspector_modern diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tests/ReactNativeMocks.h b/packages/react-native/ReactCommon/jsinspector-modern/tests/ReactNativeMocks.h index 5eea24259aab01..362a4d991e2683 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tests/ReactNativeMocks.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/tests/ReactNativeMocks.h @@ -29,7 +29,7 @@ class MockMessageQueueThread : public react::MessageQueueThread { void runOnQueue(std::function&& func) override; // Unused - void runOnQueueSync(std::function&&) override; + void runOnQueueSync(std::function&& callback) override; // Unused void quitSynchronous() override; diff --git a/packages/react-native/ReactCommon/react/bridging/Array.h b/packages/react-native/ReactCommon/react/bridging/Array.h index 58455aa278cbdd..9686ef38c84bf4 100644 --- a/packages/react-native/ReactCommon/react/bridging/Array.h +++ b/packages/react-native/ReactCommon/react/bridging/Array.h @@ -37,7 +37,7 @@ struct BridgingStatic { facebook::jsi::Runtime& rt, const T& array, const std::shared_ptr& jsInvoker, - std::index_sequence) { + std::index_sequence /*unused*/) { return jsi::Array::createWithElements( rt, bridging::toJs(rt, std::get(array), jsInvoker)...); } diff --git a/packages/react-native/ReactCommon/react/bridging/Base.h b/packages/react-native/ReactCommon/react/bridging/Base.h index d9525fd142b364..8265c47338af8f 100644 --- a/packages/react-native/ReactCommon/react/bridging/Base.h +++ b/packages/react-native/ReactCommon/react/bridging/Base.h @@ -24,7 +24,7 @@ struct Bridging; template <> struct Bridging { // Highly generic code may result in "casting" to void. - static void fromJs(jsi::Runtime&, const jsi::Value&) {} + static void fromJs(jsi::Runtime& /*unused*/, const jsi::Value& /*unused*/) {} }; namespace bridging { @@ -105,7 +105,8 @@ template auto toJs( jsi::Runtime& rt, T&& value, - const std::shared_ptr& = nullptr) -> remove_cvref_t { + const std::shared_ptr& /*unused*/ = nullptr) + -> remove_cvref_t { return convert(rt, std::forward(value)); } @@ -113,7 +114,7 @@ template auto toJs( jsi::Runtime& rt, T&& value, - const std::shared_ptr& = nullptr) + const std::shared_ptr& /*unused*/ = nullptr) -> decltype(Bridging>::toJs(rt, std::forward(value))) { return Bridging>::toJs(rt, std::forward(value)); } diff --git a/packages/react-native/ReactCommon/react/bridging/Bool.h b/packages/react-native/ReactCommon/react/bridging/Bool.h index fe2a756bcd44e7..1a3912ac1fbf2f 100644 --- a/packages/react-native/ReactCommon/react/bridging/Bool.h +++ b/packages/react-native/ReactCommon/react/bridging/Bool.h @@ -13,7 +13,7 @@ namespace facebook::react { template <> struct Bridging { - static bool fromJs(jsi::Runtime&, const jsi::Value& value) { + static bool fromJs(jsi::Runtime& /*unused*/, const jsi::Value& value) { return value.asBool(); } diff --git a/packages/react-native/ReactCommon/react/bridging/Class.h b/packages/react-native/ReactCommon/react/bridging/Class.h index 90a10a00956211..083bd6f098774e 100644 --- a/packages/react-native/ReactCommon/react/bridging/Class.h +++ b/packages/react-native/ReactCommon/react/bridging/Class.h @@ -86,12 +86,12 @@ JSReturnT callFromJs( } template -constexpr size_t getParameterCount(ReturnT (*)(ArgsT...)) { +constexpr size_t getParameterCount(ReturnT (* /*unused*/)(ArgsT...)) { return sizeof...(ArgsT); } template -constexpr size_t getParameterCount(ReturnT (Class::*)(ArgsT...)) { +constexpr size_t getParameterCount(ReturnT (Class::* /*unused*/)(ArgsT...)) { return sizeof...(ArgsT); } diff --git a/packages/react-native/ReactCommon/react/bridging/Function.h b/packages/react-native/ReactCommon/react/bridging/Function.h index bd1725f1401a70..01ac6af94208e9 100644 --- a/packages/react-native/ReactCommon/react/bridging/Function.h +++ b/packages/react-native/ReactCommon/react/bridging/Function.h @@ -179,7 +179,8 @@ class SyncCallback { } template - R apply(std::tuple&& args, std::index_sequence) const { + R apply(std::tuple&& args, std::index_sequence /*unused*/) + const { return call(std::move(std::get(args))...); } @@ -262,7 +263,7 @@ struct Bridging> { jsi::Runtime& rt, const jsi::Value* args, const std::shared_ptr& jsInvoker, - std::index_sequence) { + std::index_sequence /*unused*/) { return fn(bridging::fromJs(rt, args[Index], jsInvoker)...); } }; diff --git a/packages/react-native/ReactCommon/react/bridging/Value.h b/packages/react-native/ReactCommon/react/bridging/Value.h index c2f37f4cbfc5aa..dfd832c8a2f5fa 100644 --- a/packages/react-native/ReactCommon/react/bridging/Value.h +++ b/packages/react-native/ReactCommon/react/bridging/Value.h @@ -24,7 +24,7 @@ struct Bridging { } } - static std::nullptr_t toJs(jsi::Runtime&, std::nullptr_t) { + static std::nullptr_t toJs(jsi::Runtime& /*unused*/, std::nullptr_t) { return nullptr; } }; diff --git a/packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.h b/packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.h index 713a3ac9545d97..0674f617aeb7b3 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.h +++ b/packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.h @@ -53,7 +53,8 @@ class JSI_EXPORT JavaTurboModule : public TurboModule { protected: void configureEventEmitterCallback(); - [[deprecated]] void setEventEmitterCallback(jni::alias_ref) { + [[deprecated]] void setEventEmitterCallback( + jni::alias_ref /*unused*/) { configureEventEmitterCallback(); } diff --git a/packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h b/packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h index b2d3d0581f29e1..35ec7a712914dd 100644 --- a/packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h +++ b/packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h @@ -82,8 +82,8 @@ class ParagraphAttributes : public DebugStringConvertible { */ std::optional textAlignVertical{}; - bool operator==(const ParagraphAttributes&) const; - bool operator!=(const ParagraphAttributes&) const; + bool operator==(const ParagraphAttributes& rhs) const; + bool operator!=(const ParagraphAttributes& rhs) const; #pragma mark - DebugStringConvertible diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h b/packages/react-native/ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h index 8eb786fb02a573..306ab60baf0d7c 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h +++ b/packages/react-native/ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h @@ -233,7 +233,7 @@ inline void fromRawValue( } inline void fromRawValue( - const PropsParserContext&, + const PropsParserContext& /*unused*/, const RawValue& value, AccessibilityValue& result) { auto map = (std::unordered_map)value; diff --git a/packages/react-native/ReactCommon/react/renderer/css/CSSValueParser.h b/packages/react-native/ReactCommon/react/renderer/css/CSSValueParser.h index 7b8be4d8d32f31..213b433a8f6cd8 100644 --- a/packages/react-native/ReactCommon/react/renderer/css/CSSValueParser.h +++ b/packages/react-native/ReactCommon/react/renderer/css/CSSValueParser.h @@ -34,7 +34,7 @@ class CSSValueParser { template constexpr std::variant consumeValue( CSSDelimiter delimeter, - CSSCompoundDataType) { + CSSCompoundDataType /*unused*/) { using ReturnT = std::variant; auto consumedValue =