From c2f2337eba288fcf89f8423fdbd94d51a5738049 Mon Sep 17 00:00:00 2001 From: CodemodService Bot Date: Wed, 1 Oct 2025 12:29:39 -0700 Subject: [PATCH] Fix CQS signal readability-named-parameter in xplat/js/react-native-github/packages Reviewed By: javache Differential Revision: D83637519 --- .../Libraries/Network/RCTHTTPRequestHandler.h | 2 +- packages/react-native/React/Base/RCTAssert.h | 9 +- packages/react-native/React/Base/RCTAssert.m | 2 +- packages/react-native/React/Base/RCTBridge.mm | 4 +- packages/react-native/React/Base/RCTConvert.h | 11 +- packages/react-native/React/Base/RCTLog.h | 10 +- packages/react-native/React/Base/RCTUtils.mm | 2 +- .../React/CoreModules/RCTAppearance.h | 2 +- .../React/CxxBridge/RCTMessageThread.h | 4 +- .../React/CxxBridge/RCTObjcExecutor.mm | 2 +- .../react-native/React/Profiler/RCTProfile.h | 12 +- .../react-native/React/Profiler/RCTProfile.m | 2 +- .../JCxxInspectorPackagerConnection.h | 2 +- .../jni/react/devsupport/JInspectorFlags.h | 4 +- .../main/jni/react/fabric/ComponentFactory.h | 3 +- .../instrumentation/HermesSamplingProfiler.h | 6 +- .../main/jni/react/jni/CatalystInstanceImpl.h | 3 +- .../jni/ReactInstanceManagerInspectorTarget.h | 2 +- .../DefaultComponentsRegistry.h | 2 +- .../DefaultTurboModuleManagerDelegate.h | 5 +- .../jni/react/reactnativeblob/BlobCollector.h | 2 +- .../jni/react/runtime/jni/JReactInstance.h | 2 +- .../ReactCommon/cxxreact/CxxModule.h | 8 +- .../ReactCommon/jsc/JSCRuntime.cpp | 113 ++++++++++-------- 24 files changed, 122 insertions(+), 92 deletions(-) diff --git a/packages/react-native/Libraries/Network/RCTHTTPRequestHandler.h b/packages/react-native/Libraries/Network/RCTHTTPRequestHandler.h index 768982a9de592a..ee7fe8be44f76c 100644 --- a/packages/react-native/Libraries/Network/RCTHTTPRequestHandler.h +++ b/packages/react-native/Libraries/Network/RCTHTTPRequestHandler.h @@ -13,7 +13,7 @@ typedef NSURLSessionConfiguration * (^NSURLSessionConfigurationProvider)(void); * The block provided via this function will provide the NSURLSessionConfiguration for all HTTP requests made by the * app. */ -RCT_EXTERN void RCTSetCustomNSURLSessionConfigurationProvider(NSURLSessionConfigurationProvider); +RCT_EXTERN void RCTSetCustomNSURLSessionConfigurationProvider(NSURLSessionConfigurationProvider /*provider*/); /** * This is the default RCTURLRequestHandler implementation for HTTP requests. */ diff --git a/packages/react-native/React/Base/RCTAssert.h b/packages/react-native/React/Base/RCTAssert.h index 54fb5b7278cc69..409db6b75f2447 100644 --- a/packages/react-native/React/Base/RCTAssert.h +++ b/packages/react-native/React/Base/RCTAssert.h @@ -37,8 +37,13 @@ RCT_EXTERN BOOL RCTIsMainQueue(void); do { \ } while (false) #endif -RCT_EXTERN void _RCTAssertFormat(const char *, const char *, int, const char *, NSString *, ...) - NS_FORMAT_FUNCTION(5, 6); +RCT_EXTERN void _RCTAssertFormat( + const char * /*condition*/, + const char * /*fileName*/, + int /*lineNumber*/, + const char * /*function*/, + NSString * /*format*/, + ...) NS_FORMAT_FUNCTION(5, 6); /** * Report a fatal condition when executing. These calls will _NOT_ be compiled out diff --git a/packages/react-native/React/Base/RCTAssert.m b/packages/react-native/React/Base/RCTAssert.m index e9ace57473cbb4..1b8b1870a5b83f 100644 --- a/packages/react-native/React/Base/RCTAssert.m +++ b/packages/react-native/React/Base/RCTAssert.m @@ -22,7 +22,7 @@ RCTFatalHandler RCTCurrentFatalHandler = nil; RCTFatalExceptionHandler RCTCurrentFatalExceptionHandler = nil; -NSException *_RCTNotImplementedException(SEL, Class); +NSException *_RCTNotImplementedException(SEL /*cmd*/, Class /*cls*/); NSException *_RCTNotImplementedException(SEL cmd, Class cls) { NSString *msg = [NSString stringWithFormat: diff --git a/packages/react-native/React/Base/RCTBridge.mm b/packages/react-native/React/Base/RCTBridge.mm index 9011105dfe414a..b8452a3a22585e 100644 --- a/packages/react-native/React/Base/RCTBridge.mm +++ b/packages/react-native/React/Base/RCTBridge.mm @@ -117,7 +117,7 @@ } static NSMutableArray *modulesLoadedWithOldArch; -void addModuleLoadedWithOldArch(NSString *); +void addModuleLoadedWithOldArch(NSString * /*moduleName*/); void addModuleLoadedWithOldArch(NSString *moduleName) { static dispatch_once_t onceToken; @@ -138,7 +138,7 @@ void addModuleLoadedWithOldArch(NSString *moduleName) * prior to the first bridge initialization. * TODO: (T115656171) Refactor RCTRegisterModule out of Bridge.m since it doesn't use the Bridge. */ -void RCTRegisterModule(Class); +void RCTRegisterModule(Class /*moduleClass*/); void RCTRegisterModule(Class moduleClass) { if (RCTAreLegacyLogsEnabled() && ![getCoreModuleClasses() containsObject:[moduleClass description]]) { diff --git a/packages/react-native/React/Base/RCTConvert.h b/packages/react-native/React/Base/RCTConvert.h index 88e5963d10efcf..ecec4e24fde44b 100644 --- a/packages/react-native/React/Base/RCTConvert.h +++ b/packages/react-native/React/Base/RCTConvert.h @@ -177,9 +177,14 @@ typedef NSArray UIColorArray __deprecated_msg("Use NSArray"); /** * Underlying implementations of RCT_XXX_CONVERTER macros. Ignore these. */ -RCT_EXTERN NSNumber *RCTConvertEnumValue(const char *, NSDictionary *, NSNumber *, id); -RCT_EXTERN NSNumber *RCTConvertMultiEnumValue(const char *, NSDictionary *, NSNumber *, id); -RCT_EXTERN NSArray *RCTConvertArrayValue(SEL, id); +RCT_EXTERN NSNumber * +RCTConvertEnumValue(const char * /*typeName*/, NSDictionary * /*mapping*/, NSNumber * /*defaultValue*/, id /*json*/); +RCT_EXTERN NSNumber *RCTConvertMultiEnumValue( + const char * /*typeName*/, + NSDictionary * /*mapping*/, + NSNumber * /*defaultValue*/, + id /*json*/); +RCT_EXTERN NSArray *RCTConvertArrayValue(SEL /*type*/, id /*json*/); /** * This macro is used for logging conversion errors. This is just used to diff --git a/packages/react-native/React/Base/RCTLog.h b/packages/react-native/React/Base/RCTLog.h index 2e750b8a77b4d9..f33362ed9878b8 100644 --- a/packages/react-native/React/Base/RCTLog.h +++ b/packages/react-native/React/Base/RCTLog.h @@ -75,12 +75,12 @@ RCTFormatLog(NSDate *timestamp, RCTLogLevel level, NSString *fileName, NSNumber /** * A method to generate a string RCTLogLevel */ -RCT_EXTERN NSString *RCTFormatLogLevel(RCTLogLevel); +RCT_EXTERN NSString *RCTFormatLogLevel(RCTLogLevel /*level*/); /** * A method to generate a string from a RCTLogSource */ -RCT_EXTERN NSString *RCTFormatLogSource(RCTLogSource); +RCT_EXTERN NSString *RCTFormatLogSource(RCTLogSource /*source*/); /** * The default logging function used by RCTLogXX. @@ -149,5 +149,7 @@ RCT_EXTERN void RCTLogSetBridgelessCallableJSModules(RCTCallableJSModules *calla } while (0) #endif -RCT_EXTERN void _RCTLogNativeInternal(RCTLogLevel, const char *, int, NSString *, ...) NS_FORMAT_FUNCTION(4, 5); -RCT_EXTERN void _RCTLogJavaScriptInternal(RCTLogLevel, NSString *); +RCT_EXTERN void +_RCTLogNativeInternal(RCTLogLevel /*level*/, const char * /*fileName*/, int /*lineNumber*/, NSString * /*format*/, ...) + NS_FORMAT_FUNCTION(4, 5); +RCT_EXTERN void _RCTLogJavaScriptInternal(RCTLogLevel /*level*/, NSString * /*message*/); diff --git a/packages/react-native/React/Base/RCTUtils.mm b/packages/react-native/React/Base/RCTUtils.mm index d98cb21a539e19..f0404d55814302 100644 --- a/packages/react-native/React/Base/RCTUtils.mm +++ b/packages/react-native/React/Base/RCTUtils.mm @@ -706,7 +706,7 @@ BOOL RCTForceTouchAvailable(void) [data base64EncodedStringWithOptions:(NSDataBase64EncodingOptions)0]]]; } -BOOL RCTIsGzippedData(NSData *__nullable); // exposed for unit testing purposes +BOOL RCTIsGzippedData(NSData *__nullable /*data*/); // exposed for unit testing purposes BOOL RCTIsGzippedData(NSData *__nullable data) { UInt8 *bytes = (UInt8 *)data.bytes; diff --git a/packages/react-native/React/CoreModules/RCTAppearance.h b/packages/react-native/React/CoreModules/RCTAppearance.h index 5b8ad85b60ec20..124594dcc0a8a6 100644 --- a/packages/react-native/React/CoreModules/RCTAppearance.h +++ b/packages/react-native/React/CoreModules/RCTAppearance.h @@ -12,7 +12,7 @@ #import RCT_EXTERN void RCTEnableAppearancePreference(BOOL enabled); -RCT_EXTERN void RCTOverrideAppearancePreference(NSString *); +RCT_EXTERN void RCTOverrideAppearancePreference(NSString * /*colorSchemeOverride*/); RCT_EXTERN void RCTUseKeyWindowForSystemStyle(BOOL useMainScreen); RCT_EXTERN NSString *RCTCurrentOverrideAppearancePreference(void); RCT_EXTERN NSString *RCTColorSchemePreference(UITraitCollection *traitCollection); diff --git a/packages/react-native/React/CxxBridge/RCTMessageThread.h b/packages/react-native/React/CxxBridge/RCTMessageThread.h index 2e9125d2c4dc79..0306a1fea3c165 100644 --- a/packages/react-native/React/CxxBridge/RCTMessageThread.h +++ b/packages/react-native/React/CxxBridge/RCTMessageThread.h @@ -21,8 +21,8 @@ class RCTMessageThread : public MessageQueueThread, public: RCTMessageThread(NSRunLoop* runLoop, RCTJavaScriptCompleteBlock errorBlock); ~RCTMessageThread() override; - void runOnQueue(std::function&&) override; - void runOnQueueSync(std::function&&) override; + void runOnQueue(std::function&& /*func*/) override; + void runOnQueueSync(std::function&& /*func*/) override; void quitSynchronous() override; void setRunLoop(NSRunLoop* runLoop); diff --git a/packages/react-native/React/CxxBridge/RCTObjcExecutor.mm b/packages/react-native/React/CxxBridge/RCTObjcExecutor.mm index c0b5465a8bc85d..fa8e04117972f1 100644 --- a/packages/react-native/React/CxxBridge/RCTObjcExecutor.mm +++ b/packages/react-native/React/CxxBridge/RCTObjcExecutor.mm @@ -90,7 +90,7 @@ void loadBundle(std::unique_ptr script, std::string sourceURL }]; } - void setBundleRegistry(std::unique_ptr) override + void setBundleRegistry(std::unique_ptr /*bundleRegistry*/) override { RCTAssert(NO, @"RAM bundles are not supported in RCTObjcExecutor"); } diff --git a/packages/react-native/React/Profiler/RCTProfile.h b/packages/react-native/React/Profiler/RCTProfile.h index 26daf12370c530..5845bafe9c3d52 100644 --- a/packages/react-native/React/Profiler/RCTProfile.h +++ b/packages/react-native/React/Profiler/RCTProfile.h @@ -43,7 +43,7 @@ RCT_EXTERN dispatch_queue_t RCTProfileGetQueue(void) RCT_EXTERN NSUInteger _RCTProfileBeginFlowEvent(void) __deprecated_msg("This API will be removed along with the legacy architecture."); -RCT_EXTERN void _RCTProfileEndFlowEvent(NSUInteger) +RCT_EXTERN void _RCTProfileEndFlowEvent(NSUInteger /*cookie*/) __deprecated_msg("This API will be removed along with the legacy architecture."); /** @@ -55,7 +55,7 @@ RCT_EXTERN BOOL RCTProfileIsProfiling(void) /** * Start collecting profiling information */ -RCT_EXTERN void RCTProfileInit(RCTBridge *) +RCT_EXTERN void RCTProfileInit(RCTBridge * /*bridge*/) __deprecated_msg("This API will be removed along with the legacy architecture."); /** @@ -63,7 +63,7 @@ RCT_EXTERN void RCTProfileInit(RCTBridge *) * returned is compliant with google's trace event format - the format used * as input to trace-viewer */ -RCT_EXTERN void RCTProfileEnd(RCTBridge *, void (^)(NSString *)) +RCT_EXTERN void RCTProfileEnd(RCTBridge * /*bridge*/, void (^/*callback*/)(NSString *)) __deprecated_msg("This API will be removed along with the legacy architecture."); /** @@ -164,13 +164,13 @@ RCT_EXTERN void RCTProfileImmediateEvent(uint64_t tag, NSString *name, NSTimeInt /** * Hook into a bridge instance to log all bridge module's method calls */ -RCT_EXTERN void RCTProfileHookModules(RCTBridge *) +RCT_EXTERN void RCTProfileHookModules(RCTBridge * /*bridge*/) __deprecated_msg("This API will be removed along with the legacy architecture."); /** * Unhook from a given bridge instance's modules */ -RCT_EXTERN void RCTProfileUnhookModules(RCTBridge *) +RCT_EXTERN void RCTProfileUnhookModules(RCTBridge * /*bridge*/) __deprecated_msg("This API will be removed along with the legacy architecture."); /** @@ -215,7 +215,7 @@ typedef struct { void (*end_async_flow)(uint64_t tag, const char *name, int cookie); } RCTProfileCallbacks __deprecated_msg("This API will be removed along with the legacy architecture."); -RCT_EXTERN void RCTProfileRegisterCallbacks(RCTProfileCallbacks *) +RCT_EXTERN void RCTProfileRegisterCallbacks(RCTProfileCallbacks * /*cb*/) __deprecated_msg("This API will be removed along with the legacy architecture."); /** diff --git a/packages/react-native/React/Profiler/RCTProfile.m b/packages/react-native/React/Profiler/RCTProfile.m index 994e8ad6c107cb..47f7f6cfe714f7 100644 --- a/packages/react-native/React/Profiler/RCTProfile.m +++ b/packages/react-native/React/Profiler/RCTProfile.m @@ -184,7 +184,7 @@ IMP RCTProfileGetImplementation(id obj, SEL cmd) static void *RCTProfileTrampoline = NULL; #endif -RCT_EXTERN void RCTProfileTrampolineStart(id, SEL); +RCT_EXTERN void RCTProfileTrampolineStart(id /*self*/, SEL /*cmd*/); void RCTProfileTrampolineStart(id self, SEL cmd) { /** diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JCxxInspectorPackagerConnection.h b/packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JCxxInspectorPackagerConnection.h index 7fc555cf2942e6..79793b751148b4 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JCxxInspectorPackagerConnection.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JCxxInspectorPackagerConnection.h @@ -49,7 +49,7 @@ class JCxxInspectorPackagerConnection jni::alias_ref delegate); static jni::local_ref initHybrid( - jni::alias_ref, + jni::alias_ref /*unused*/, const std::string& url, const std::string& deviceName, const std::string& packageName, diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JInspectorFlags.h b/packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JInspectorFlags.h index 40bd0d725ba0af..0874ccf3ac3700 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JInspectorFlags.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JInspectorFlags.h @@ -19,8 +19,8 @@ class JInspectorFlags : public jni::JavaClass { static constexpr auto kJavaDescriptor = "Lcom/facebook/react/devsupport/InspectorFlags;"; - static bool getFuseboxEnabled(jni::alias_ref); - static bool getIsProfilingBuild(jni::alias_ref); + static bool getFuseboxEnabled(jni::alias_ref /*unused*/); + static bool getIsProfilingBuild(jni::alias_ref /*unused*/); static void registerNatives(); diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/ComponentFactory.h b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/ComponentFactory.h index 5aa76a17423a15..c87780f3f96afe 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/ComponentFactory.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/ComponentFactory.h @@ -25,7 +25,8 @@ class ComponentFactory : public jni::HybridClass { ComponentRegistryFactory buildRegistryFunction; private: - static jni::local_ref initHybrid(jni::alias_ref); + static jni::local_ref initHybrid( + jni::alias_ref /*unused*/); }; } // namespace facebook::react diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/hermes/instrumentation/HermesSamplingProfiler.h b/packages/react-native/ReactAndroid/src/main/jni/react/hermes/instrumentation/HermesSamplingProfiler.h index 733af3d2561c04..4cfb0e8fc3468e 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/hermes/instrumentation/HermesSamplingProfiler.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/hermes/instrumentation/HermesSamplingProfiler.h @@ -19,10 +19,10 @@ class HermesSamplingProfiler : public jni::JavaClass { public: constexpr static auto kJavaDescriptor = "Lcom/facebook/hermes/instrumentation/HermesSamplingProfiler;"; - static void enable(jni::alias_ref); - static void disable(jni::alias_ref); + static void enable(jni::alias_ref /*unused*/); + static void disable(jni::alias_ref /*unused*/); static void dumpSampledTraceToFile( - jni::alias_ref, + jni::alias_ref /*unused*/, const std::string& filename); static void registerNatives(); diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.h b/packages/react-native/ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.h index 57e39a46fe25b0..327c5e4583e1df 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.h @@ -43,7 +43,8 @@ class [[deprecated( static constexpr auto kJavaDescriptor = "Lcom/facebook/react/bridge/CatalystInstanceImpl;"; - static jni::local_ref initHybrid(jni::alias_ref); + static jni::local_ref initHybrid( + jni::alias_ref /*unused*/); static void registerNatives(); diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.h b/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.h index f9c91b38cac150..3161651e9a299a 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/jni/ReactInstanceManagerInspectorTarget.h @@ -62,7 +62,7 @@ class ReactInstanceManagerInspectorTarget jsinspector_modern::HostTargetMetadata getMetadata() override; void onReload(const PageReloadRequest& request) override; void onSetPausedInDebuggerMessage( - const OverlaySetPausedInDebuggerMessageRequest&) override; + const OverlaySetPausedInDebuggerMessageRequest& /*request*/) override; void loadNetworkResource( const jsinspector_modern::LoadNetworkResourceRequest& params, jsinspector_modern::ScopedExecutor< diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.h b/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.h index 9a27c7ba51a036..a5a77b4e61a778 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.h @@ -33,7 +33,7 @@ class DefaultComponentsRegistry private: static void setRegistryRunction( - jni::alias_ref, + jni::alias_ref /*unused*/, ComponentFactory* delegate); }; diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.h b/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.h index 099c245f574df9..0a8af0d35d23ac 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.h @@ -25,8 +25,9 @@ class DefaultTurboModuleManagerDelegate : public jni::HybridClass< "Lcom/facebook/react/defaults/DefaultTurboModuleManagerDelegate;"; static jni::local_ref initHybrid( - jni::alias_ref, - jni::alias_ref::javaobject>); + jni::alias_ref /*unused*/, + jni::alias_ref::javaobject> /*cxxReactPackages*/); static void registerNatives(); diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/reactnativeblob/BlobCollector.h b/packages/react-native/ReactAndroid/src/main/jni/react/reactnativeblob/BlobCollector.h index f63d576632a27d..63202bcef0563c 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/reactnativeblob/BlobCollector.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/reactnativeblob/BlobCollector.h @@ -24,7 +24,7 @@ class BlobCollector : public jni::HybridClass, "Lcom/facebook/react/modules/blob/BlobCollector;"; static void nativeInstall( - jni::alias_ref, + jni::alias_ref /*unused*/, jni::alias_ref blobModule, jlong jsContextNativePointer); diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactInstance.h b/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactInstance.h index 2b42b70507eff3..1274cad4f2be93 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactInstance.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactInstance.h @@ -37,7 +37,7 @@ class JReactInstance : public jni::HybridClass { "Lcom/facebook/react/runtime/ReactInstance;"; static jni::local_ref initHybrid( - jni::alias_ref, + jni::alias_ref /*unused*/, jni::alias_ref jsRuntimeFactory, jni::alias_ref jsMessageQueueThread, jni::alias_ref diff --git a/packages/react-native/ReactCommon/cxxreact/CxxModule.h b/packages/react-native/ReactCommon/cxxreact/CxxModule.h index a825c401388abc..59c7d637a95f54 100644 --- a/packages/react-native/ReactCommon/cxxreact/CxxModule.h +++ b/packages/react-native/ReactCommon/cxxreact/CxxModule.h @@ -110,7 +110,7 @@ class CxxModule { Method( std::string aname, std::function&& afunc, - AsyncTagType) + AsyncTagType /*unused*/) : name(std::move(aname)), callbacks(2), isPromise(false), @@ -163,7 +163,7 @@ class CxxModule { std::string aname, T* t, void (T::*method)(folly::dynamic, Callback, Callback), - AsyncTagType) + AsyncTagType /*unused*/) : name(std::move(aname)), callbacks(2), isPromise(false), @@ -183,7 +183,7 @@ class CxxModule { Method( std::string aname, std::function&& afunc, - SyncTagType) + SyncTagType /*unused*/) : name(std::move(aname)), callbacks(0), isPromise(false), @@ -194,7 +194,7 @@ class CxxModule { Method( std::string aname, std::function&& afunc, - SyncTagType) + SyncTagType /*unused*/) : name(std::move(aname)), callbacks(0), isPromise(false), diff --git a/packages/react-native/ReactCommon/jsc/JSCRuntime.cpp b/packages/react-native/ReactCommon/jsc/JSCRuntime.cpp index 6279ab9c9896ad..cdf37ddf722e75 100644 --- a/packages/react-native/ReactCommon/jsc/JSCRuntime.cpp +++ b/packages/react-native/ReactCommon/jsc/JSCRuntime.cpp @@ -27,8 +27,8 @@ class ArgsConverter; class JSCRuntime; struct Lock { - void lock(const jsc::JSCRuntime&) const {} - void unlock(const jsc::JSCRuntime&) const {} + void lock(const jsc::JSCRuntime& /*unused*/) const {} + void unlock(const jsc::JSCRuntime& /*unused*/) const {} }; class JSCRuntime : public jsi::Runtime { @@ -158,78 +158,88 @@ class JSCRuntime : public jsi::Runtime { override; jsi::PropNameID createPropNameIDFromString(const jsi::String& str) override; jsi::PropNameID createPropNameIDFromSymbol(const jsi::Symbol& sym) override; - std::string utf8(const jsi::PropNameID&) override; - bool compare(const jsi::PropNameID&, const jsi::PropNameID&) override; + std::string utf8(const jsi::PropNameID& /*sym*/) override; + bool compare(const jsi::PropNameID& /*a*/, const jsi::PropNameID& /*b*/) + override; - std::string symbolToString(const jsi::Symbol&) override; + std::string symbolToString(const jsi::Symbol& /*sym*/) override; - jsi::BigInt createBigIntFromInt64(int64_t) override; - jsi::BigInt createBigIntFromUint64(uint64_t) override; - bool bigintIsInt64(const jsi::BigInt&) override; - bool bigintIsUint64(const jsi::BigInt&) override; - uint64_t truncate(const jsi::BigInt&) override; - jsi::String bigintToString(const jsi::BigInt&, int) override; + jsi::BigInt createBigIntFromInt64(int64_t /*unused*/) override; + jsi::BigInt createBigIntFromUint64(uint64_t /*unused*/) override; + bool bigintIsInt64(const jsi::BigInt& /*unused*/) override; + bool bigintIsUint64(const jsi::BigInt& /*unused*/) override; + uint64_t truncate(const jsi::BigInt& /*unused*/) override; + jsi::String bigintToString(const jsi::BigInt& /*unused*/, int /*unused*/) + override; jsi::String createStringFromAscii(const char* str, size_t length) override; jsi::String createStringFromUtf8(const uint8_t* utf8, size_t length) override; - std::string utf8(const jsi::String&) override; + std::string utf8(const jsi::String& /*str*/) override; jsi::Object createObject() override; jsi::Object createObject(std::shared_ptr ho) override; virtual std::shared_ptr getHostObject( - const jsi::Object&) override; - jsi::HostFunctionType& getHostFunction(const jsi::Function&) override; + const jsi::Object& /*obj*/) override; + jsi::HostFunctionType& getHostFunction(const jsi::Function& /*obj*/) override; - bool hasNativeState(const jsi::Object&) override; - std::shared_ptr getNativeState(const jsi::Object&) override; - void setNativeState(const jsi::Object&, std::shared_ptr) - override; + bool hasNativeState(const jsi::Object& /*obj*/) override; + std::shared_ptr getNativeState( + const jsi::Object& /*obj*/) override; + void setNativeState( + const jsi::Object& /*obj*/, + std::shared_ptr /*nativeState*/) override; - jsi::Value getProperty(const jsi::Object&, const jsi::String& name) override; - jsi::Value getProperty(const jsi::Object&, const jsi::PropNameID& name) + jsi::Value getProperty(const jsi::Object& /*obj*/, const jsi::String& name) + override; + jsi::Value getProperty( + const jsi::Object& /*obj*/, + const jsi::PropNameID& name) override; + bool hasProperty(const jsi::Object& /*obj*/, const jsi::String& name) + override; + bool hasProperty(const jsi::Object& /*obj*/, const jsi::PropNameID& name) override; - bool hasProperty(const jsi::Object&, const jsi::String& name) override; - bool hasProperty(const jsi::Object&, const jsi::PropNameID& name) override; void setPropertyValue( - const jsi::Object&, + const jsi::Object& /*object*/, const jsi::String& name, const jsi::Value& value) override; void setPropertyValue( - const jsi::Object&, + const jsi::Object& /*object*/, const jsi::PropNameID& name, const jsi::Value& value) override; - bool isArray(const jsi::Object&) const override; - bool isArrayBuffer(const jsi::Object&) const override; - bool isFunction(const jsi::Object&) const override; - bool isHostObject(const jsi::Object&) const override; - bool isHostFunction(const jsi::Function&) const override; - jsi::Array getPropertyNames(const jsi::Object&) override; + bool isArray(const jsi::Object& /*obj*/) const override; + bool isArrayBuffer(const jsi::Object& /*obj*/) const override; + bool isFunction(const jsi::Object& /*obj*/) const override; + bool isHostObject(const jsi::Object& /*obj*/) const override; + bool isHostFunction(const jsi::Function& /*obj*/) const override; + jsi::Array getPropertyNames(const jsi::Object& /*obj*/) override; // TODO: revisit this implementation - jsi::WeakObject createWeakObject(const jsi::Object&) override; - jsi::Value lockWeakObject(const jsi::WeakObject&) override; + jsi::WeakObject createWeakObject(const jsi::Object& /*obj*/) override; + jsi::Value lockWeakObject(const jsi::WeakObject& /*obj*/) override; jsi::Array createArray(size_t length) override; jsi::ArrayBuffer createArrayBuffer( std::shared_ptr buffer) override; - size_t size(const jsi::Array&) override; - size_t size(const jsi::ArrayBuffer&) override; - uint8_t* data(const jsi::ArrayBuffer&) override; - jsi::Value getValueAtIndex(const jsi::Array&, size_t i) override; - void setValueAtIndexImpl(const jsi::Array&, size_t i, const jsi::Value& value) - override; + size_t size(const jsi::Array& /*arr*/) override; + size_t size(const jsi::ArrayBuffer& /*obj*/) override; + uint8_t* data(const jsi::ArrayBuffer& /*obj*/) override; + jsi::Value getValueAtIndex(const jsi::Array& /*arr*/, size_t i) override; + void setValueAtIndexImpl( + const jsi::Array& /*arr*/, + size_t i, + const jsi::Value& value) override; jsi::Function createFunctionFromHostFunction( const jsi::PropNameID& name, unsigned int paramCount, jsi::HostFunctionType func) override; jsi::Value call( - const jsi::Function&, + const jsi::Function& /*f*/, const jsi::Value& jsThis, const jsi::Value* args, size_t count) override; jsi::Value callAsConstructor( - const jsi::Function&, + const jsi::Function& /*f*/, const jsi::Value* args, size_t count) override; @@ -238,7 +248,8 @@ class JSCRuntime : public jsi::Runtime { bool strictEquals(const jsi::String& a, const jsi::String& b) const override; bool strictEquals(const jsi::Object& a, const jsi::Object& b) const override; bool instanceOf(const jsi::Object& o, const jsi::Function& f) override; - void setExternalMemoryPressure(const jsi::Object&, size_t) override; + void setExternalMemoryPressure(const jsi::Object& /*obj*/, size_t /*amount*/) + override; private: // Basically convenience casts @@ -605,7 +616,7 @@ jsi::Runtime::PointerValue* JSCRuntime::cloneSymbol( } jsi::Runtime::PointerValue* JSCRuntime::cloneBigInt( - const Runtime::PointerValue*) { + const Runtime::PointerValue* /*pv*/) { throw std::logic_error("Not implemented"); } @@ -683,27 +694,29 @@ std::string JSCRuntime::symbolToString(const jsi::Symbol& sym) { return jsi::Value(*this, sym).toString(*this).utf8(*this); } -jsi::BigInt JSCRuntime::createBigIntFromInt64(int64_t) { +jsi::BigInt JSCRuntime::createBigIntFromInt64(int64_t /*unused*/) { throw std::logic_error("Not implemented"); } -jsi::BigInt JSCRuntime::createBigIntFromUint64(uint64_t) { +jsi::BigInt JSCRuntime::createBigIntFromUint64(uint64_t /*unused*/) { throw std::logic_error("Not implemented"); } -bool JSCRuntime::bigintIsInt64(const jsi::BigInt&) { +bool JSCRuntime::bigintIsInt64(const jsi::BigInt& /*unused*/) { throw std::logic_error("Not implemented"); } -bool JSCRuntime::bigintIsUint64(const jsi::BigInt&) { +bool JSCRuntime::bigintIsUint64(const jsi::BigInt& /*unused*/) { throw std::logic_error("Not implemented"); } -uint64_t JSCRuntime::truncate(const jsi::BigInt&) { +uint64_t JSCRuntime::truncate(const jsi::BigInt& /*unused*/) { throw std::logic_error("Not implemented"); } -jsi::String JSCRuntime::bigintToString(const jsi::BigInt&, int) { +jsi::String JSCRuntime::bigintToString( + const jsi::BigInt& /*unused*/, + int /*unused*/) { throw std::logic_error("Not implemented"); } @@ -1426,7 +1439,9 @@ bool JSCRuntime::instanceOf(const jsi::Object& o, const jsi::Function& f) { return res; } -void JSCRuntime::setExternalMemoryPressure(const jsi::Object&, size_t) {} +void JSCRuntime::setExternalMemoryPressure( + const jsi::Object& /*obj*/, + size_t /*amount*/) {} jsi::Runtime::PointerValue* JSCRuntime::makeSymbolValue( JSValueRef symbolRef) const {