Move using declarations into AnimationBackend class #54057
Closed
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 3, 2025
Summary: ## Changelog: [General] [Changed] - Move using declarations into AnimationBackend class names like `facebook::react::Callback` is a bit too generic and it'll be included in the scope whenever AnimationBackend.h is included in; `StartOnRenderCallback` already exists in c++ native animated (there we also nest the `using`s under class) Differential Revision: D83867098
Summary: ## Changelog: [General] [Changed] - Move using declarations into AnimationBackend class names like `facebook::react::Callback` is a bit too generic and it'll be included in the scope whenever AnimationBackend.h is included in; `StartOnRenderCallback` already exists in c++ native animated (there we also nest the `using`s under class) Reviewed By: sammy-SC Differential Revision: D83867098
zeyap
force-pushed
the
export-D83867098
branch
from
6052fca to
e6d2fd4
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 7, 2025
Summary: ## Changelog: [General] [Changed] - Move using declarations into AnimationBackend class names like `facebook::react::Callback` is a bit too generic and it'll be included in the scope whenever AnimationBackend.h is included in; `StartOnRenderCallback` already exists in c++ native animated (there we also nest the `using`s under class) Reviewed By: sammy-SC Differential Revision: D83867098
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 7, 2025
Summary: ## Changelog: [General] [Changed] - Move using declarations into AnimationBackend class names like `facebook::react::Callback` is a bit too generic and it'll be included in the scope whenever AnimationBackend.h is included in; `StartOnRenderCallback` already exists in c++ native animated (there we also nest the `using`s under class) Reviewed By: sammy-SC Differential Revision: D83867098
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 7, 2025
Summary: ## Changelog: [General] [Changed] - Move using declarations into AnimationBackend class names like `facebook::react::Callback` is a bit too generic and it'll be included in the scope whenever AnimationBackend.h is included in; `StartOnRenderCallback` already exists in c++ native animated (there we also nest the `using`s under class) Reviewed By: sammy-SC Differential Revision: D83867098
|
This pull request has been merged in 9e98c72. |
|
This pull request was successfully merged by @zeyap in 9e98c72 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General] [Changed] - Move using declarations into AnimationBackend class
names like
facebook::react::Callbackis a bit too generic and it'll be included in the scope whenever AnimationBackend.h is included in;StartOnRenderCallbackalready exists in c++ native animated (there we also nest theusings under class)Differential Revision: D83867098