Skip to content

Conversation

zeyap
Copy link
Contributor

@zeyap zeyap commented Oct 3, 2025

Summary:

Changelog:

[Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare class AnimationBackend

for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend

also this way, in the future, animation runtimes that consume AnimationBackend can just include UIManagerAnimationBackend (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too

Differential Revision: D83679693

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2025
Copy link

meta-codesync bot commented Oct 3, 2025

@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83679693.

Copy link

meta-codesync bot commented Oct 3, 2025

@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83679693.

zeyap added a commit to zeyap/react-native that referenced this pull request Oct 7, 2025
…imationBackend` (facebook#54058)

Summary:

## Changelog:

[Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend`

for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend

also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too

Reviewed By: sammy-SC

Differential Revision: D83679693
@zeyap zeyap force-pushed the export-D83679693 branch from 7199bfa to 8401824 Compare October 7, 2025 17:57
zeyap added a commit to zeyap/react-native that referenced this pull request Oct 7, 2025
…imationBackend` (facebook#54058)

Summary:

## Changelog:

[Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend`

for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend

also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too

Reviewed By: sammy-SC

Differential Revision: D83679693
@zeyap zeyap force-pushed the export-D83679693 branch from 8401824 to 3af87d4 Compare October 7, 2025 17:57
zeyap added a commit to zeyap/react-native that referenced this pull request Oct 7, 2025
…imationBackend` (facebook#54058)

Summary:

## Changelog:

[Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend`

for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend

also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too

Reviewed By: sammy-SC

Differential Revision: D83679693
…imationBackend` (facebook#54058)

Summary:

## Changelog:

[Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend`

for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend

also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too

Reviewed By: sammy-SC

Differential Revision: D83679693
@zeyap zeyap force-pushed the export-D83679693 branch from 3af87d4 to b89303d Compare October 8, 2025 13:26
zeyap added a commit to zeyap/react-native that referenced this pull request Oct 8, 2025
…imationBackend` (facebook#54058)

Summary:

## Changelog:

[Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend`

for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend

also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too

Reviewed By: sammy-SC

Differential Revision: D83679693
zeyap added a commit to zeyap/react-native that referenced this pull request Oct 8, 2025
…imationBackend` (facebook#54058)

Summary:

## Changelog:

[Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend`

for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend

also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too

Reviewed By: sammy-SC

Differential Revision: D83679693
zeyap added a commit to zeyap/react-native that referenced this pull request Oct 8, 2025
…imationBackend` (facebook#54058)

Summary:

## Changelog:

[Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend`

for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend

also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too

Reviewed By: sammy-SC

Differential Revision: D83679693
zeyap added a commit to zeyap/react-native that referenced this pull request Oct 8, 2025
…imationBackend` (facebook#54058)

Summary:

## Changelog:

[Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend`

for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend

also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too

Reviewed By: sammy-SC

Differential Revision: D83679693
@meta-codesync meta-codesync bot closed this in 197783b Oct 8, 2025
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 8, 2025
Copy link

meta-codesync bot commented Oct 8, 2025

This pull request has been merged in 197783b.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @zeyap in 197783b

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants