-
Notifications
You must be signed in to change notification settings - Fork 24.9k
create UIManagerAnimationBackend to replace forward declare class AnimationBackend
#54058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 7, 2025
…imationBackend` (facebook#54058) Summary: ## Changelog: [Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend` for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too Reviewed By: sammy-SC Differential Revision: D83679693
7199bfa
to
8401824
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 7, 2025
…imationBackend` (facebook#54058) Summary: ## Changelog: [Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend` for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too Reviewed By: sammy-SC Differential Revision: D83679693
8401824
to
3af87d4
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 7, 2025
…imationBackend` (facebook#54058) Summary: ## Changelog: [Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend` for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too Reviewed By: sammy-SC Differential Revision: D83679693
…imationBackend` (facebook#54058) Summary: ## Changelog: [Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend` for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too Reviewed By: sammy-SC Differential Revision: D83679693
3af87d4
to
b89303d
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 8, 2025
…imationBackend` (facebook#54058) Summary: ## Changelog: [Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend` for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too Reviewed By: sammy-SC Differential Revision: D83679693
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 8, 2025
…imationBackend` (facebook#54058) Summary: ## Changelog: [Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend` for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too Reviewed By: sammy-SC Differential Revision: D83679693
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 8, 2025
…imationBackend` (facebook#54058) Summary: ## Changelog: [Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend` for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too Reviewed By: sammy-SC Differential Revision: D83679693
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 8, 2025
…imationBackend` (facebook#54058) Summary: ## Changelog: [Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare `class AnimationBackend` for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend also this way, in the future, animation runtimes that consume AnimationBackend can just include `UIManagerAnimationBackend` (where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled too Reviewed By: sammy-SC Differential Revision: D83679693
This pull request has been merged in 197783b. |
This pull request was successfully merged by @zeyap in 197783b When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
meta-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Changed] - create UIManagerAnimationBackend to replace forward declare
class AnimationBackend
for other delegates in UIManager, we usually explicitly create an interface in UIManager package with the public APIs we want to expose, we can follow that pattern here, so we avoid the forward declaration without definition situation, and decoupling UIManager with AnimationBackend
also this way, in the future, animation runtimes that consume AnimationBackend can just include
UIManagerAnimationBackend
(where we expose all of public APIs of AnimationBackend) and remain somewhat decoupled tooDifferential Revision: D83679693