Refactor console API implementation to use tryExecuteSync for clarity #54069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Oct 7, 2025
…facebook#54069) Summary: Changelog: [Internal] D83238216 added a `tryExecuteSync` function for use with `EnableExecutorFromThis` objects - concretely, for calling functions on a `weak_ptr<RuntimeTarget>` from the JS thread while ensuring the `RuntimeTarget` is always destroyed on the inspector thread. `tryExecuteSync` is a generalisation of the lambda-based `delegateExecutorSync` helper from `RuntimeTargetConsole`, so in this diff we refactor the latter to use the more general and better-documented function. Differential Revision: D83838062
motiz88
force-pushed
the
export-D83838062
branch
2 times, most recently
from
da4367a to
7910a46
Compare
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Oct 8, 2025
…facebook#54069) Summary: Changelog: [Internal] D83238216 added a `tryExecuteSync` function for use with `EnableExecutorFromThis` objects - concretely, for calling functions on a `weak_ptr<RuntimeTarget>` from the JS thread while ensuring the `RuntimeTarget` is always destroyed on the inspector thread. `tryExecuteSync` is a generalisation of the lambda-based `delegateExecutorSync` helper from `RuntimeTargetConsole`, so in this diff we refactor the latter to use the more general and better-documented function. Reviewed By: huntie Differential Revision: D83838062
Summary: Changelog: [Internal] Adds a minimal standards-compliant UUID v4 generator to `react/utils` for use elsewhere in React Native. We don't need UUID parsing, support for UUID versions other than 4, a UUID value type, or extremely high performance - which makes inlining this simple, portable implementation directly in our codebase acceptable. Reviewed By: robhogan Differential Revision: D84149720
…acebook#54051) Summary: Adds the private, experimental `__NETWORK_REPORTER__.createDevToolsRequestId()` JavaScript method behind the Fusebox network inspection feature flag. `createDevToolsRequestId()` returns a unique string ID for a network request, and records the current call stack as the request's [initiator](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Network#type-Initiator). If the native networking layer passes the same request ID into the C++ `NetworkReporter::reportRequestStart` method, the corresponding CDP [`requestWillBeSent`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Network#event-requestWillBeSent) event will contain the stack trace. Changelog: [Internal] Reviewed By: robhogan, huntie Differential Revision: D83238216
…facebook#54069) Summary: Changelog: [Internal] D83238216 added a `tryExecuteSync` function for use with `EnableExecutorFromThis` objects - concretely, for calling functions on a `weak_ptr<RuntimeTarget>` from the JS thread while ensuring the `RuntimeTarget` is always destroyed on the inspector thread. `tryExecuteSync` is a generalisation of the lambda-based `delegateExecutorSync` helper from `RuntimeTargetConsole`, so in this diff we refactor the latter to use the more general and better-documented function. Reviewed By: huntie Differential Revision: D83838062
motiz88
force-pushed
the
export-D83838062
branch
from
7910a46 to
2f9bae9
Compare
|
This pull request was successfully merged by @motiz88 in 5c7cbeb When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 5c7cbeb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
D83238216 added a
tryExecuteSyncfunction for use withEnableExecutorFromThisobjects - concretely, for calling functions on aweak_ptr<RuntimeTarget>from the JS thread while ensuring theRuntimeTargetis always destroyed on the inspector thread.tryExecuteSyncis a generalisation of the lambda-baseddelegateExecutorSynchelper fromRuntimeTargetConsole, so in this diff we refactor the latter to use the more general and better-documented function.Differential Revision: D83838062