Define HostTargetTracingDelegate #54622
Open
+127
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Summary: # Changelog: [Internal] There is no implementation for this method and it is unused. This is actually part of `HostAgent`. Differential Revision: D87220192
Summary: # Changelog: [Internal] Introduces a TracingDelegate that will receive tracing-related events on the Host side. We can't give synchronous access to tracing state to Host directly, since there is no guarantee that this call will happen on the inspector thread. Example: - `HostTarget::tracingState()` call may happen on UI thread, or whatever thread the Host is using, which reads `traceRecoding_` value. - At the same time, the `stopTracing()` call that will invalidate `traceRecording_` could happen on inspector thread. This is a pre-requisite for a better threading model, since we are going to be doing much frequent write operations from the Host side to record frame timings or screenshots. Differential Revision: D86205686
hoxyq
force-pushed
the
export-D86205686
branch
from
ea941bb to
e59647b
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 21, 2025
Summary: # Changelog: [Internal] Introduces a TracingDelegate that will receive tracing-related events on the Host side. We can't give synchronous access to tracing state to Host directly, since there is no guarantee that this call will happen on the inspector thread. Example: - `HostTarget::tracingState()` call may happen on UI thread, or whatever thread the Host is using, which reads `traceRecoding_` value. - At the same time, the `stopTracing()` call that will invalidate `traceRecording_` could happen on inspector thread. This is a pre-requisite for a better threading model, since we are going to be doing much frequent write operations from the Host side to record frame timings or screenshots. Differential Revision: D86205686
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 21, 2025
Summary: # Changelog: [Internal] Introduces a TracingDelegate that will receive tracing-related events on the Host side. We can't give synchronous access to tracing state to Host directly, since there is no guarantee that this call will happen on the inspector thread. Example: - `HostTarget::tracingState()` call may happen on UI thread, or whatever thread the Host is using, which reads `traceRecoding_` value. - At the same time, the `stopTracing()` call that will invalidate `traceRecording_` could happen on inspector thread. This is a pre-requisite for a better threading model, since we are going to be doing much frequent write operations from the Host side to record frame timings or screenshots. Differential Revision: D86205686
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 21, 2025
Summary: # Changelog: [Internal] Introduces a TracingDelegate that will receive tracing-related events on the Host side. We can't give synchronous access to tracing state to Host directly, since there is no guarantee that this call will happen on the inspector thread. Example: - `HostTarget::tracingState()` call may happen on UI thread, or whatever thread the Host is using, which reads `traceRecoding_` value. - At the same time, the `stopTracing()` call that will invalidate `traceRecording_` could happen on inspector thread. This is a pre-requisite for a better threading model, since we are going to be doing much frequent write operations from the Host side to record frame timings or screenshots. Differential Revision: D86205686
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 21, 2025
Summary: # Changelog: [Internal] Introduces a TracingDelegate that will receive tracing-related events on the Host side. We can't give synchronous access to tracing state to Host directly, since there is no guarantee that this call will happen on the inspector thread. Example: - `HostTarget::tracingState()` call may happen on UI thread, or whatever thread the Host is using, which reads `traceRecoding_` value. - At the same time, the `stopTracing()` call that will invalidate `traceRecording_` could happen on inspector thread. This is a pre-requisite for a better threading model, since we are going to be doing much frequent write operations from the Host side to record frame timings or screenshots. Differential Revision: D86205686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Introduces a TracingDelegate that will receive tracing-related events on the Host side.
We can't give synchronous access to tracing state to Host directly, since there is no guarantee that this call will happen on the inspector thread.
Example:
HostTarget::tracingState()call may happen on UI thread, or whatever thread the Host is using, which readstraceRecoding_value.stopTracing()call that will invalidatetraceRecording_could happen on inspector thread.This is a pre-requisite for a better threading model, since we are going to be doing much frequent write operations from the Host side to record frame timings or screenshots.
Differential Revision: D86205686