[autodeps] Support namespaces

Summary: Summary: Correctly supports React.useEffect when React is imported as `import * as React from 'react'`
(as well as other namespaces as specified in the config).

Test Plan:

Author: jbrown215

compiler/packages/babel-plugin-react-compiler/src/Inference/InferEffectDependencies.ts

@@ -49,6 +49,7 @@ export function inferEffectDependencies(fn: HIRFunction): void {
     );
   }
   const autodepFnLoads = new Map<IdentifierId, number>();
+  const autodepModuleLoads = new Map<IdentifierId, Map<string, number>>();
 
   const scopeInfos = new Map<
     ScopeId,
@@ -89,9 +90,32 @@ export function inferEffectDependencies(fn: HIRFunction): void {
           lvalue.identifier.id,
           instr as TInstruction<FunctionExpression>,
         );
+      } else if (
+        value.kind === 'PropertyLoad' &&
+        autodepModuleLoads.has(value.object.identifier.id)
+      ) {
+        const moduleTargets = autodepModuleLoads.get(
+          value.object.identifier.id,
+        )!;
+        const propertyName = value.property;
+        const numRequiredArgs = moduleTargets.get(propertyName);
+        if (numRequiredArgs != null) {
+          autodepFnLoads.set(lvalue.identifier.id, numRequiredArgs);
+        }
       } else if (value.kind === 'LoadGlobal') {
         loadGlobals.add(lvalue.identifier.id);
 
+        /*
+         * TODO: Handle properties on default exports, like
+         * import React from 'react';
+         * React.useEffect(...);
+         */
+        if (value.binding.kind === 'ImportNamespace') {
+          const moduleTargets = autodepFnConfigs.get(value.binding.module);
+          if (moduleTargets != null) {
+            autodepModuleLoads.set(lvalue.identifier.id, moduleTargets);
+          }
+        }
         if (
           value.binding.kind === 'ImportSpecifier' ||
           value.binding.kind === 'ImportDefault'
@@ -109,12 +133,14 @@ export function inferEffectDependencies(fn: HIRFunction): void {
           }
         }
       } else if (
-        /*
-         * TODO: Handle method calls
-         */
-        value.kind === 'CallExpression' &&
-        autodepFnLoads.get(value.callee.identifier.id) === value.args.length &&
-        value.args[0].kind === 'Identifier'
+        (value.kind === 'CallExpression' &&
+          autodepFnLoads.get(value.callee.identifier.id) ===
+            value.args.length &&
+          value.args[0].kind === 'Identifier') ||
+        (value.kind === 'MethodCall' &&
+          autodepFnLoads.get(value.property.identifier.id) ===
+            value.args.length &&
+          value.args[0].kind === 'Identifier')
       ) {
         const effectDeps: Array<Place> = [];
         const newInstructions: Array<Instruction> = [];

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies/import-namespace-useEffect.expect.md

@@ -0,0 +1,59 @@
+
+## Input
+
+```javascript
+// @inferEffectDependencies
+import * as React from 'react';
+import * as SharedRuntime from 'shared-runtime';
+
+function NonReactiveDepInEffect() {
+  const obj = makeObject_Primitives();
+  React.useEffect(() => print(obj));
+  SharedRuntime.useSpecialEffect(() => print(obj), [obj]);
+}
+
+```
+
+## Code
+
+```javascript
+import { c as _c } from "react/compiler-runtime"; // @inferEffectDependencies
+import * as React from "react";
+import * as SharedRuntime from "shared-runtime";
+
+function NonReactiveDepInEffect() {
+  const $ = _c(4);
+  let t0;
+  if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
+    t0 = makeObject_Primitives();
+    $[0] = t0;
+  } else {
+    t0 = $[0];
+  }
+  const obj = t0;
+  let t1;
+  if ($[1] === Symbol.for("react.memo_cache_sentinel")) {
+    t1 = () => print(obj);
+    $[1] = t1;
+  } else {
+    t1 = $[1];
+  }
+  React.useEffect(t1, [obj]);
+  let t2;
+  let t3;
+  if ($[2] === Symbol.for("react.memo_cache_sentinel")) {
+    t2 = () => print(obj);
+    t3 = [obj];
+    $[2] = t2;
+    $[3] = t3;
+  } else {
+    t2 = $[2];
+    t3 = $[3];
+  }
+  SharedRuntime.useSpecialEffect(t2, t3, [obj]);
+}
+
+```
+      
+### Eval output
+(kind: exception) Fixture not implemented

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies/import-namespace-useEffect.js

@@ -0,0 +1,9 @@
+// @inferEffectDependencies
+import * as React from 'react';
+import * as SharedRuntime from 'shared-runtime';
+
+function NonReactiveDepInEffect() {
+  const obj = makeObject_Primitives();
+  React.useEffect(() => print(obj));
+  SharedRuntime.useSpecialEffect(() => print(obj), [obj]);
+}

…odo-import-namespace-useEffect.expect.md …ort-default-property-useEffect.expect.mdcompiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies/todo-import-namespace-useEffect.expect.md renamed to compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies/todo.import-default-property-useEffect.expect.md compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies/todo-import-namespace-useEffect.expect.md renamed to compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies/todo.import-default-property-useEffect.expect.md

@@ -3,11 +3,8 @@
 
 ```javascript
 // @inferEffectDependencies
-import * as React from 'react';
+import React from 'react';
 
-/**
- * TODO: recognize import namespace
- */
 function NonReactiveDepInEffect() {
   const obj = makeObject_Primitives();
   React.useEffect(() => print(obj));
@@ -19,11 +16,8 @@ function NonReactiveDepInEffect() {
 
 ```javascript
 import { c as _c } from "react/compiler-runtime"; // @inferEffectDependencies
-import * as React from "react";
+import React from "react";
 
-/**
- * TODO: recognize import namespace
- */
 function NonReactiveDepInEffect() {
   const $ = _c(2);
   let t0;

…ncies/todo-import-namespace-useEffect.js …odo.import-default-property-useEffect.jscompiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies/todo-import-namespace-useEffect.js renamed to compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies/todo.import-default-property-useEffect.js compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies/todo-import-namespace-useEffect.js renamed to compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies/todo.import-default-property-useEffect.js

@@ -1,9 +1,6 @@
 // @inferEffectDependencies
-import * as React from 'react';
+import React from 'react';
 
-/**
- * TODO: recognize import namespace
- */
 function NonReactiveDepInEffect() {
   const obj = makeObject_Primitives();
   React.useEffect(() => print(obj));