Adjust tests that were using string refs for something else

Author: eps1lon

packages/react/src/__tests__/ReactElementJSX-test.js

@@ -221,7 +221,7 @@ describe('ReactElement.jsx', () => {
     class Parent extends React.Component {
       render() {
         return JSXRuntime.jsx('div', {
-          children: JSXRuntime.jsx(Child, {ref: 'childElement'}),
+          children: JSXRuntime.jsx(Child, {ref: React.createRef()}),
         });
       }
     }

packages/react/src/__tests__/ReactJSXElement-test.js

@@ -78,18 +78,11 @@ describe('ReactJSXElement', () => {
   });
 
   it('extracts key and ref from the rest of the props', () => {
-    const element = (
-      <Component
-        key="12"
-        ref={current => {
-          this.refs['34'] = current;
-        }}
-        foo="56"
-      />
-    );
+    const ref = React.createRef();
+    const element = <Component key="12" ref={ref} foo="56" />;
     expect(element.type).toBe(Component);
     expect(element.key).toBe('12');
-    expect(element.ref).toBe('34');
+    expect(element.ref).toBe(ref);
     const expectation = {foo: '56'};
     Object.freeze(expectation);
     expect(element.props).toEqual(expectation);

packages/react/src/__tests__/ReactProfilerDevToolsIntegration-test.internal.js

@@ -101,6 +101,8 @@ describe('ReactProfiler DevTools integration', () => {
     );
   });
 
+  // FIXME: What would throw in a host root apart from string refs without owner?
+  // @gate !warnAboutStringRefs
   it('should reset the fiber stack correctly after an error when profiling host roots', () => {
     Scheduler.unstable_advanceTime(20);
 
@@ -114,10 +116,7 @@ describe('ReactProfiler DevTools integration', () => {
 
     expect(() => {
       rendered.update(
-        <div
-          ref={current => {
-            this.refs['this-will-cause-an-error'] = current;
-          }}>
+        <div ref="this-will-cause-an-error">
           <AdvanceTime byAmount={3} />
         </div>,
       );