[compiler] Prevent innaccurate derivation recording on FunctionExpressions on no-derived-computation-in-effects (#35173)

Summary:
The operands of a function expression are the elements passed as
context. This means that it doesn't make sense to record mutations for
them.

The relevant mutations will happen in the function body, so we need to
prevent FunctionExpression type instruction from running the logic for
effect mutations.

This was also causing some values to depend on themselves in some cases
triggering an infinite loop. Also added n invariant to prevent this
issue

Test Plan:
Added fixture test

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35173).
* #35174
* __->__ #35173

DiffTrain build for [7ee974d](7ee974d)

Author: jorge-cab

compiled/eslint-plugin-react-hooks/index.js

@@ -52496,6 +52496,7 @@ function validateEffect$1(effectFunction, effectDeps, errors) {
     }
 }
 
+const MAX_FIXPOINT_ITERATIONS = 100;
 class DerivationCache {
     constructor() {
         this.hasChanges = false;
@@ -52615,6 +52616,7 @@ function validateNoDerivedComputationsInEffects_exp(fn) {
             });
         }
     }
+    let iterationCount = 0;
     do {
         context.derivationCache.takeSnapshot();
         for (const block of fn.body.blocks.values()) {
@@ -52624,6 +52626,18 @@ function validateNoDerivedComputationsInEffects_exp(fn) {
             }
         }
         context.derivationCache.checkForChanges();
+        iterationCount++;
+        CompilerError.invariant(iterationCount < MAX_FIXPOINT_ITERATIONS, {
+            reason: '[ValidateNoDerivedComputationsInEffects] Fixpoint iteration failed to converge.',
+            description: `Fixpoint iteration exceeded ${MAX_FIXPOINT_ITERATIONS} iterations while tracking derivations. This suggests a cyclic dependency in the derivation cache.`,
+            details: [
+                {
+                    kind: 'error',
+                    loc: fn.loc,
+                    message: `Exceeded ${MAX_FIXPOINT_ITERATIONS} iterations in ValidateNoDerivedComputationsInEffects`,
+                },
+            ],
+        });
     } while (context.derivationCache.snapshot());
     for (const [, effect] of effectsCache) {
         validateEffect(effect.effect, effect.dependencies, context);
@@ -52747,6 +52761,9 @@ function recordInstructionDerivations(instr, context, isFirstPass) {
     for (const lvalue of eachInstructionLValue(instr)) {
         context.derivationCache.addDerivationEntry(lvalue, sources, typeOfValue, isSource);
     }
+    if (value.kind === 'FunctionExpression') {
+        return;
+    }
     for (const operand of eachInstructionOperand(instr)) {
         switch (operand.effect) {
             case Effect.Capture:
@@ -52808,6 +52825,17 @@ function buildTreeNode(sourceId, context, visited = new Set()) {
     const children = [];
     const namedSiblings = new Set();
     for (const childId of sourceMetadata.sourcesIds) {
+        CompilerError.invariant(childId !== sourceId, {
+            reason: 'Unexpected self-reference: a value should not have itself as a source',
+            description: null,
+            details: [
+                {
+                    kind: 'error',
+                    loc: sourceMetadata.place.loc,
+                    message: null,
+                },
+            ],
+        });
         const childNodes = buildTreeNode(childId, context, new Set([
             ...visited,
             ...(isNamedIdentifier(sourceMetadata.place)

compiled/facebook-www/REVISION

@@ -1 +1 @@
-8ac5f4eb3601f7381462f8b74ecf24d47259cc20
+7ee974de927e9bbe10a44441ab49bafd9f5467a2

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-8ac5f4eb3601f7381462f8b74ecf24d47259cc20
+7ee974de927e9bbe10a44441ab49bafd9f5467a2

compiled/facebook-www/React-dev.classic.js

@@ -1499,7 +1499,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.3.0-www-classic-8ac5f4eb-20251119";
+    exports.version = "19.3.0-www-classic-7ee974de-20251120";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

@@ -1499,7 +1499,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.3.0-www-modern-8ac5f4eb-20251119";
+    exports.version = "19.3.0-www-modern-7ee974de-20251120";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

@@ -606,4 +606,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-classic-8ac5f4eb-20251119";
+exports.version = "19.3.0-www-classic-7ee974de-20251120";

compiled/facebook-www/React-prod.modern.js

@@ -606,4 +606,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-modern-8ac5f4eb-20251119";
+exports.version = "19.3.0-www-modern-7ee974de-20251120";

compiled/facebook-www/React-profiling.classic.js

@@ -610,7 +610,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-classic-8ac5f4eb-20251119";
+exports.version = "19.3.0-www-classic-7ee974de-20251120";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

@@ -610,7 +610,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-modern-8ac5f4eb-20251119";
+exports.version = "19.3.0-www-modern-7ee974de-20251120";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

@@ -20468,10 +20468,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.3.0-www-classic-8ac5f4eb-20251119",
+        version: "19.3.0-www-classic-7ee974de-20251120",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.3.0-www-classic-8ac5f4eb-20251119"
+        reconcilerVersion: "19.3.0-www-classic-7ee974de-20251120"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20506,7 +20506,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.3.0-www-classic-8ac5f4eb-20251119";
+    exports.version = "19.3.0-www-classic-7ee974de-20251120";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&