Skip to content

Commit 93e989a

Browse files
committed
[compiler]: add @tanstack/react-virtual to known incompatible libraries (#34493)
Replaces #31820. #34027 added a check for `@tanstack/react-table`, but not `@tanstack/react-virtual`. In our testing `@tanstack/react-virtual`'s `useVirtualizer` returns functions that cannot be memoized, [this is also documented in the community](TanStack/virtual#736 (comment)). DiffTrain build for [e12b0bd](e12b0bd)
1 parent c7fa978 commit 93e989a

35 files changed

+100
-86
lines changed

compiled/eslint-plugin-react-hooks/index.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32051,6 +32051,20 @@ function defaultModuleTypeProvider(moduleName) {
3205132051
},
3205232052
};
3205332053
}
32054+
case '@tanstack/react-virtual': {
32055+
return {
32056+
kind: 'object',
32057+
properties: {
32058+
useVirtualizer: {
32059+
kind: 'hook',
32060+
positionalParams: [],
32061+
restParam: Effect.Read,
32062+
returnType: { kind: 'type', name: 'Any' },
32063+
knownIncompatible: `TanStack Virtual's \`useVirtualizer()\` API returns functions that cannot be memoized safely`,
32064+
},
32065+
},
32066+
};
32067+
}
3205432068
}
3205532069
return null;
3205632070
}

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
68f00c901c05e3a91f6cc77b660bc2334700f163
1+
e12b0bdc3b976cc2431ccf30126cf339be83720c
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
68f00c901c05e3a91f6cc77b660bc2334700f163
1+
e12b0bdc3b976cc2431ccf30126cf339be83720c

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1419,7 +1419,7 @@ __DEV__ &&
14191419
exports.useTransition = function () {
14201420
return resolveDispatcher().useTransition();
14211421
};
1422-
exports.version = "19.2.0-www-classic-68f00c90-20250912";
1422+
exports.version = "19.2.0-www-classic-e12b0bdc-20250915";
14231423
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14241424
"function" ===
14251425
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1419,7 +1419,7 @@ __DEV__ &&
14191419
exports.useTransition = function () {
14201420
return resolveDispatcher().useTransition();
14211421
};
1422-
exports.version = "19.2.0-www-modern-68f00c90-20250912";
1422+
exports.version = "19.2.0-www-modern-e12b0bdc-20250915";
14231423
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14241424
"function" ===
14251425
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,4 +602,4 @@ exports.useSyncExternalStore = function (
602602
exports.useTransition = function () {
603603
return ReactSharedInternals.H.useTransition();
604604
};
605-
exports.version = "19.2.0-www-classic-68f00c90-20250912";
605+
exports.version = "19.2.0-www-classic-e12b0bdc-20250915";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,4 +602,4 @@ exports.useSyncExternalStore = function (
602602
exports.useTransition = function () {
603603
return ReactSharedInternals.H.useTransition();
604604
};
605-
exports.version = "19.2.0-www-modern-68f00c90-20250912";
605+
exports.version = "19.2.0-www-modern-e12b0bdc-20250915";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ exports.useSyncExternalStore = function (
606606
exports.useTransition = function () {
607607
return ReactSharedInternals.H.useTransition();
608608
};
609-
exports.version = "19.2.0-www-classic-68f00c90-20250912";
609+
exports.version = "19.2.0-www-classic-e12b0bdc-20250915";
610610
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
611611
"function" ===
612612
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ exports.useSyncExternalStore = function (
606606
exports.useTransition = function () {
607607
return ReactSharedInternals.H.useTransition();
608608
};
609-
exports.version = "19.2.0-www-modern-68f00c90-20250912";
609+
exports.version = "19.2.0-www-modern-e12b0bdc-20250915";
610610
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
611611
"function" ===
612612
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19754,10 +19754,10 @@ __DEV__ &&
1975419754
(function () {
1975519755
var internals = {
1975619756
bundleType: 1,
19757-
version: "19.2.0-www-classic-68f00c90-20250912",
19757+
version: "19.2.0-www-classic-e12b0bdc-20250915",
1975819758
rendererPackageName: "react-art",
1975919759
currentDispatcherRef: ReactSharedInternals,
19760-
reconcilerVersion: "19.2.0-www-classic-68f00c90-20250912"
19760+
reconcilerVersion: "19.2.0-www-classic-e12b0bdc-20250915"
1976119761
};
1976219762
internals.overrideHookState = overrideHookState;
1976319763
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19791,7 +19791,7 @@ __DEV__ &&
1979119791
exports.Shape = Shape;
1979219792
exports.Surface = Surface;
1979319793
exports.Text = Text;
19794-
exports.version = "19.2.0-www-classic-68f00c90-20250912";
19794+
exports.version = "19.2.0-www-classic-e12b0bdc-20250915";
1979519795
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1979619796
"function" ===
1979719797
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)