Skip to content

Commit fb58997

Browse files
committed
[DevTools] Don't attempt to draw bounding box if inspected element is not a Suspense
1 parent 5a9921b commit fb58997

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

packages/react-devtools-shared/src/devtools/store.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -669,6 +669,10 @@ export default class Store extends EventEmitter<{
669669
return element;
670670
}
671671

672+
containsSuspense(id: SuspenseNode['id']): boolean {
673+
return this._idToSuspense.has(id);
674+
}
675+
672676
getSuspenseByID(id: SuspenseNode['id']): SuspenseNode | null {
673677
const suspense = this._idToSuspense.get(id);
674678
if (suspense === undefined) {

packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseRects.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,11 @@ function SuspenseRectsContainer({
512512
if (isRootSelected) {
513513
selectedBoundingBox = boundingBox;
514514
selectedEnvironment = rootEnvironment;
515-
} else if (inspectedElementID !== null) {
515+
} else if (
516+
inspectedElementID !== null &&
517+
// TODO: Separate inspected element and inspected Suspense and use the inspected Suspense ID here.
518+
store.containsSuspense(inspectedElementID)
519+
) {
516520
const selectedSuspenseNode = store.getSuspenseByID(inspectedElementID);
517521
if (
518522
selectedSuspenseNode !== null &&

0 commit comments

Comments
 (0)