Fix incremental build missing mutation field return type changes

Reviewed By: evanyeung

Differential Revision: D97396237

fbshipit-source-id: a810c53cc55e695df0677b3fdb108d9bb328f90e

Author: tyao1

compiler/crates/dependency-analyzer/src/schema_change_analyzer.rs

@@ -257,6 +257,11 @@ impl Visitor for SchemaChangeDefinitionFinder<'_, '_> {
     const VISIT_ARGUMENTS: bool = true;
     const VISIT_DIRECTIVES: bool = true;
 
+    fn visit_operation(&mut self, operation: &OperationDefinition) {
+        self.add_type_changes(operation.type_);
+        self.default_visit_operation(operation);
+    }
+
     fn visit_linked_field(&mut self, field: &LinkedField) {
         let id = field.definition.item;
         let type_ = self.schema.field(id).type_.inner();

compiler/crates/relay-compiler/tests/relay_compiler_integration/fixtures/incremental_mutation_field_return_type_change.expected

@@ -0,0 +1,150 @@
+==================================== INPUT ====================================
+# When a mutation field's return type changes (e.g. from PayloadA to PayloadB),
+# the incremental build must regenerate the mutation artifact so the
+# concreteType in the normalization AST reflects the new return type.
+# This is a regression test for a bug where changing Mutation's field return
+# type was classified as ObjectChanged("Mutation"), but the
+# SchemaChangeDefinitionFinder only checked child return types — not the
+# operation's root type — so no definitions were marked as affected.
+
+//- foo.js
+graphql`
+  mutation fooMutation($input: CreateInput!) {
+    createThing(input: $input) {
+      success
+      message
+    }
+  }
+`
+
+//- relay.config.json
+{
+   "language": "typescript",
+   "schema": "./schema.graphql"
+}
+
+//- schema.graphql
+type Query { me: User }
+type User { name: String }
+type Mutation { createThing(input: CreateInput!): PayloadA }
+input CreateInput { key: String }
+type PayloadA { success: Boolean, message: String }
+type PayloadB { success: Boolean, message: String }
+
+//-++ schema.graphql
+type Query { me: User }
+type User { name: String }
+type Mutation { createThing(input: CreateInput!): PayloadB }
+input CreateInput { key: String }
+type PayloadA { success: Boolean, message: String }
+type PayloadB { success: Boolean, message: String }
+==================================== OUTPUT ===================================
+//-++ __generated__/fooMutation.graphql.ts
+/**
+ * <auto-generated> SignedSource<<09380048fd372e3b07708ff0e06cb1e9>>
+ * @lightSyntaxTransform
+ * @nogrep
+ */
+
+/* tslint:disable */
+/* eslint-disable */
+// @ts-nocheck
+
+import { ConcreteRequest } from 'relay-runtime';
+export type CreateInput = {
+  key?: string | null | undefined;
+};
+export type fooMutation$variables = {
+  input: CreateInput;
+};
+export type fooMutation$data = {
+  readonly createThing: {
+    readonly message: string | null | undefined;
+    readonly success: boolean | null | undefined;
+  } | null | undefined;
+};
+export type fooMutation = {
+  response: fooMutation$data;
+  variables: fooMutation$variables;
+};
+
+const node: ConcreteRequest = (function(){
+var v0 = [
+  {
+    "defaultValue": null,
+    "kind": "LocalArgument",
+    "name": "input"
+  }
+],
+v1 = [
+  {
+    "alias": null,
+    "args": [
+      {
+        "kind": "Variable",
+        "name": "input",
+        "variableName": "input"
+      }
+    ],
+    "concreteType": "PayloadB",
+    "kind": "LinkedField",
+    "name": "createThing",
+    "plural": false,
+    "selections": [
+      {
+        "alias": null,
+        "args": null,
+        "kind": "ScalarField",
+        "name": "success",
+        "storageKey": null
+      },
+      {
+        "alias": null,
+        "args": null,
+        "kind": "ScalarField",
+        "name": "message",
+        "storageKey": null
+      }
+    ],
+    "storageKey": null
+  }
+];
+return {
+  "fragment": {
+    "argumentDefinitions": (v0/*:: as any*/),
+    "kind": "Fragment",
+    "metadata": null,
+    "name": "fooMutation",
+    "selections": (v1/*:: as any*/),
+    "type": "Mutation",
+    "abstractKey": null
+  },
+  "kind": "Request",
+  "operation": {
+    "argumentDefinitions": (v0/*:: as any*/),
+    "kind": "Operation",
+    "name": "fooMutation",
+    "selections": (v1/*:: as any*/)
+  },
+  "params": {
+    "cacheID": "9ec2b5d3d80ddd1645b646b3d3e38cde",
+    "id": null,
+    "metadata": {},
+    "name": "fooMutation",
+    "operationKind": "mutation",
+    "text": "mutation fooMutation(\n  $input: CreateInput!\n) {\n  createThing(input: $input) {\n    success\n    message\n  }\n}\n"
+  }
+};
+})();
+
+(node as any).hash = "ac2677409f018dbc54fdbd5df32c78cc";
+
+export default node;
+
+
+
+Artifact Map:
+Project: default
+  Type: Mapping
+  - Source: ExecutableDefinition: fooMutation
+    Path: __generated__/fooMutation.graphql.ts

compiler/crates/relay-compiler/tests/relay_compiler_integration/fixtures/incremental_mutation_field_return_type_change.input

@@ -0,0 +1,39 @@
+# When a mutation field's return type changes (e.g. from PayloadA to PayloadB),
+# the incremental build must regenerate the mutation artifact so the
+# concreteType in the normalization AST reflects the new return type.
+# This is a regression test for a bug where changing Mutation's field return
+# type was classified as ObjectChanged("Mutation"), but the
+# SchemaChangeDefinitionFinder only checked child return types — not the
+# operation's root type — so no definitions were marked as affected.
+
+//- foo.js
+graphql`
+  mutation fooMutation($input: CreateInput!) {
+    createThing(input: $input) {
+      success
+      message
+    }
+  }
+`
+
+//- relay.config.json
+{
+   "language": "typescript",
+   "schema": "./schema.graphql"
+}
+
+//- schema.graphql
+type Query { me: User }
+type User { name: String }
+type Mutation { createThing(input: CreateInput!): PayloadA }
+input CreateInput { key: String }
+type PayloadA { success: Boolean, message: String }
+type PayloadB { success: Boolean, message: String }
+
+//-++ schema.graphql
+type Query { me: User }
+type User { name: String }
+type Mutation { createThing(input: CreateInput!): PayloadB }
+input CreateInput { key: String }
+type PayloadA { success: Boolean, message: String }
+type PayloadB { success: Boolean, message: String }

compiler/crates/relay-compiler/tests/relay_compiler_integration_test.rs

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<ecd8eb6892f4e4f149adb77cb2b3ef0a>>
+ * @generated SignedSource<<ec420c2ce9c33bcedd2ab80b8b83f4a3>>
  */
 
 mod relay_compiler_integration;
@@ -250,6 +250,13 @@ async fn incremental_input_object_removed() {
     test_fixture(transform_fixture, file!(), "incremental_input_object_removed.input", "relay_compiler_integration/fixtures/incremental_input_object_removed.expected", input, expected).await;
 }
 
+#[tokio::test]
+async fn incremental_mutation_field_return_type_change() {
+    let input = include_str!("relay_compiler_integration/fixtures/incremental_mutation_field_return_type_change.input");
+    let expected = include_str!("relay_compiler_integration/fixtures/incremental_mutation_field_return_type_change.expected");
+    test_fixture(transform_fixture, file!(), "incremental_mutation_field_return_type_change.input", "relay_compiler_integration/fixtures/incremental_mutation_field_return_type_change.expected", input, expected).await;
+}
+
 #[tokio::test]
 async fn incremental_object_added_with_interface() {
     let input = include_str!("relay_compiler_integration/fixtures/incremental_object_added_with_interface.input");