Cleanup ENABLE_SHALLOW_FREEZE_RESOLVER_VALUES

Reviewed By: voideanvalue

Differential Revision: D53030189

fbshipit-source-id: cf006c7dd4c71b17fa99eb3ff33bea2a4c1d6c8e

Author: tyao1

packages/relay-runtime/store/ResolverCache.js

@@ -26,7 +26,6 @@ import type {
 
 const recycleNodesInto = require('../util/recycleNodesInto');
 const {RELAY_LIVE_RESOLVER} = require('../util/RelayConcreteNode');
-const RelayFeatureFlags = require('../util/RelayFeatureFlags');
 const shallowFreeze = require('../util/shallowFreeze');
 const {generateClientID} = require('./ClientID');
 const RelayModernRecord = require('./RelayModernRecord');
@@ -174,9 +173,7 @@ class RecordResolverCache implements ResolverCache {
       linkedRecord = RelayModernRecord.create(linkedID, '__RELAY_RESOLVER__');
 
       const evaluationResult = evaluate();
-      if (RelayFeatureFlags.ENABLE_SHALLOW_FREEZE_RESOLVER_VALUES) {
-        shallowFreeze(evaluationResult.resolverResult);
-      }
+      shallowFreeze(evaluationResult.resolverResult);
       RelayModernRecord.setValue(
         linkedRecord,
         RELAY_RESOLVER_VALUE_KEY,

packages/relay-runtime/store/experimental-live-resolvers/LiveResolverCache.js

@@ -36,7 +36,6 @@ import type {LiveState} from 'relay-runtime';
 
 const recycleNodesInto = require('../../util/recycleNodesInto');
 const {RELAY_LIVE_RESOLVER} = require('../../util/RelayConcreteNode');
-const RelayFeatureFlags = require('../../util/RelayFeatureFlags');
 const shallowFreeze = require('../../util/shallowFreeze');
 const {generateClientID, generateClientObjectClientID} = require('../ClientID');
 const RelayModernRecord = require('../RelayModernRecord');
@@ -610,18 +609,14 @@ class LiveResolverCache implements ResolverCache {
         nextOutputTypeRecordIDs,
       );
 
-      if (RelayFeatureFlags.ENABLE_SHALLOW_FREEZE_RESOLVER_VALUES) {
-        shallowFreeze(resolverValue);
-      }
+      shallowFreeze(resolverValue);
       RelayModernRecord.setValue(
         resolverRecord,
         RELAY_RESOLVER_VALUE_KEY,
         resolverValue,
       );
     } else {
-      if (RelayFeatureFlags.ENABLE_SHALLOW_FREEZE_RESOLVER_VALUES) {
-        shallowFreeze(value);
-      }
+      shallowFreeze(value);
       // For "classic" resolvers (or if the value is nullish), we are just setting their
       // value as is.
       RelayModernRecord.setValue(

packages/relay-runtime/util/RelayFeatureFlags.js

@@ -28,7 +28,6 @@ export type FeatureFlags = {
   STRING_INTERN_LEVEL: number,
   LOG_MISSING_RECORDS_IN_PROD: boolean,
   ENABLE_RELAY_OPERATION_TRACKER_SUSPENSE: boolean,
-  ENABLE_SHALLOW_FREEZE_RESOLVER_VALUES: boolean,
 
   // Configure RelayStoreSubscriptions to mark a subscription as affected by an
   // update if there are any overlapping IDs other than ROOT_ID or VIWER_ID,
@@ -69,7 +68,6 @@ const RelayFeatureFlags: FeatureFlags = {
   ENABLE_FIELD_ERROR_HANDLING: false,
   ENABLE_FIELD_ERROR_HANDLING_THROW_BY_DEFAULT: false,
   ENABLE_FIELD_ERROR_HANDLING_CATCH_DIRECTIVE: false,
-  ENABLE_SHALLOW_FREEZE_RESOLVER_VALUES: true,
 };
 
 module.exports = RelayFeatureFlags;