Disable @weak interface implementation validate if feature flag enabled

Reviewed By: tyao1

Differential Revision: D53070318

fbshipit-source-id: 7765dcfeedcbba5e79bc452633e7d13c0189c216

Author: captbaritone

compiler/crates/relay-compiler/src/docblocks.rs

@@ -85,6 +85,9 @@ fn parse_source(
             allow_legacy_verbose_syntax: &project_config
                 .feature_flags
                 .relay_resolvers_allow_legacy_verbose_syntax,
+            enable_interface_output_type: &project_config
+                .feature_flags
+                .relay_resolver_enable_interface_output_type,
         },
     )?;
     maybe_ir

compiler/crates/relay-compiler/tests/relay_compiler_integration/fixtures/resolver_returns_interface_of_all_weak_model_type.expected

@@ -56,18 +56,9 @@ interface IPerson {
   name: String
 }
 ==================================== OUTPUT ===================================
-✖︎ The compiler attempted to parse "Admin implements IPerson" as a GraphQL type (e.g. `Viewer` or `User`), but had unparsed characters remaining. Try removing everything after "Admin".
+✖︎ No types implement the client interface IPerson. Interfaces returned by a @RelayResolver must have at least one concrete implementation.
 
-  AdminTypeResolvers.js:2:19
-    1 │ *
-    2 │  * @RelayResolver Admin implements IPerson
-      │                   ^^^^^^^^^^^^^^^^^^^^^^^^
-    3 │  * @weak
-
-✖︎ The compiler attempted to parse "User implements IPerson" as a GraphQL type (e.g. `Viewer` or `User`), but had unparsed characters remaining. Try removing everything after "User".
-
-  UserTypeResolvers.js:2:19
-    1 │ *
-    2 │  * @RelayResolver User implements IPerson
-      │                   ^^^^^^^^^^^^^^^^^^^^^^^
-    3 │  * @weak
+  schema-extensions/extension.graphql:1:11
+    1 │ interface IPerson {
+      │           ^^^^^^^
+    2 │   name: String

compiler/crates/relay-docblock/src/docblock_ir.rs

@@ -159,6 +159,7 @@ pub(crate) fn parse_docblock_ir(
                         populated_ir_field,
                         weak_field,
                         source_hash,
+                        parse_options,
                     )?),
                     None => DocblockIr::StrongObjectResolver(parse_strong_object_ir(
                         project_name,
@@ -300,9 +301,17 @@ fn parse_weak_object_ir(
     relay_resolver_field: PopulatedIrField,
     _weak_field: UnpopulatedIrField,
     source_hash: ResolverSourceHash,
+    parse_options: &ParseOptions<'_>,
 ) -> DiagnosticsResult<WeakObjectIr> {
     // Validate that the right hand side of the @RelayResolver field is a valid identifier
-    let identifier = assert_only_identifier(relay_resolver_field)?;
+    let identifier = if parse_options
+        .enable_interface_output_type
+        .is_fully_enabled()
+    {
+        extract_identifier(relay_resolver_field)?
+    } else {
+        assert_only_identifier(relay_resolver_field)?
+    };
 
     Ok(WeakObjectIr {
         type_name: identifier,

compiler/crates/relay-docblock/src/lib.rs

@@ -41,6 +41,7 @@ pub struct ParseOptions<'a> {
     pub enable_output_type: &'a FeatureFlag,
     pub enable_strict_resolver_flavors: &'a FeatureFlag,
     pub allow_legacy_verbose_syntax: &'a FeatureFlag,
+    pub enable_interface_output_type: &'a FeatureFlag,
 }
 
 pub fn parse_docblock_ast(

compiler/crates/relay-docblock/tests/parse/fixtures/relay-resolver-weak-object-with-implements.expected

@@ -0,0 +1,35 @@
+==================================== INPUT ====================================
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+// relay:enable_interface_output_type
+
+/**
+ * @RelayResolver ClientUser implements Foo
+ * @weak
+ */
+==================================== OUTPUT ===================================
+WeakObjectType(
+    WeakObjectIr {
+        type_name: Identifier {
+            span: 20:30,
+            token: Token {
+                span: 20:30,
+                kind: Identifier,
+            },
+            value: "ClientUser",
+        },
+        rhs_location: /path/to/test/fixture/relay-resolver-weak-object-with-implements.js:20:45,
+        description: None,
+        hack_source: None,
+        deprecated: None,
+        location: /path/to/test/fixture/relay-resolver-weak-object-with-implements.js:0:55,
+        source_hash: ResolverSourceHash(
+            "26ae5e285958dda3877b78aaf5a82b65",
+        ),
+    },
+)

compiler/crates/relay-docblock/tests/parse/fixtures/relay-resolver-weak-object-with-implements.js

@@ -0,0 +1,13 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+// relay:enable_interface_output_type
+
+/**
+ * @RelayResolver ClientUser implements Foo
+ * @weak
+ */

compiler/crates/relay-docblock/tests/parse/mod.rs

@@ -87,6 +87,14 @@ pub async fn transform_fixture(fixture: &Fixture<'_>) -> Result<String, String>
                             } else {
                                 &FeatureFlag::Disabled
                             },
+                            enable_interface_output_type: if fixture
+                                .content
+                                .contains("// relay:enable_interface_output_type")
+                            {
+                                &FeatureFlag::Enabled
+                            } else {
+                                &FeatureFlag::Disabled
+                            },
                         },
                     )
                 })

compiler/crates/relay-docblock/tests/parse_test.rs

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<c9768c7dbf870b21e26aa508af34c942>>
+ * @generated SignedSource<<0d097e7d292511eaacec9df447a793d7>>
  */
 
 mod parse;
@@ -194,6 +194,13 @@ async fn relay_resolver_weak_object_with_gibberish_invalid() {
     test_fixture(transform_fixture, file!(), "relay-resolver-weak-object-with-gibberish.invalid.js", "parse/fixtures/relay-resolver-weak-object-with-gibberish.invalid.expected", input, expected).await;
 }
 
+#[tokio::test]
+async fn relay_resolver_weak_object_with_implements() {
+    let input = include_str!("parse/fixtures/relay-resolver-weak-object-with-implements.js");
+    let expected = include_str!("parse/fixtures/relay-resolver-weak-object-with-implements.expected");
+    test_fixture(transform_fixture, file!(), "relay-resolver-weak-object-with-implements.js", "parse/fixtures/relay-resolver-weak-object-with-implements.expected", input, expected).await;
+}
+
 #[tokio::test]
 async fn relay_resolver_with_args() {
     let input = include_str!("parse/fixtures/relay-resolver-with-args.js");

compiler/crates/relay-docblock/tests/to_schema/mod.rs

@@ -89,6 +89,14 @@ pub async fn transform_fixture(fixture: &Fixture<'_>) -> Result<String, String>
                 } else {
                     &FeatureFlag::Disabled
                 },
+                enable_interface_output_type: if fixture
+                    .content
+                    .contains("// relay:enable_interface_output_type")
+                {
+                    &FeatureFlag::Enabled
+                } else {
+                    &FeatureFlag::Disabled
+                },
             },
         )?
         .unwrap();

compiler/crates/relay-lsp/src/server/lsp_state.rs

@@ -306,6 +306,9 @@ impl<TPerfLogger: PerfLogger + 'static, TSchemaDocumentation: SchemaDocumentatio
                         allow_legacy_verbose_syntax: &project_config
                             .feature_flags
                             .relay_resolvers_allow_legacy_verbose_syntax,
+                        enable_interface_output_type: &project_config
+                            .feature_flags
+                            .relay_resolver_enable_interface_output_type,
                     },
                 )
             });