Skip to content

Commit 0ebed3c

Browse files
Jack Huangfacebook-github-bot
authored andcommitted
enabled inline comments with no code suggestions to be shown
Summary: **Context**: explained by the title **Solution**: With code suggestion, we get commit hash from CodePatch so that we can compare code in editor with the commit code. We do this to realigned the line number in case of code change in vscode editor. For entities without codepatch, we have to fetch the commit hash via 'changeset' in comment's data. Hence the added graphql. **PS.** In the next diff I will add in the ability to resolve a comment, so user can resolve and disband comments without codepatch. Differential Revision: D67951639 fbshipit-source-id: c45be6a747653bab3707e1fde1c117015e3396ea
1 parent bbb7436 commit 0ebed3c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

addons/isl/src/types.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,15 +146,14 @@ export type DiffComment = {
146146
html: string;
147147
content?: string;
148148
created: Date;
149+
commitHash?: string;
149150
/** If it's an inline comment, this is the file path with the comment */
150151
filename?: string;
151152
/** If it's an inline comment, this is the line it was added */
152153
line?: number;
153154
reactions: Array<DiffCommentReaction>;
154155
/** Suggestion for how to change the code, as a patch */
155156
suggestedChange?: SuggestedChange;
156-
// codePatchSuggestedChange?: SuggestedChange;
157-
// signalSuggestedChange?: SuggestedChange;
158157
replies: Array<DiffComment>;
159158
/** If this comment has been resolved. true => "resolved", false => "unresolved", null => the comment is not resolvable, don't show any UI for it */
160159
isResolved?: boolean;

0 commit comments

Comments
 (0)