localrepo: reorder init steps so Rust repo is available sooner

Summary: No functional impact intended. I want to start depending more on the Rust repo object, and that requires having it be initialized earlier.

Reviewed By: sggutier

Differential Revision: D39037642

fbshipit-source-id: 8e6b9a0e2cc994394d351d27f03a8619f672b1c7

Author: Muir Manders

eden/scm/edenscm/localrepo.py

@@ -407,11 +407,23 @@ def __init__(self, baseui, path, create=False):
         if create:
             bindings.repo.repo.initialize(path, baseui._rcfg)
 
+        if not bindings.identity.sniffdir(path):
+            raise errormod.RepoError(_("repository %s not found") % path)
+
         self._containscount = 0
         self.requirements = set()
         self.storerequirements = set()
+
         # wvfs: rooted at the repository root, used to access the working copy
         self.wvfs = vfsmod.vfs(path, expandpath=True, realpath=True, cacheaudited=False)
+        self.root = self.wvfs.base
+
+        self.baseui = baseui
+        self.ui = baseui.copy()
+        self.ui.loadrepoconfig(self.root)
+
+        self._rsrepo = bindings.repo.repo(self.root, self.ui._rcfg)
+
         # localvfs: rooted at .hg, used to access repo files outside of
         # the store that are local to this working copy.
         self.localvfs = None
@@ -422,7 +434,6 @@ def __init__(self, baseui, path, create=False):
         # If this is a shared repository, this vfs may point to another
         # repository's .hg/store directory.
         self.svfs = None
-        self.root = self.wvfs.base
         self.path = self.wvfs.join(".hg")
         self.origroot = path
         # This is only used by context.workingctx.match in order to
@@ -431,8 +442,6 @@ def __init__(self, baseui, path, create=False):
         # This is only used by context.basectx.match in order to detect
         # files in forbidden paths..
         self.nofsauditor = pathutil.pathauditor(self.root, realfs=False, cached=True)
-        self.baseui = baseui
-        self.ui = baseui.copy()
         self.localvfs = vfsmod.vfs(self.path, cacheaudited=True)
         if self.ui.configbool("devel", "all-warnings") or self.ui.configbool(
             "devel", "check-locks"
@@ -444,14 +453,6 @@ def __init__(self, baseui, path, create=False):
         # This list it to be filled by extension during repo setup
         self._phasedefaults = []
 
-        if not self.localvfs.isdir():
-            raise errormod.RepoError(_("repository %s not found") % path)
-
-        self.ui.loadrepoconfig(self.root)
-
-        # Setting the inner Rust repo should only be done when the filesystem actually exists
-        self._rsrepo = bindings.repo.repo(self.root, self.ui._rcfg)
-
         self._loadextensions()
 
         cacheaudited = self.ui.configbool("unsafe", "wvfsauditorcache")

eden/scm/tests/test-clone.t

@@ -455,7 +455,7 @@ Inaccessible source
   $ mkdir a
   $ chmod 000 a
   $ hg clone a b
-  abort: repository a not found!
+  abort: Permission denied (os error 13)
   [255]
 
 Inaccessible destination

eden/scm/tests/test-pull-update.t

@@ -137,7 +137,7 @@
   $ cp -R . $TESTTMP/tt-2
   $ cd $TESTTMP/tt-2
 
-  $ hg pull -u '$TESTTMP/t#active-after-pull'
+  $ hg pull -u "$TESTTMP/t#active-after-pull"
   pulling from $TESTTMP/t
   searching for changes
   adding changesets