Commit 45255d3
Integration test demonstrating support for multiple tags with same name
Summary:
The earlier versions of `gitimport` didn't used to peel tags when trying to upload the tag contents. With that version, it was possible to have the below scenario work for gitimport but fail for Mononoke Git server:
- Create tag A point to commit C
- Created another tag with the same name A and point it to the object id of the old tag A
- gitimport the repo
The earlier version of gitimport would only import the new tag A without uploading the git object corresponding to the old tag A. On Mononoke server when performing the clone, we would try to peel the tags and return everything referenced by it only to find the inner tag missing and would error out. This actually happened in production for `whatsapp/android` repo since it was imported early last year.
In the current version of gitimport, this bug is fixed so this integration test serves as protection against regression and as a proof that we support this particular use-case
Reviewed By: markbt
Differential Revision: D75964395
fbshipit-source-id: 29835270ea9915b4cccf938fdc4881ade5fc607b1 parent 6005cdc commit 45255d3
File tree
1 file changed
+57
-0
lines changed- eden/mononoke/tests/integration/mononoke_git_server
1 file changed
+57
-0
lines changedLines changed: 57 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
0 commit comments