Skip to content

Commit 551bed0

Browse files
ViniGupta08facebook-github-bot
authored andcommitted
Minor fixes for Eden health-check
Summary: Details: 1. **Exit Code = 255 for Exceptions** We now exit with an exit code of 255 when Eden Health-Check encounters an exception during execution. This allows us to capture the exception details and print them to stdout, which can later be retrieved in VSCode for telemetry purposes. 2. **Fix Mount Parameters** We've updated the way we send mount parameters to ensure they're sent as a list of strings instead of a single string. This fix resolves any issues related to incorrect parameter formatting. 3. **Remediation Command Execution without CONNECT_HOST** In some cases, the CONNECT_HOST parameter may not correctly determine the target host for executing remediation commands. To resolve this issue, we've updated the executeCommand function to internally determine the target host, eliminating the need for the CONNECT_HOST parameter. 4. **Show Command Succeeded Notification** We've added a notification that appears after a remediation command has successfully completed its execution. This notification is displayed within the then clause to ensure users are notified only when the command has run successfully. Differential Revision: D68037504 fbshipit-source-id: 828a97e5a932d6254008fb6b2056f0aa599989f9
1 parent 82cf7fc commit 551bed0

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

eden/fs/cli/main.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1397,10 +1397,11 @@ def run(self, args: argparse.Namespace) -> int:
13971397
exit_code = 1
13981398

13991399
self.print_error_codes_json(out)
1400-
return exit_code
1401-
14021400
except Exception as ex:
1403-
raise Exception("Failed to run health report: " + str(ex))
1401+
print(f"Failed to run health report: {str(ex)}", file=sys.stderr)
1402+
exit_code = 255
1403+
1404+
return exit_code
14041405

14051406

14061407
@subcmd("strace", "Monitor FUSE requests.")

0 commit comments

Comments
 (0)