move OBC CLIENT initialization to backingstore

Summary: Move OBC API initialization to backing store. Currently, all the OBC bumps only used for scmstore counters which are all calling from Eden. Then for other sl command we don't need to initialize OBC API. This diff move the initialization to BackingStore instead of Repo

Reviewed By: jdelliot

Differential Revision: D67491615

fbshipit-source-id: 8573721bac15deccd0bbc32390a3da6ee47f5147

Author: kavehahmadi60

eden/scm/lib/backingstore/Cargo.toml

@@ -27,6 +27,7 @@ sapling-edenapi = { version = "0.1.0", path = "../edenapi" }
 sapling-identity = { version = "0.1.0", path = "../identity" }
 sapling-indexedlog = { version = "0.1.0", path = "../indexedlog", features = ["configurable"] }
 sapling-manifest = { version = "0.1.0", path = "../manifest" }
+sapling-metrics = { version = "0.1.0", path = "../metrics" }
 sapling-repo = { version = "0.1.0", path = "../repo" }
 sapling-storemodel = { version = "0.1.0", path = "../storemodel" }
 sapling-tracing-collector = { version = "0.1.0", path = "../tracing-collector" }

eden/scm/lib/backingstore/src/backingstore.rs

@@ -28,6 +28,7 @@ use edenapi::types::CommitId;
 use edenapi::BlockingResponse;
 use edenapi::RECENT_DOGFOODING_REQUESTS;
 use log::warn;
+use metrics::ods;
 use repo::repo::Repo;
 use repo::RepoMinimalInfo;
 use storemodel::BoxIterator;
@@ -148,6 +149,13 @@ impl BackingStore {
 
         let config = repo.config().clone();
 
+        let is_obc_enabled = config.get_or::<bool>("scmstore", "enable-obc", || false)?;
+        if is_obc_enabled {
+            if let Err(err) = ods::initialize_obc_client() {
+                tracing::warn!(?err, "error creating OBC client");
+            }
+        }
+
         Ok(Inner {
             treestore,
             filestore,

eden/scm/lib/repo/src/repo.rs

@@ -27,7 +27,6 @@ use edenapi::SaplingRemoteApi;
 use edenapi::SaplingRemoteApiError;
 use manifest_tree::ReadTreeManifest;
 use metalog::MetaLog;
-use metrics::ods;
 use once_cell::sync::OnceCell;
 use parking_lot::RwLock;
 use repo_minimal_info::constants::SUPPORTED_DEFAULT_REQUIREMENTS;
@@ -173,13 +172,6 @@ impl Repo {
 
         let locker = Arc::new(RepoLocker::new(&config, store_path.clone())?);
 
-        let is_obc_enabled = config.get_or::<bool>("scmstore", "enable-obc", || false)?;
-        if is_obc_enabled {
-            if let Err(err) = ods::initialize_obc_client() {
-                tracing::warn!(?err, "error creating OBC client");
-            }
-        }
-
         Ok(Repo {
             path,
             ident,