Update eden running version threshhold from 30 to 45 days

Summary:
As per the discussion in the document linked below, we will display EdenFS Health Report notifications for stale EdenFS versions only when the running version and installed version differ by more than 45 days. This change is part of the first proposal, which increases the gap in the Eden version from 30 days to 45 days.

https://docs.google.com/document/d/1fTxlasZfWv58iVhRr6Um3nSIOk4R0e4J6lxsCzG4W9E/edit?usp=sharing

Reviewed By: kavehahmadi60

Differential Revision: D74971406

fbshipit-source-id: ce01b40e991a14b6b67360f5e3988e9d62bbc784

Author: ViniGupta08

eden/fs/cli/main.py

@@ -1296,7 +1296,7 @@ def remediation(self) -> str:
 
     running_version: str = ""
     # a value of 0 turns off the stale version check
-    running_version_days_threshold = 30
+    running_version_days_threshold = 45
     version_info: VersionInfo = VersionInfo()
     error_codes: Dict[ErrorCode, str] = {}
 

eden/fs/cli/test/health_report_test.py

@@ -22,13 +22,12 @@
 from eden.test_support.temporary_directory import TemporaryDirectoryMixin
 
 from ..main import HealthReportCmd
-from eden.fs.cli.main import HealthReportCmd
 
 # The version "20241030-165642" is the latest version.
-# The version "20240928-144752" is over 30 days old, which is considered stale.
-# The version "20241010-189752" is less than 30 days old, which is considered acceptable.
+# The version "20240910-144752" is over 45 days old, which is considered stale.
+# The version "20241010-189752" is less than 45 days old, which is considered acceptable.
 LATEST_VERSION_STR = "20241030-165642"
-STALE_VERSION_STR = "20240928-144752"
+STALE_VERSION_STR = "20240910-144752"
 ACCEPTABLE_VERSION_STR = "20241010-189752"
 
 
@@ -279,7 +278,7 @@ def test_health_report_check_for_stale_eden_version_prompt_error(
         self.assertEqual(
             HealthReportCmd.error_codes,
             {
-                HealthReportCmd.ErrorCode.STALE_EDEN_VERSION: "Running EdenFS version: 20240928-144752, installed EdenFS version: 20241030-165642. The running EdenFS daemon is over 30 days out-of-date."
+                HealthReportCmd.ErrorCode.STALE_EDEN_VERSION: "Running EdenFS version: 20240910-144752, installed EdenFS version: 20241030-165642. The running EdenFS daemon is over 45 days out-of-date."
             },
         )
         self.assertEqual(result, 1)

eden/fs/config/EdenConfig.h

@@ -1634,7 +1634,7 @@ class EdenConfig : private ConfigSettingManager {
    */
   ConfigSetting<size_t> healthReportStaleVersionThresholdDays{
       "notifications:health-report-stale-version-threshold-days",
-      30,
+      45,
       this};
 
   /**