Skip to content

Commit 854e756

Browse files
gustavoavenafacebook-github-bot
authored andcommitted
Extract commit_id_args to separate crate
Summary: See the comments in [this post](https://fb.workplace.com/groups/565563378012983/posts/1362173881685258) for context. scsc can't depend on mononke/server libraries, so I split this one into two crates, so that we can continue to avoid code duplication, but scsc doesn't need to depend on `//eden/mononoke/server/context:context`. Reviewed By: andreacampi Differential Revision: D75222527 fbshipit-source-id: 6e38eb60d0695a01102df8568f4de0ed481317b2
1 parent f11607a commit 854e756

33 files changed

+616
-572
lines changed

eden/mononoke/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ members = [
198198
"cmdlib/base_app",
199199
"cmdlib/caching",
200200
"cmdlib/commit_id",
201+
"cmdlib/commit_id_types",
201202
"cmdlib/config_args",
202203
"cmdlib/cross_repo",
203204
"cmdlib/displaying",

eden/mononoke/cmdlib/commit_id/BUCK

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,14 @@ oncall("scm_server_infra")
55
rust_library(
66
name = "commit_id",
77
srcs = glob(["src/*.rs"]),
8+
crate_root = "src/commit_id.rs",
89
deps = [
910
"fbsource//third-party/rust:anyhow",
1011
"fbsource//third-party/rust:clap",
11-
"fbsource//third-party/rust:faster-hex",
1212
"fbsource//third-party/rust:futures",
1313
"fbsource//third-party/rust:strum",
14-
"//eden/mononoke/bonsai_git_mapping:bonsai_git_mapping",
15-
"//eden/mononoke/bonsai_globalrev_mapping:bonsai_globalrev_mapping",
16-
"//eden/mononoke/bonsai_hg_mapping:bonsai_hg_mapping",
17-
"//eden/mononoke/bonsai_svnrev_mapping:bonsai_svnrev_mapping",
1814
"//eden/mononoke/bookmarks:bookmarks",
15+
"//eden/mononoke/cmdlib/commit_id_types:commit_id_types",
1916
"//eden/mononoke/mercurial:mercurial_types",
2017
"//eden/mononoke/mononoke_types:mononoke_types",
2118
"//eden/mononoke/server/context:context",

eden/mononoke/cmdlib/commit_id/Cargo.toml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,10 @@ path = "src/commit_id.rs"
1212

1313
[dependencies]
1414
anyhow = "1.0.95"
15-
bonsai_git_mapping = { version = "0.1.0", path = "../../bonsai_git_mapping" }
16-
bonsai_globalrev_mapping = { version = "0.1.0", path = "../../bonsai_globalrev_mapping" }
17-
bonsai_hg_mapping = { version = "0.1.0", path = "../../bonsai_hg_mapping" }
18-
bonsai_svnrev_mapping = { version = "0.1.0", path = "../../bonsai_svnrev_mapping" }
1915
bookmarks = { version = "0.1.0", path = "../../bookmarks" }
2016
clap = { version = "4.5.38", features = ["derive", "env", "string", "unicode", "wrap_help"] }
17+
commit_id_types = { version = "0.1.0", path = "../commit_id_types" }
2118
context = { version = "0.1.0", path = "../../server/context" }
22-
faster-hex = "0.6.1"
2319
futures = { version = "0.3.30", features = ["async-await", "compat"] }
2420
mercurial_types = { version = "0.1.0", path = "../../mercurial/types" }
2521
mononoke_types = { version = "0.1.0", path = "../../mononoke_types" }

0 commit comments

Comments
 (0)