revisionstore: move redacted utilities to separate crate

Summary: I want to use these from the "checkout" crate without depending on the heavy "revisionstore" crate.

Reviewed By: zzl0

Differential Revision: D67958798

fbshipit-source-id: e7db7ea6c460ea8af394f27b762f8dd9d8ba50e7

Author: muirdm

eden/scm/Cargo.toml

@@ -182,6 +182,7 @@ members = [
   "lib/util/nodeipc/derive",
   "lib/util/procutil",
   "lib/util/pubsub",
+  "lib/util/redacted",
   "lib/util/rewrite-macros",
   "lib/util/rewrite-macros/tree-pattern-match",
   "lib/util/testutil",

eden/scm/lib/revisionstore/Cargo.toml

@@ -30,6 +30,7 @@ paste = "1.0.14"
 quickcheck = "1.0"
 quickcheck_arbitrary_derive = { version = "0.1.0", git = "https://github.com/facebookexperimental/rust-shed.git", branch = "main" }
 rand = { version = "0.8", features = ["small_rng"] }
+redacted = { version = "0.1.0", path = "../util/redacted" }
 sapling-async-runtime = { version = "0.1.0", path = "../async-runtime" }
 sapling-cas-client = { version = "0.1.0", path = "../cas-client" }
 sapling-clientinfo = { version = "0.1.0", path = "../clientinfo" }

eden/scm/lib/revisionstore/src/lfs.rs

@@ -78,6 +78,7 @@ use minibytes::Bytes;
 use parking_lot::Mutex;
 use rand::thread_rng;
 use rand::Rng;
+use redacted::is_redacted;
 use serde_derive::Deserialize;
 use serde_derive::Serialize;
 use storemodel::SerializationFormat;
@@ -112,8 +113,6 @@ use crate::historystore::RemoteHistoryStore;
 use crate::indexedlogutil::Store;
 use crate::indexedlogutil::StoreOpenOptions;
 use crate::localstore::LocalStore;
-use crate::redacted;
-use crate::redacted::is_redacted;
 use crate::remotestore::HgIdRemoteStore;
 use crate::types::ContentHash;
 use crate::types::StoreKey;

eden/scm/lib/revisionstore/src/lib.rs

@@ -107,7 +107,6 @@ mod indexedlogutil;
 mod lfs;
 mod metadatastore;
 mod missing;
-mod redacted;
 mod remotestore;
 mod repair;
 mod sliceext;
@@ -154,7 +153,6 @@ pub use crate::lfs::LfsRemote;
 pub use crate::localstore::LocalStore;
 pub use crate::metadatastore::MetadataStore;
 pub use crate::metadatastore::MetadataStoreBuilder;
-pub use crate::redacted::redact_if_needed;
 pub use crate::remotestore::HgIdRemoteStore;
 pub use crate::repair::repair;
 pub use crate::types::ContentHash;

eden/scm/lib/util/redacted/Cargo.toml

@@ -0,0 +1,9 @@
+# @generated by autocargo from //eden/scm/lib/util/redacted:redacted
+
+[package]
+name = "redacted"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]
+sapling-minibytes = { version = "0.1.0", path = "../../minibytes" }

…en/scm/lib/revisionstore/src/redacted.rs eden/scm/lib/util/redacted/src/lib.rseden/scm/lib/revisionstore/src/redacted.rs renamed to eden/scm/lib/util/redacted/src/lib.rs eden/scm/lib/revisionstore/src/redacted.rs renamed to eden/scm/lib/util/redacted/src/lib.rs

@@ -10,6 +10,7 @@ anyhow = "1.0.95"
 cpython = { version = "0.7.2", default-features = false }
 crossbeam = "0.8"
 pyrevisionstore = { version = "0.1.0", path = "../pyrevisionstore" }
+redacted = { version = "0.1.0", path = "../../../../lib/util/redacted" }
 sapling-cpython-ext = { version = "0.1.0", path = "../../../../lib/cpython-ext" }
 sapling-revisionstore = { version = "0.1.0", path = "../../../../lib/revisionstore" }
 sapling-storemodel = { version = "0.1.0", path = "../../../../lib/storemodel" }

eden/scm/saplingnative/bindings/modules/pyworker/Cargo.toml

@@ -28,7 +28,7 @@ use crossbeam::channel::bounded;
 use crossbeam::channel::Receiver;
 use crossbeam::channel::Sender;
 use pyrevisionstore::filescmstore;
-use revisionstore::redact_if_needed;
+use redacted::redact_if_needed;
 use revisionstore::scmstore::FileStore;
 use revisionstore::trait_impls::ArcFileStore;
 use storemodel::KeyStore;
@@ -107,7 +107,7 @@ impl<Ret: Send + 'static, Work: Sync + Send + 'static> Worker<Ret, Work> {
     ///     performance.
     ///  3) Since pushing work to the worker is single threaded, the batched work
     ///     has a high chance of being on the same files, increasing locality.
-    ///     
+    ///
     /// Caveat: the batch size was chosen semi-arbitrarily, and should be
     /// tweaked, too high of a value, and the progress reporting won't be
     /// good, too small of a value and the performance will suffer.