Skip to content

Commit 9bd0d50

Browse files
zsolfacebook-github-bot
authored andcommitted
nolint -> noqa
Summary: There are two types of change in this diff: 1. Replace `nolint` tags on python imports with `noqa: F401` 2. `arc f` to reformat with required formatters (can't land without this) `nolint` disables all linting in the file, and shouldn't be used for these cases as it hides lots of genuine issues unrelated to the import. NOTE: generated with ` fbgr -g '**/*.py' 'import .*#.*nolint' -ls | xargs sed -i 's/\(import .*#.*\)nolint/\1noqa: F401/g' ` Reviewed By: itamaro Differential Revision: D67897830 fbshipit-source-id: b7037924f8fb27615ebd8f89cd216ad0ae241762
1 parent c7b69ad commit 9bd0d50

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

eden/integration/lib/skip.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@
103103
],
104104
"unixsocket_test.UnixSocketTestHg": True,
105105
"userinfo_test.UserInfoTest": True,
106-
107106
#
108107
# Test classes from the hg integration test binary
109108
#
@@ -135,7 +134,7 @@
135134
"hg.update_test.UpdateCacheInvalidationTest": [
136135
"test_changing_file_contents_creates_new_inode_and_flushes_dcache",
137136
# Similar to above, this test is marked flaky on the TestX UI. To avoid
138-
# the FilteredFS mixin showing up as broken, we skip it altogether.
137+
# the FilteredFS mixin showing up as broken, we skip it altogether.
139138
"test_file_locked_removal",
140139
],
141140
"hg.update_test.UpdateTest": [
@@ -344,7 +343,7 @@ def _have_ntapi_extension_module() -> bool:
344343
return False
345344

346345
try:
347-
from eden.integration.lib.ntapi import ( # @manual # @nolint
346+
from eden.integration.lib.ntapi import ( # @manual # noqa: F401
348347
get_directory_entry_size,
349348
)
350349

@@ -404,7 +403,7 @@ def _have_ntapi_extension_module() -> bool:
404403
],
405404
}
406405

407-
for (testModule, disabled) in NFS_TEST_DISABLED.items():
406+
for testModule, disabled in NFS_TEST_DISABLED.items():
408407
for vcs in ["Hg", "Git"]:
409408
TEST_DISABLED[testModule + "NFS" + vcs] = disabled
410409

@@ -458,7 +457,7 @@ def _have_ntapi_extension_module() -> bool:
458457
# We temporarily need to add skips for FilteredFS mixins. Do not add FilteredFS
459458
# specific skips here. Add them below to FILTERED_TEST_DISABLED instead.
460459
FILTEREDFS_PARITY = {}
461-
for (class_name, value_name) in TEST_DISABLED.items():
460+
for class_name, value_name in TEST_DISABLED.items():
462461
if class_name.endswith("Hg"):
463462
FILTEREDFS_PARITY[class_name.replace("Hg", "FilteredHg")] = value_name
464463
elif not class_name.endswith("FilteredHg") and not class_name.endswith("Git"):
@@ -480,7 +479,7 @@ def _have_ntapi_extension_module() -> bool:
480479
"test_disallow_bind_mount_outside_repo",
481480
],
482481
}
483-
for (testModule, disabled) in FILTEREDFS_TEST_DISABLED.items():
482+
for testModule, disabled in FILTEREDFS_TEST_DISABLED.items():
484483
# We should add skips for all combinations of FilteredHg mixins.
485484
other_mixins = ["", "NFS"] if sys.platform != "win32" else ["", "InMemory"]
486485
for mixin in other_mixins:

0 commit comments

Comments
 (0)