Skip to content

Commit 9df6a94

Browse files
Alramechfacebook-github-bot
authored andcommitted
Fix: Skipped windows test getting overriden by later more scoped exclude on Sandcastle
Summary: Fix for windows build running Nix tests on Sandcastle Reviewed By: jdelliot Differential Revision: D75235893 fbshipit-source-id: a655e16bd6480fdf17ccdb83ba47499ef31da0af
1 parent 1af9b09 commit 9df6a94

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

eden/integration/lib/skip.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -449,9 +449,11 @@ def _have_ntapi_extension_module() -> bool:
449449
class_skipped.append(method_name)
450450

451451
# We don't have passwordless sudo on sandcastle
452-
TEST_DISABLED["changes_test.ChangesTestNix"] = [
453-
"test_modify_folder_chown",
454-
]
452+
# Disable if it's not already disabled
453+
if TEST_DISABLED.get("changes_test.ChangesTestNix") is None:
454+
TEST_DISABLED["changes_test.ChangesTestNix"] = [
455+
"test_modify_folder_chown",
456+
]
455457

456458
try:
457459
from eden.integration.facebook.lib.skip import add_fb_specific_skips

0 commit comments

Comments
 (0)