config: fix duplicate config loading for .sl repos

Summary:
Now the ui stores an identity object. The identity starts off as the default environment identity, but when a repo is loaded we sniff the identity from the repo's dot dir.

We use the identity to fix the check as to whether the repo's hgrc has already been loaded.

Reviewed By: DurhamG

Differential Revision: D39105267

fbshipit-source-id: 9d726af125a3167df054841eb1f18a018e01e615

Author: Muir Manders

eden/scm/edenscm/ui.py

@@ -231,6 +231,8 @@ def __init__(self, src=None, rcfg=None):
             self.cliconfigs = src.cliconfigs.copy()
             self.cliconfigfiles = src.cliconfigfiles.copy()
             self.clioptions = src.clioptions.copy()
+
+            self.identity = src.identity
         else:
             self._uiconfig = uiconfig.uiconfig(rcfg=rcfg)
 
@@ -250,6 +252,8 @@ def __init__(self, src=None, rcfg=None):
 
             self.metrics = metrics.metrics(self)
 
+            self.identity = bindings.identity.sniffenv()
+
         allowed = self.configlist("experimental", "exportableenviron")
         if "*" in allowed:
             self._exportableenviron = self.environ
@@ -272,8 +276,13 @@ def reloadconfigs(self, repopath=None):
 
     def loadrepoconfig(self, repopath):
         """Load repofull config from repopath if not already loaded."""
+
+        ident = bindings.identity.sniffdir(repopath)
+        if ident:
+            self.identity = ident
+
         loadedfiles = self._rcfg.files()
-        repohgrc = os.path.join(repopath, ".hg", "hgrc")
+        repohgrc = os.path.join(repopath, self.identity.dotdir(), "hgrc")
 
         # Check if our repo hgrc path (or Windows UNC flavor) have already been loaded.
         if not any(lf in {repohgrc, f"\\\\?\\{repohgrc}"} for lf in loadedfiles):

eden/scm/tests/test-identity.t

@@ -54,6 +54,7 @@ Clone can create a ".sl" repo.
 
   $ cd cloned
 Status kind of runs, but doesn't ignore ".sl" properly (for non-watchman)
-  $ hg status | head -1
+  $ LOG=configparser::hg=info hg status | head -1
   ? .sl/.dir_lock (?)
+   INFO configparser::hg: loading config repo_path=Some("$TESTTMP/clone_me/cloned")