Skip to content

Commit fa90e2c

Browse files
ben--facebook-github-bot
authored andcommitted
feat(oss): include thrift/lib/(cpp,cpp2,java,py,python) from fbthrift (#1138)
Summary: Map `fbcode/thrift/lib/cpp` into sapling so it is available to satisfy the error shown below. (As well as `cpp2`, `java`, `py` and `python`.) This may not be the correct mapping (fbthrift uses a copy in `xplat/thrift`), but it is necessary to unblock OSS buck development as fbthrift does prune all `BUCK` files from its OSS repo. The error in the OSS buck build: ``` $ buck2 build //eden/fs/service:edenfs-oss ... Error running analysis for `gh_facebook_sapling//eden/fs/service:edenfs-oss (prelude//platforms:default#2c621926a02f7469)` Caused by: 0: Error in configured node dependency, dependency chain follows (-> indicates depends on, ^ indicates same configuration as previous): gh_facebook_sapling//eden/fs/service:edenfs-oss (prelude//platforms:default#2c621926a02f7469) -> gh_facebook_sapling//eden/fs/service:server (^) -> gh_facebook_sapling//thrift/lib/cpp:event_handler_base (^) 1: looking up unconfigured target node `gh_facebook_sapling//thrift/lib/cpp:event_handler_base` 2: Error loading targets in package `gh_facebook_sapling//thrift/lib/cpp` for target `gh_facebook_sapling//thrift/lib/cpp:event_handler_base` 3: package `gh_facebook_sapling//thrift/lib/cpp:` does not exist missing `BUCK` file (also missing alternatives `BUCK.v2`, `BUCK`) ``` Pull Request resolved: #1138 Reviewed By: muirdm Differential Revision: D83259168 Pulled By: quark-zju fbshipit-source-id: 52cbe1a73b74580e33d98c8defc438c831d723c3
1 parent 053e634 commit fa90e2c

File tree

1 file changed

+5
-0
lines changed
  • build/fbcode_builder/manifests

1 file changed

+5
-0
lines changed

build/fbcode_builder/manifests/eden

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,11 @@ sapling
6363
# for internal builds that use getdeps
6464
fbcode/fb303 = fb303
6565
fbcode/common/rust/shed = common/rust/shed
66+
fbcode/thrift/lib/cpp = thrift/lib/cpp
67+
fbcode/thrift/lib/cpp2 = thrift/lib/cpp2
68+
fbcode/thrift/lib/java = thrift/lib/java
69+
fbcode/thrift/lib/py = thrift/lib/py
70+
fbcode/thrift/lib/python = thrift/lib/python
6671
fbcode/thrift/lib/rust = thrift/lib/rust
6772

6873
[shipit.pathmap]

0 commit comments

Comments
 (0)