Add ability to get a URL for a global symbol

Summary:
Add the ability to fetch an LspUrl for a given global symbol if it's present.

This will be used in future revisions to be able to "navigate" to native symbols.

Reviewed By: bobyangyf

Differential Revision: D38452372

fbshipit-source-id: 765759d54e6c5adb1076e1a2a5c985b0b3e52cac

Author: Natalie Jameson

starlark/bin/eval.rs

@@ -57,6 +57,7 @@ pub(crate) struct Context {
     pub(crate) prelude: Vec<FrozenModule>,
     pub(crate) module: Option<Module>,
     pub(crate) builtin_docs: HashMap<LspUrl, String>,
+    pub(crate) builtin_symbols: HashMap<String, LspUrl>,
 }
 
 /// The outcome of evaluating (checking, parsing or running) given starlark code.
@@ -91,8 +92,10 @@ impl Context {
             None
         };
         let mut builtins: HashMap<LspUrl, Vec<Doc>> = HashMap::new();
+        let mut builtin_symbols: HashMap<String, LspUrl> = HashMap::new();
         for doc in get_registered_docs() {
             let uri = Self::url_for_doc(&doc);
+            builtin_symbols.insert(doc.id.name.clone(), uri.clone());
             builtins.entry(uri).or_default().push(doc);
         }
         let builtin_docs = builtins
@@ -106,6 +109,7 @@ impl Context {
             prelude,
             module,
             builtin_docs,
+            builtin_symbols,
         })
     }
 
@@ -302,6 +306,14 @@ impl LspContext for Context {
             _ => Err(LoadContentsError::WrongScheme("file://".to_owned(), uri.clone()).into()),
         }
     }
+
+    fn get_url_for_global_symbol(
+        &self,
+        _current_file: &LspUrl,
+        symbol: &str,
+    ) -> anyhow::Result<Option<LspUrl>> {
+        Ok(self.builtin_symbols.get(symbol).cloned())
+    }
 }
 
 pub(crate) fn globals() -> Globals {

starlark/src/lsp/server.rs

@@ -279,6 +279,16 @@ pub trait LspContext {
             .map(|content| self.parse_file_with_contents(uri, content));
         Ok(result)
     }
+
+    /// Get the LSPUrl for a global symbol if possible.
+    ///
+    /// The current file is provided in case different files have different global symbols
+    /// defined.
+    fn get_url_for_global_symbol(
+        &self,
+        current_file: &LspUrl,
+        symbol: &str,
+    ) -> anyhow::Result<Option<LspUrl>>;
 }
 
 /// Errors when [`LspContext::resolve_load()`] cannot resolve a given path.

starlark/src/lsp/test.rs

@@ -107,6 +107,7 @@ struct TestServerContext {
     file_contents: Arc<RwLock<HashMap<PathBuf, String>>>,
     dirs: Arc<RwLock<HashSet<PathBuf>>>,
     builtin_docs: Arc<HashMap<LspUrl, String>>,
+    builtin_symbols: Arc<HashMap<String, LspUrl>>,
 }
 
 impl LspContext for TestServerContext {
@@ -208,6 +209,14 @@ impl LspContext for TestServerContext {
             _ => Ok(None),
         }
     }
+
+    fn get_url_for_global_symbol(
+        &self,
+        _current_file: &LspUrl,
+        symbol: &str,
+    ) -> anyhow::Result<Option<LspUrl>> {
+        Ok(self.builtin_symbols.get(symbol).cloned())
+    }
 }
 
 /// A server for use in testing that provides helpers for sending requests, correlating
@@ -335,12 +344,20 @@ impl TestServer {
     pub(crate) fn new_with_settings(settings: Option<LspServerSettings>) -> anyhow::Result<Self> {
         let (server_connection, client_connection) = Connection::memory();
 
-        let builtin_docs = Arc::new(
-            Self::testing_builtins(&std::env::current_dir()?)?
-                .into_iter()
-                .map(|(u, ds)| (u, render_docs_as_code(&ds).join("\n\n")))
-                .collect::<HashMap<_, _>>(),
-        );
+        let builtin = Self::testing_builtins(&std::env::current_dir()?)?;
+        let mut builtin_docs = HashMap::with_capacity(builtin.len());
+        let mut builtin_symbols = HashMap::new();
+
+        for (u, ds) in builtin {
+            builtin_docs.insert(u.clone(), render_docs_as_code(&ds).join("\n\n"));
+            for d in ds {
+                builtin_symbols.insert(d.id.name, u.clone());
+            }
+        }
+
+        let builtin_docs = Arc::new(builtin_docs);
+        let builtin_symbols = Arc::new(builtin_symbols);
+
         let prelude_file_contents = builtin_docs
             .iter()
             .filter_map(|(u, d)| match u {
@@ -354,6 +371,7 @@ impl TestServer {
             file_contents: file_contents.dupe(),
             dirs: dirs.dupe(),
             builtin_docs: builtin_docs.dupe(),
+            builtin_symbols,
         };
 
         let server_thread = std::thread::spawn(|| {