Move AllocValue for bigint into a separate file

Summary: Following diff D38712858 adds more conversions.

Reviewed By: bobyangyf

Differential Revision: D38712855

fbshipit-source-id: ebc51bf7e6ad2efa5d6614ef368a4e29e2ec4acf

Author: stepancheg

starlark/src/values/types/bigint/convert.rs

@@ -0,0 +1,73 @@
+/*
+ * Copyright 2019 The Starlark in Rust Authors.
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+use crate::values::type_repr::StarlarkTypeRepr;
+use crate::values::types::bigint::StarlarkBigInt;
+use crate::values::AllocFrozenValue;
+use crate::values::AllocValue;
+use crate::values::FrozenHeap;
+use crate::values::FrozenValue;
+use crate::values::Heap;
+use crate::values::Value;
+
+impl StarlarkTypeRepr for u64 {
+    fn starlark_type_repr() -> String {
+        i32::starlark_type_repr()
+    }
+}
+
+impl<'v> AllocValue<'v> for u64 {
+    fn alloc_value(self, heap: &'v Heap) -> Value<'v> {
+        match i32::try_from(self) {
+            Ok(x) => Value::new_int(x),
+            Err(_) => StarlarkBigInt::alloc_bigint(self.into(), heap),
+        }
+    }
+}
+
+impl AllocFrozenValue for u64 {
+    fn alloc_frozen_value(self, heap: &FrozenHeap) -> FrozenValue {
+        match i32::try_from(self) {
+            Ok(x) => FrozenValue::new_int(x),
+            Err(_) => StarlarkBigInt::alloc_bigint_frozen(self.into(), heap),
+        }
+    }
+}
+
+impl StarlarkTypeRepr for i64 {
+    fn starlark_type_repr() -> String {
+        i32::starlark_type_repr()
+    }
+}
+
+impl<'v> AllocValue<'v> for i64 {
+    fn alloc_value(self, heap: &'v Heap) -> Value<'v> {
+        match i32::try_from(self) {
+            Ok(x) => Value::new_int(x),
+            Err(_) => StarlarkBigInt::alloc_bigint(self.into(), heap),
+        }
+    }
+}
+
+impl AllocFrozenValue for i64 {
+    fn alloc_frozen_value(self, heap: &FrozenHeap) -> FrozenValue {
+        match i32::try_from(self) {
+            Ok(x) => FrozenValue::new_int(x),
+            Err(_) => StarlarkBigInt::alloc_bigint_frozen(self.into(), heap),
+        }
+    }
+}

starlark/src/values/types/bigint/mod.rs

@@ -17,6 +17,8 @@
 
 //! Outside of `i32` range int.
 
+mod convert;
+
 use std::cmp::Ordering;
 use std::hash::Hash;
 use std::ops::Not;
@@ -32,9 +34,6 @@ use serde::Serialize;
 use crate::collections::StarlarkHasher;
 use crate::values::float::StarlarkFloat;
 use crate::values::num::Num;
-use crate::values::type_repr::StarlarkTypeRepr;
-use crate::values::AllocFrozenValue;
-use crate::values::AllocValue;
 use crate::values::FrozenHeap;
 use crate::values::FrozenValue;
 use crate::values::Heap;
@@ -400,54 +399,6 @@ impl<'v> StarlarkValue<'v> for StarlarkBigInt {
     }
 }
 
-impl StarlarkTypeRepr for u64 {
-    fn starlark_type_repr() -> String {
-        i32::starlark_type_repr()
-    }
-}
-
-impl<'v> AllocValue<'v> for u64 {
-    fn alloc_value(self, heap: &'v Heap) -> Value<'v> {
-        match i32::try_from(self) {
-            Ok(x) => Value::new_int(x),
-            Err(_) => StarlarkBigInt::alloc_bigint(self.into(), heap),
-        }
-    }
-}
-
-impl AllocFrozenValue for u64 {
-    fn alloc_frozen_value(self, heap: &FrozenHeap) -> FrozenValue {
-        match i32::try_from(self) {
-            Ok(x) => FrozenValue::new_int(x),
-            Err(_) => StarlarkBigInt::alloc_bigint_frozen(self.into(), heap),
-        }
-    }
-}
-
-impl StarlarkTypeRepr for i64 {
-    fn starlark_type_repr() -> String {
-        i32::starlark_type_repr()
-    }
-}
-
-impl<'v> AllocValue<'v> for i64 {
-    fn alloc_value(self, heap: &'v Heap) -> Value<'v> {
-        match i32::try_from(self) {
-            Ok(x) => Value::new_int(x),
-            Err(_) => StarlarkBigInt::alloc_bigint(self.into(), heap),
-        }
-    }
-}
-
-impl AllocFrozenValue for i64 {
-    fn alloc_frozen_value(self, heap: &FrozenHeap) -> FrozenValue {
-        match i32::try_from(self) {
-            Ok(x) => FrozenValue::new_int(x),
-            Err(_) => StarlarkBigInt::alloc_bigint_frozen(self.into(), heap),
-        }
-    }
-}
-
 #[cfg(test)]
 mod tests {
     use std::hash::Hasher;