Move the lsp pieces into lsp

Summary: These "analysis" pieces were extended by the people working on LSP. I don't entirely understand them, but by tucking them under LSP, it makes me feel less bad about understanding them. Also keeps the users closer to the code.

Reviewed By: stepancheg

Differential Revision: D43463234

fbshipit-source-id: b5277407b252ba36f602525ed378962a7f657fe6

Author: ndmitchell

starlark/src/analysis/mod.rs

@@ -24,8 +24,6 @@ pub use types::Lint;
 use crate::analysis::types::LintT;
 use crate::syntax::AstModule;
 
-mod bind;
-pub(crate) mod definition;
 mod dubious;
 pub(crate) mod exported;
 mod find_call_name;

starlark/src/analysis/bind.rs renamed to starlark/src/lsp/bind.rs

@@ -17,15 +17,15 @@
 
 use std::iter;
 
-use crate::analysis::bind::scope;
-use crate::analysis::bind::Assigner;
-use crate::analysis::bind::Bind;
-use crate::analysis::bind::Scope;
 use crate::codemap::CodeMap;
 use crate::codemap::Pos;
 use crate::codemap::ResolvedSpan;
 use crate::codemap::Span;
 use crate::codemap::Spanned;
+use crate::lsp::bind::scope;
+use crate::lsp::bind::Assigner;
+use crate::lsp::bind::Bind;
+use crate::lsp::bind::Scope;
 use crate::slice_vec_ext::SliceExt;
 use crate::syntax::ast::ArgumentP;
 use crate::syntax::ast::AssignP;

starlark/src/analysis/definition.rs renamed to starlark/src/lsp/definition.rs

@@ -18,6 +18,8 @@
 //! The server that allows IDEs to evaluate and interpret starlark code according
 //! to the [Language Server Protocol](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/).
 
+mod bind;
+mod definition;
 pub mod server;
 mod symbols;
 #[cfg(all(test, not(windows)))]

starlark/src/lsp/mod.rs

@@ -66,11 +66,11 @@ use serde::Deserializer;
 use serde::Serialize;
 use serde::Serializer;
 
-use crate::analysis::definition::Definition;
-use crate::analysis::definition::DottedDefinition;
-use crate::analysis::definition::IdentifierDefinition;
-use crate::analysis::definition::LspModule;
 use crate::codemap::ResolvedSpan;
+use crate::lsp::definition::Definition;
+use crate::lsp::definition::DottedDefinition;
+use crate::lsp::definition::IdentifierDefinition;
+use crate::lsp::definition::LspModule;
 use crate::lsp::server::LoadContentsError::WrongScheme;
 use crate::syntax::AstModule;
 
@@ -790,8 +790,8 @@ mod test {
     use lsp_types::Url;
     use textwrap::dedent;
 
-    use crate::analysis::definition::helpers::FixtureWithRanges;
     use crate::codemap::ResolvedSpan;
+    use crate::lsp::definition::helpers::FixtureWithRanges;
     use crate::lsp::server::LspServerSettings;
     use crate::lsp::server::LspUrl;
     use crate::lsp::server::StarlarkFileContentsParams;