Remove a redundant argument from LocationFinder

Summary: It just gives you back what you gave it. I can't see how this would ever be useful.

Reviewed By: milend

Differential Revision: D47190447

fbshipit-source-id: 2315669ff2c7426400c41f1578cf6ada57ef70e0

Author: ndmitchell

starlark/src/lsp/server.rs

@@ -214,13 +214,13 @@ impl TryFrom<&LspUrl> for Url {
 pub struct StringLiteralResult {
     /// The path that a string literal resolves to.
     pub url: LspUrl,
-    /// A function that takes the AstModule at path specified by `url` and that same url, and
+    /// A function that takes the AstModule at path specified by `url`, and
     /// allows resolving a location to jump to within the specific URL if desired.
     ///
     /// If `None`, then just jump to the URL. Do not attempt to load the file.
     #[derivative(Debug = "ignore")]
     pub location_finder:
-        Option<Box<dyn FnOnce(&AstModule, &LspUrl) -> anyhow::Result<Option<Range>> + Send>>,
+        Option<Box<dyn FnOnce(&AstModule) -> anyhow::Result<Option<Range>> + Send>>,
 }
 
 fn _assert_string_literal_result_is_send() {
@@ -498,7 +498,7 @@ impl<T: LspContext> Backend<T> {
                         let result =
                             self.get_ast_or_load_from_disk(&url)
                                 .and_then(|ast| match ast {
-                                    Some(module) => location_finder(&module.ast, &url),
+                                    Some(module) => location_finder(&module.ast),
                                     None => Ok(None),
                                 });
                         if let Err(e) = &result {

starlark/src/lsp/test.rs

@@ -193,7 +193,7 @@ impl LspContext for TestServerContext {
                 LspUrl::File(u) => match u.extension() {
                     Some(e) if e == "star" => Some(StringLiteralResult {
                         url,
-                        location_finder: Some(Box::new(move |_ast, _url| Ok(range))),
+                        location_finder: Some(Box::new(move |_ast| Ok(range))),
                     }),
                     _ => Some(StringLiteralResult {
                         url,