Skip to content

Commit fd6fff9

Browse files
jtbraunmeta-codesync[bot]
authored andcommitted
have PrfjfsRequestContext/PrjfsTraceEvent save/transfer the result field, propagate it to the thrift logging type
Summary: Per title, include the `HRESULT` in the `PrjfsTraceEvent` finish event so that the trace streamer can print it. Document that it's an HRESULT, and how it's stored. Reviewed By: muirdm Differential Revision: D92054489 fbshipit-source-id: 32ddac524aac69ecf6029186551f6c3d683d4e37
1 parent 8f705c2 commit fd6fff9

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

eden/fs/service/streamingeden.thrift

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ struct FsEvent {
5858
8: eden.RequestInfo requestInfo;
5959

6060
/**
61+
* For POSIX filesystems:
6162
* The result code sent back to the kernel.
6263
*
6364
* Positive is success, and, depending on the operation, may contain a nonzero result.
@@ -67,6 +68,12 @@ struct FsEvent {
6768
* request to future FUSE requests on that inode.
6869
*
6970
* Negative indicates an error.
71+
*
72+
* For ProjFs on Windows:
73+
* The HRESULT code sent back to the kernel.
74+
*
75+
* Interpreted as an HRESULT (https://en.wikipedia.org/wiki/HRESULT), only the lower 32 bits should be considered valid. After conversion, all of the normal HRESULT semantics apply.
76+
*
7077
*/
7178
9: optional i64 result;
7279
}

0 commit comments

Comments
 (0)