fix crash in AdminCommandconnection::TLSSensingCallback

mcrnic · facebook-github-bot · commit a76d5f0f199c · 2019-10-18T02:01:02.000-07:00
Summary: Function was missing a return after handling an error which could lead to use after free

Reviewed By: MohamedBassem

Differential Revision: D17907011

fbshipit-source-id: fccfece467e27b987b733272c02fe9a8caf4925e
diff --git a/logdevice/server/admincommands/CommandListener.cpp b/logdevice/server/admincommands/CommandListener.cpp
@@ -52,6 +52,7 @@ void AdminCommandConnection::TLSSensingCallback::getReadBuffer(
   if (rv != 1) {
     ld_critical("There is no 1 byte in the socket for TLS detection.");
     connection_.closeConnectionAndDestroyObject();
+    return;
   }
 
   ld_debug("read data is available for peeking");

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ void AdminCommandConnection::TLSSensingCallback::getReadBuffer(`
`52`	`52`	`if (rv != 1) {`
`53`	`53`	`ld_critical("There is no 1 byte in the socket for TLS detection.");`
`54`	`54`	`connection_.closeConnectionAndDestroyObject();`
	`55`	`+ return;`
`55`	`56`	`}`
`56`	`57`
`57`	`58`	`ld_debug("read data is available for peeking");`