Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

Commit 3e272f9

Browse files
kalessilkalessil
committed
SCA (Static Code Analysis) warnings partially fixed (code style, if conditionals, strict types, performance).
1 parent b524d13 commit 3e272f9

11 files changed

+41
-40
lines changed

‎src/Facebook/Entities/AccessToken.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,10 @@ public static function validateAccessToken(GraphSessionInfo $tokenInfo,
154154
$machineIdIsValid = $tokenInfo->getProperty('machine_id') == $machineId;
155155
$accessTokenIsValid = $tokenInfo->isValid();
156156

157+
$accessTokenIsStillAlive = true;
157158
// Not all access tokens return an expiration. E.g. an app access token.
158159
if ($tokenInfo->getExpiresAt() instanceof \DateTime) {
159160
$accessTokenIsStillAlive = $tokenInfo->getExpiresAt()->getTimestamp() >= time();
160-
} else {
161-
$accessTokenIsStillAlive = true;
162161
}
163162

164163
return $appIdIsValid && $machineIdIsValid && $accessTokenIsValid && $accessTokenIsStillAlive;
@@ -178,7 +177,7 @@ public static function getAccessTokenFromCode($code, $appId = null, $appSecret =
178177
{
179178
$params = array(
180179
'code' => $code,
181-
'redirect_uri' => '',
180+
'redirect_uri' => ''
182181
);
183182

184183
if ($machineId) {
@@ -203,7 +202,7 @@ public static function getCodeFromAccessToken($accessToken, $appId = null, $appS
203202

204203
$params = array(
205204
'access_token' => $accessToken,
206-
'redirect_uri' => '',
205+
'redirect_uri' => ''
207206
);
208207

209208
return static::requestCode($params, $appId, $appSecret);
@@ -221,7 +220,7 @@ public function extend($appId = null, $appSecret = null)
221220
{
222221
$params = array(
223222
'grant_type' => 'fb_exchange_token',
224-
'fb_exchange_token' => $this->accessToken,
223+
'fb_exchange_token' => $this->accessToken
225224
);
226225

227226
return static::requestAccessToken($params, $appId, $appSecret);
@@ -374,7 +373,7 @@ public function __toString()
374373
*/
375374
public function isAppSession()
376375
{
377-
return strpos($this->accessToken, "|") !== false;
376+
return strpos($this->accessToken, '|') !== false;
378377
}
379378

380379
}

‎src/Facebook/Entities/SignedRequest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,9 +298,10 @@ public static function hashSignature($encodedData, $appSecret = null)
298298
*/
299299
public static function validateSignature($hashedSig, $sig)
300300
{
301-
if (mb_strlen($hashedSig) === mb_strlen($sig)) {
301+
$intSignatureLength = mb_strlen($sig);
302+
if (mb_strlen($hashedSig) === $intSignatureLength) {
302303
$validate = 0;
303-
for ($i = 0; $i < mb_strlen($sig); $i++) {
304+
for ($i = 0; $i < $intSignatureLength; $i++) {
304305
$validate |= ord($hashedSig[$i]) ^ ord($sig[$i]);
305306
}
306307
if ($validate === 0) {

‎src/Facebook/FacebookRedirectLoginHelper.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public function __construct($redirectUrl, $appId = null, $appSecret = null)
9090
*
9191
* @return string
9292
*/
93-
public function getLoginUrl($scope = array(), $version = null, $displayAsPopup = false, $authType = false)
93+
public function getLoginUrl(array $scope = array(), $version = null, $displayAsPopup = false, $authType = false)
9494
{
9595
$version = ($version ?: FacebookRequest::GRAPH_API_VERSION);
9696
$this->state = $this->random(16);
@@ -124,7 +124,7 @@ public function getLoginUrl($scope = array(), $version = null, $displayAsPopup =
124124
*
125125
* @return string
126126
*/
127-
public function getReRequestUrl($scope = array(), $version = null)
127+
public function getReRequestUrl(array $scope = array(), $version = null)
128128
{
129129
$version = ($version ?: FacebookRequest::GRAPH_API_VERSION);
130130
$this->state = $this->random(16);
@@ -276,12 +276,12 @@ public function random($bytes)
276276
{
277277
if (!is_numeric($bytes)) {
278278
throw new FacebookSDKException(
279-
"random() expects an integer"
279+
'random() expects an integer'
280280
);
281281
}
282282
if ($bytes < 1) {
283283
throw new FacebookSDKException(
284-
"random() expects an integer greater than zero"
284+
'random() expects an integer greater than zero'
285285
);
286286
}
287287
$buf = '';

‎src/Facebook/FacebookRequest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -194,13 +194,13 @@ public function __construct(
194194

195195
$params = ($parameters ?: array());
196196
if ($session
197-
&& !isset($params["access_token"])) {
198-
$params["access_token"] = $session->getToken();
197+
&& !isset($params['access_token'])) {
198+
$params['access_token'] = $session->getToken();
199199
}
200-
if (FacebookSession::useAppSecretProof()
201-
&& !isset($params["appsecret_proof"])) {
202-
$params["appsecret_proof"] = $this->getAppSecretProof(
203-
$params["access_token"]
200+
if (!isset($params['appsecret_proof'])
201+
&& FacebookSession::useAppSecretProof()) {
202+
$params['appsecret_proof'] = $this->getAppSecretProof(
203+
$params['access_token']
204204
);
205205
}
206206
$this->params = $params;
@@ -229,7 +229,7 @@ public function execute()
229229
$url = $this->getRequestURL();
230230
$params = $this->getParameters();
231231

232-
if ($this->method === "GET") {
232+
if ($this->method === 'GET') {
233233
$url = self::appendParamsToUrl($url, $params);
234234
$params = array();
235235
}
@@ -239,7 +239,7 @@ public function execute()
239239
$connection->addRequestHeader('Accept-Encoding', '*'); // Support all available encodings.
240240

241241
// ETag
242-
if (isset($this->etag)) {
242+
if (null !== $this->etag) {
243243
$connection->addRequestHeader('If-None-Match', $this->etag);
244244
}
245245

@@ -249,7 +249,7 @@ public function execute()
249249

250250
static::$requestCount++;
251251

252-
$etagHit = 304 == $connection->getResponseHttpStatusCode();
252+
$etagHit = (304 === $connection->getResponseHttpStatusCode());
253253

254254
$headers = $connection->getResponseHeaders();
255255
$etagReceived = isset($headers['ETag']) ? $headers['ETag'] : null;
@@ -291,7 +291,7 @@ public function getAppSecretProof($token)
291291
*
292292
* @return string
293293
*/
294-
public static function appendParamsToUrl($url, $params = array())
294+
public static function appendParamsToUrl($url, array $params = array())
295295
{
296296
if (!$params) {
297297
return $url;

‎src/Facebook/FacebookRequestException.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public static function create($raw, $data, $statusCode)
8080
if (!isset($data['error']['code']) && isset($data['code'])) {
8181
$data = array('error' => $data);
8282
}
83-
$code = (isset($data['error']['code']) ? $data['error']['code'] : null);
83+
$code = (isset($data['error']['code']) ? (int)$data['error']['code'] : null);
8484

8585
if (isset($data['error']['error_subcode'])) {
8686
switch ($data['error']['error_subcode']) {
@@ -124,7 +124,7 @@ public static function create($raw, $data, $statusCode)
124124
}
125125

126126
// Missing Permissions
127-
if ($code == 10 || ($code >= 200 && $code <= 299)) {
127+
if ($code === 10 || ($code >= 200 && $code <= 299)) {
128128
return new FacebookPermissionException($raw, $data, $statusCode);
129129
}
130130

‎src/Facebook/FacebookSignedRequestFromInputHelper.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ abstract class FacebookSignedRequestFromInputHelper
5050
/**
5151
* @var string|null Random string to prevent CSRF.
5252
*/
53-
public $state = null;
53+
public $state;
5454

5555
/**
5656
* Initialize the helper and process available signed request data.
@@ -69,7 +69,7 @@ public function __construct($appId = null, $appSecret = null)
6969
/**
7070
* Instantiates a new SignedRequest entity.
7171
*
72-
* @param string|null
72+
* @param string|null $rawSignedRequest
7373
*/
7474
public function instantiateSignedRequest($rawSignedRequest = null)
7575
{
@@ -157,8 +157,9 @@ public function getRawSignedRequestFromPost()
157157
*/
158158
public function getRawSignedRequestFromCookie()
159159
{
160-
if (isset($_COOKIE['fbsr_' . $this->appId])) {
161-
return $_COOKIE['fbsr_' . $this->appId];
160+
$strCookieKey = 'fbsr_' . $this->appId;
161+
if (isset($_COOKIE[$strCookieKey])) {
162+
return $_COOKIE[$strCookieKey];
162163
}
163164
return null;
164165
}

‎src/Facebook/HttpClients/FacebookCurl.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ class FacebookCurl
3333
{
3434

3535
/**
36-
* @var resource Curl resource instance
36+
* @var resource|null Curl resource instance
3737
*/
38-
protected $curl = null;
38+
protected $curl;
3939

4040
/**
4141
* Make a new curl reference instance

‎src/Facebook/HttpClients/FacebookCurlHttpClient.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public function getResponseHttpStatusCode()
141141
*
142142
* @throws \Facebook\FacebookSDKException
143143
*/
144-
public function send($url, $method = 'GET', $parameters = array())
144+
public function send($url, $method = 'GET', array $parameters = array())
145145
{
146146
$this->openConnection($url, $method, $parameters);
147147
$this->tryToSendRequest();
@@ -167,7 +167,7 @@ public function send($url, $method = 'GET', $parameters = array())
167167
* @param string $method The request method
168168
* @param array $parameters The key value pairs to be sent in the body
169169
*/
170-
public function openConnection($url, $method = 'GET', $parameters = array())
170+
public function openConnection($url, $method = 'GET', array $parameters = array())
171171
{
172172
$options = array(
173173
CURLOPT_URL => $url,
@@ -177,17 +177,17 @@ public function openConnection($url, $method = 'GET', $parameters = array())
177177
CURLOPT_HEADER => true, // Enable header processing
178178
CURLOPT_SSL_VERIFYHOST => 2,
179179
CURLOPT_SSL_VERIFYPEER => true,
180-
CURLOPT_CAINFO => __DIR__ . '/certs/DigiCertHighAssuranceEVRootCA.pem',
180+
CURLOPT_CAINFO => __DIR__ . '/certs/DigiCertHighAssuranceEVRootCA.pem'
181181
);
182182

183-
if ($method !== "GET") {
183+
if ($method !== 'GET') {
184184
$options[CURLOPT_POSTFIELDS] = $parameters;
185185
}
186186
if ($method === 'DELETE' || $method === 'PUT') {
187187
$options[CURLOPT_CUSTOMREQUEST] = $method;
188188
}
189189

190-
if (!empty($this->requestHeaders)) {
190+
if (count($this->requestHeaders) > 0) {
191191
$options[CURLOPT_HTTPHEADER] = $this->compileRequestHeaders();
192192
}
193193

‎src/Facebook/HttpClients/FacebookGuzzleHttpClient.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public function getResponseHttpStatusCode()
101101
*
102102
* @throws \Facebook\FacebookSDKException
103103
*/
104-
public function send($url, $method = 'GET', $parameters = array())
104+
public function send($url, $method = 'GET', array $parameters = array())
105105
{
106106
$options = array();
107107
if ($parameters) {

‎src/Facebook/HttpClients/FacebookHttpable.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,6 @@ public function getResponseHttpStatusCode();
6363
*
6464
* @throws \Facebook\FacebookSDKException
6565
*/
66-
public function send($url, $method = 'GET', $parameters = array());
66+
public function send($url, $method = 'GET', array $parameters = array());
6767

6868
}

0 commit comments

Comments
 (0)