Merge pull request #123 from Ashpants/typehint

Fosco Marotto · Fosco Marotto · commit 487e623a335e · 2014-06-16T15:25:55.000-07:00
Type hinting generates better error messages when an invalid session is ...
diff --git a/src/Facebook/FacebookRedirectLoginHelper.php b/src/Facebook/FacebookRedirectLoginHelper.php
@@ -112,7 +112,7 @@ public function getLoginUrl($scope = array(), $version = null)
    *
    * @return string
    */
-  public function getLogoutUrl($session, $next)
+  public function getLogoutUrl(FacebookSession $session, $next)
   {
     $params = array(
       'next' => $next,
diff --git a/src/Facebook/FacebookRequest.php b/src/Facebook/FacebookRequest.php
@@ -179,7 +179,7 @@ public static function getHttpClientHandler()
    * @param string|null $etag
    */
   public function __construct(
-    $session, $method, $path, $parameters = null, $version = null, $etag = null
+    FacebookSession $session, $method, $path, $parameters = null, $version = null, $etag = null
   )
   {
     $this->session = $session;

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public function getLoginUrl($scope = array(), $version = null)`
`112`	`112`	`*`
`113`	`113`	`* @return string`
`114`	`114`	`*/`
`115`		`- public function getLogoutUrl($session, $next)`
	`115`	`+ public function getLogoutUrl(FacebookSession $session, $next)`
`116`	`116`	`{`
`117`	`117`	`$params = array(`
`118`	`118`	`'next' => $next,`
Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ public static function getHttpClientHandler()`
`179`	`179`	`* @param string\|null $etag`
`180`	`180`	`*/`
`181`	`181`	`public function __construct(`
`182`		`- $session, $method, $path, $parameters = null, $version = null, $etag = null`
	`182`	`+ FacebookSession $session, $method, $path, $parameters = null, $version = null, $etag = null`
`183`	`183`	`)`
`184`	`184`	`{`
`185`	`185`	`$this->session = $session;`