Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

Commit 7c00055

Browse files
author
Fosco Marotto
committed
Merge pull request #86 from facebook/gFosco.canvas
Stop canvas helper from throwing when logged out.
2 parents db3109d + 6c934a9 commit 7c00055

File tree

3 files changed

+19
-2
lines changed

3 files changed

+19
-2
lines changed

src/Facebook/FacebookCanvasLoginHelper.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,15 @@ class FacebookCanvasLoginHelper
4141
public function getSession()
4242
{
4343
if ($signedRequest = $this->getSignedRequest()) {
44-
return FacebookSession::newSessionFromSignedRequest($signedRequest);
44+
try {
45+
return FacebookSession::newSessionFromSignedRequest($signedRequest);
46+
} catch (FacebookSDKException $ex) {
47+
// Signed request is valid but user is not logged in.
48+
if ($ex->getCode() == 603) {
49+
return null;
50+
}
51+
throw $ex;
52+
}
4553
}
4654
return null;
4755
}

src/Facebook/FacebookRequest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class FacebookRequest
3535
/**
3636
* @const string Version number of the Facebook PHP SDK.
3737
*/
38-
const VERSION = '4.0.4';
38+
const VERSION = '4.0.6';
3939

4040
/**
4141
* @const string Default Graph API version for requests

tests/FacebookCanvasLoginHelperTest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,13 @@ public function testGetSessionFromCanvasPOST() {
3737
$this->assertTrue($session instanceof FacebookSession);
3838
$this->assertTrue($session->getToken() == 'token');
3939
}
40+
41+
public function testLoggedOutCanvasSession() {
42+
$helper = new FacebookCanvasLoginHelper();
43+
$signedRequest = FacebookSessionTest::makeSignedRequest(array(
44+
'ship' => 'love'
45+
));
46+
$_GET['signed_request'] = $signedRequest;
47+
$this->assertNull($helper->getSession());
48+
}
4049
}

0 commit comments

Comments
 (0)