Use constants also for expected value

martinstuecklschwaiger · martinstuecklschwaiger · commit 91b15a155f79 · 2018-02-08T16:12:05.000+01:00
diff --git a/tests/Helpers/FacebookRedirectLoginHelperTest.php b/tests/Helpers/FacebookRedirectLoginHelperTest.php
@@ -105,9 +105,9 @@ public function testAnAccessTokenCanBeObtainedFromRedirect()
         $accessToken = $this->redirectLoginHelper->getAccessToken($fullUrl);
 
         // code and state should be stripped from the URL
-        $expectedUrl = self::REDIRECT_URL . '?some_param=blah';
+        $expectedUrl = self::REDIRECT_URL . '?' . static::FOO_PARAM;
 
-        $this->assertEquals('foo_token_from_code|foo_code|' . $expectedUrl, $accessToken->getValue());
+        $this->assertEquals('foo_token_from_code|' . static::FOO_CODE . '|' . $expectedUrl, $accessToken->getValue());
     }
 
     public function testACustomCsprsgCanBeInjected()

Original file line number	Diff line number	Diff line change
`@@ -105,9 +105,9 @@ public function testAnAccessTokenCanBeObtainedFromRedirect()`
`105`	`105`	`$accessToken = $this->redirectLoginHelper->getAccessToken($fullUrl);`
`106`	`106`
`107`	`107`	`// code and state should be stripped from the URL`
`108`		`- $expectedUrl = self::REDIRECT_URL . '?some_param=blah';`
	`108`	`+ $expectedUrl = self::REDIRECT_URL . '?' . static::FOO_PARAM;`
`109`	`109`
`110`		`- $this->assertEquals('foo_token_from_code\|foo_code\|' . $expectedUrl, $accessToken->getValue());`
	`110`	`+ $this->assertEquals('foo_token_from_code\|' . static::FOO_CODE . '\|' . $expectedUrl, $accessToken->getValue());`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`public function testACustomCsprsgCanBeInjected()`