Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

Commit aac9f3a

Browse files
author
Fosco Marotto
committed
Merge pull request #195 from facebook/gFosco.canvasGET-40dev
Removed GET processing from CanvasLoginHelper.
2 parents ee46bce + d303ca4 commit aac9f3a

File tree

2 files changed

+1
-22
lines changed

2 files changed

+1
-22
lines changed

src/Facebook/FacebookCanvasLoginHelper.php

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,24 +43,12 @@ public function getAppData()
4343
}
4444

4545
/**
46-
* Get raw signed request from either GET or POST.
46+
* Get raw signed request from POST.
4747
*
4848
* @return string|null
4949
*/
5050
public function getRawSignedRequest()
5151
{
52-
/**
53-
* v2.0 apps use GET for Canvas signed requests.
54-
*/
55-
$rawSignedRequest = $this->getRawSignedRequestFromGet();
56-
if ($rawSignedRequest) {
57-
return $rawSignedRequest;
58-
}
59-
60-
/**
61-
* v1.0 apps use POST for Canvas signed requests, will eventually be
62-
* deprecated.
63-
*/
6452
$rawSignedRequest = $this->getRawSignedRequestFromPost();
6553
if ($rawSignedRequest) {
6654
return $rawSignedRequest;

tests/FacebookCanvasLoginHelperTest.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,6 @@ public function setUp()
1313
$this->helper = new FacebookCanvasLoginHelper('123', 'foo_app_secret');
1414
}
1515

16-
public function testSignedRequestDataCanBeRetrievedFromGetData()
17-
{
18-
$_GET['signed_request'] = $this->rawSignedRequestAuthorized;
19-
20-
$rawSignedRequest = $this->helper->getRawSignedRequest();
21-
22-
$this->assertEquals($this->rawSignedRequestAuthorized, $rawSignedRequest);
23-
}
24-
2516
public function testSignedRequestDataCanBeRetrievedFromPostData()
2617
{
2718
$_POST['signed_request'] = $this->rawSignedRequestAuthorized;

0 commit comments

Comments
 (0)