Merge pull request #186 from SammyK/fix-for-open_basedir-directive-4.0

[4.0] Fixed warnings when open_basedir directive set

Author: Fosco Marotto

src/Facebook/FacebookRedirectLoginHelper.php

@@ -241,7 +241,8 @@ public function random($bytes)
     }
     $buf = '';
     // http://sockpuppet.org/blog/2014/02/25/safely-generate-random-numbers/
-    if (is_readable('/dev/urandom')) {
+    if (!ini_get('open_basedir')
+      && is_readable('/dev/urandom')) {
       $fp = fopen('/dev/urandom', 'rb');
       if ($fp !== FALSE) {
         $buf = fread($fp, $bytes);
@@ -251,7 +252,7 @@ public function random($bytes)
         }
       }
     }
-	
+
     if (function_exists('mcrypt_create_iv')) {
         $buf = mcrypt_create_iv($bytes, MCRYPT_DEV_URANDOM);
         if ($buf !== FALSE) {

tests/FacebookRedirectLoginHelperTest.php

@@ -65,7 +65,7 @@ public function testCSPRNG()
       FacebookTestCredentials::$appId,
       FacebookTestCredentials::$appSecret
     );
-	$this->assertTrue(preg_match('/^([0-9a-f]+)$/', $helper->random(32)));
+    $this->assertEquals(1, preg_match('/^([0-9a-f]+)$/', $helper->random(32)));
   }
 
 }