feat: informative warning when calibration_contraint is out of bounds #275

Author: laresbernardo

R/R/checks.R

@@ -452,12 +452,18 @@ check_filedir <- function(plot_folder) {
 check_calibconstr <- function(calibration_constraint, iterations, trials, calibration_input) {
   if (!is.null(calibration_input)) {
     total_iters <- iterations * trials
-    if (calibration_constraint < 0.01 | calibration_constraint > 0.1) {
+    if (calibration_constraint < 0.01 || calibration_constraint > 0.1) {
+      message("calibration_constraint must be >=0.01 and <=0.1. Changed to default value: 0.1")
       calibration_constraint <- 0.1
-      message("calibration_constraint must be >=0.01 and <=0.1. Using default value 0.1")
-    } else if (total_iters * calibration_constraint < 500) {
-      warning("Calibration constraint set to be top ", calibration_constraint*100, "% calibrated models.",
-              " Only ", round(total_iters*calibration_constraint,0), " models left for pareto-optimal selection")
+    }
+    models_lower <- 500
+    if (total_iters * calibration_constraint < models_lower) {
+      warning(sprintf(paste(
+        "calibration_constraint set for top %s%% calibrated models.",
+        "%s models left for pareto-optimal selection. Minimum suggested: %s"),
+        calibration_constraint * 100,
+        round(total_iters * calibration_constraint, 0),
+        models_lower))
     }
   }
   return(calibration_constraint)