Quit oid when upload/download is requested but cache is disabled

Author: jgkamat

src/OID.cpp

@@ -293,6 +293,9 @@ static ExitStatus::ExitStatus runScript(const std::string& fileName,
 
   oid->setCacheRemoteEnabled(oidConfig.cacheRemoteUpload,
                              oidConfig.cacheRemoteDownload);
+  if (!oid->validateCache()) {
+    return ExitStatus::UsageError;
+  }
   oid->setCustomCodeFile(oidConfig.customCodeFile);
   oid->setEnableJitLogging(oidConfig.enableJitLogging);
   oid->setGenerateJitDebugInfo(oidConfig.generateJitDebug);

src/OIDebugger.h

@@ -15,6 +15,8 @@
  */
 #pragma once
 
+#include <glog/logging.h>
+
 #include <filesystem>
 #include <fstream>
 
@@ -86,6 +88,15 @@ class OIDebugger {
     cache.abortOnLoadFail = download && !upload;
   }
 
+  bool validateCache() {
+    if ((cache.enableUpload || cache.enableDownload) && !cache.isEnabled()) {
+      LOG(ERROR) << "Cache download/upload option specified when cache is "
+                    "disabled - aborting!";
+      return false;
+    }
+    return true;
+  }
+
   void setHardDisableDrgn(bool val) {
     symbols->setHardDisableDrgn(val);
   }