Skip to content

Commit eabf4d6

Browse files
committed
fix: windows compilation error
1 parent 26e5b76 commit eabf4d6

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,12 @@ target_include_directories(libFBX2glTF PUBLIC
145145
${CMAKE_CURRENT_SOURCE_DIR}/thirdparty
146146
)
147147

148+
# Missing:
149+
if(MSVC)
150+
target_compile_definitions(libFBX2glTF PRIVATE LIBXML_STATIC)
151+
target_compile_definitions(appFBX2glTF PRIVATE LIBXML_STATIC)
152+
endif()
153+
148154
target_include_directories(libFBX2glTF SYSTEM PUBLIC
149155
${FBXSDK_INCLUDE_DIR}
150156
${draco_INCLUDE_DIRS}

src/FBX2glTF.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
#define NOMINMAX
1717
// Prevent Windows from defining CopyFile macro
1818
#define WIN32_LEAN_AND_MEAN
19+
#define LIBXML_STATIC
1920
#include <Windows.h>
2021
// Undefine problematic Windows macros after inclusion
2122
#ifdef CopyFile

vcpkg.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,5 @@
99
"stb",
1010
"zlib",
1111
"cli11"
12-
],
13-
"overrides": [
14-
{
15-
"name": "libxml2",
16-
"version": "2.11.5"
17-
}
1812
]
1913
}

0 commit comments

Comments
 (0)