Skip to content

Commit 7ebd3bc

Browse files
Lena Kashtelyanfacebook-github-bot
authored andcommitted
Move all step-based GS functionality to nodes
Summary: X-link: facebook/Ax#4746 X-link: facebook/Ax#4731 A lot going on here: 1. Make `GenerationStep` a factory for `GenerationNode` by replacing its `__init__(self, ...)` constructor (which would have to return a `GStep`) with a `__new__(cls, ...)` construtor, which can return a `GNode` (magic, thanks Devmate!) 2. Adapt storage: stop storing steps and just treat them as nodes. No step-only fields will be saved going forward. Backward compatibility is handled though. 3. Change a bazillion tests and checks in downstream applications. NOTE: need to remember next steps here: https://www.internalfb.com/diff/D86066476?dst_version_fbid=732904879835890&transaction_fbid=1400151778204976, cc mgarrard sorrybigdiff Reviewed By: mgarrard Differential Revision: D80128678
1 parent 3bb1e24 commit 7ebd3bc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/test_tuning.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -341,8 +341,8 @@ def test_warm_starting_trials_produces_the_right_number_of_sobol_and_bayesian_tr
341341
)
342342

343343
value_counter = trial_results["generation_node"].value_counts().to_dict()
344-
sobol_count = value_counter["GenerationStep_0"]
345-
BoTorch_count = value_counter["GenerationStep_1"]
344+
sobol_count = value_counter["GenerationStep_0_Sobol"]
345+
BoTorch_count = value_counter["GenerationStep_1_BoTorch"]
346346

347347
assert len(trial_results) == total_trials, "Expected {} trials, got {}.".format(
348348
total_trials, len(trial_results)

0 commit comments

Comments
 (0)