Skip to content

Commit 344bf7d

Browse files
get9meta-codesync[bot]
authored andcommitted
antlir: Fix failing distro toolchain tests
Summary: D87403958 broke these tests because `feature.install` now implicitly installs xarexec into the image if we're building with the distro toolchain. We need to (a) not install xarexec if we don't need it and (b) not implicitly install it in the image_python_test macro. Test Plan: CI Tests pass: https://www.internalfb.com/intern/testinfra/testrun/2533275121767042 Reviewed By: vmagro Differential Revision: D87750611 fbshipit-source-id: 9440efa80356afdad8f29ebd102024049118e9fd
1 parent 148d268 commit 344bf7d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

antlir/antlir2/testing/image_test.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,9 @@ def image_python_test(
347347
default_rou: str | None = None,
348348
systemd: str | None = None,
349349
target_compatible_with: list[str] | Select | None = None,
350+
with_xarexec: bool = True,
350351
**kwargs):
351-
if is_facebook:
352+
if is_facebook and with_xarexec:
352353
with_xarexec = name + "--with-xarexec"
353354
image.layer(
354355
name = with_xarexec,

0 commit comments

Comments
 (0)